All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: [RFC PATCH v2 0/5] media: vsp1: Partition phased overlap support
Date: Fri,  1 Mar 2019 17:08:43 +0000	[thread overview]
Message-ID: <20190301170848.6598-1-kieran.bingham@ideasonboard.com> (raw)

From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

The UDS and SRU (and SHP) require expanded partition windows to support
overlapping partition windows as a means of discarding discontinous pixel data,
due to repeated pixels in their input filters.

The first four patches are clean ups and helpers to facilitate the
implementation of an updated procedure for calculating the partition windows.

The entities are iterated first backwards through the pipeline allowing them to
request an expanded input window if needed to satisfy their required output.

Then, as only the WPF can support clipping on the left edge, (though the UDS
can clip on it's right edge) the partition window is then propagated forwards
through the entity list allowing them to update any offset which will mark left
pixels to be discarded by the WPF.

Any expanded pixels to the right edge will automatically be clipped by the WPF
as it's partition window will remain fixed.

TODO:

There is one component left in this patch which is still to be completed. The
UDS calculation for the left input pixel position requires the output position
to be a multiple of the mp prefilter multiplier.

Getting the right correction to pull back the left window for this is still a
work in progress, and may be posted separately.

This series is posted as an RFC to get some review coverage (I'm looking at you
Laurent of course) while I continue to investigate the pull-back factor.


Kieran Bingham (5):
  media: vsp1: Define partition algorithm helper
  media: vsp1: Initialise partition windows
  media: vsp1: Document partition algorithm in code header
  media: vsp1: Split out pre-filter multiplier
  media: vsp1: Provide partition overlap algorithm

 drivers/media/platform/vsp1/vsp1_entity.h |   2 +-
 drivers/media/platform/vsp1/vsp1_pipe.c   |  48 +++++-
 drivers/media/platform/vsp1/vsp1_pipe.h   |   7 +
 drivers/media/platform/vsp1/vsp1_rpf.c    |  10 +-
 drivers/media/platform/vsp1/vsp1_sru.c    |  37 ++++-
 drivers/media/platform/vsp1/vsp1_uds.c    | 173 ++++++++++++++++++++--
 drivers/media/platform/vsp1/vsp1_video.c  |  13 +-
 drivers/media/platform/vsp1/vsp1_wpf.c    |  16 +-
 8 files changed, 276 insertions(+), 30 deletions(-)

-- 
2.19.1


             reply	other threads:[~2019-03-01 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 17:08 Kieran Bingham [this message]
2019-03-01 17:08 ` [RFC PATCH v2 1/5] media: vsp1: Define partition algorithm helper Kieran Bingham
2019-03-01 17:08 ` [RFC PATCH v2 2/5] media: vsp1: Initialise partition windows Kieran Bingham
2019-03-01 17:08 ` [RFC PATCH v2 3/5] media: vsp1: Document partition algorithm in code header Kieran Bingham
2019-03-01 17:08 ` [RFC PATCH v2 4/5] media: vsp1: Split out pre-filter multiplier Kieran Bingham
2019-03-01 17:08 ` [RFC PATCH v2 5/5] media: vsp1: Provide partition overlap algorithm Kieran Bingham
2019-03-04 11:46   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301170848.6598-1-kieran.bingham@ideasonboard.com \
    --to=kieran.bingham@ideasonboard.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.