All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [PATCH v5 2/9] drm/i915/psr: Only lookup for enabled CRTCs when forcing a fastset
Date: Tue,  5 Mar 2019 22:47:21 -0800	[thread overview]
Message-ID: <20190306064728.8234-2-jose.souza@intel.com> (raw)
In-Reply-To: <20190306064728.8234-1-jose.souza@intel.com>

Forcing a specific CRTC to the eDP connector was causing the
intel_psr_fastset_force() to mark mode_chaged in the wrong and
disabled CRTC causing no update in the PSR state.

Looks like our internal state track do not clear output_types and
has_psr in the disabled CRTCs, not sure if this is the expected
behavior or not but in the mean time this fix the issue.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 8bed73914876..6175b1d2e0c8 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -981,7 +981,8 @@ static int intel_psr_fastset_force(struct drm_i915_private *dev_priv)
 
 		intel_crtc_state = to_intel_crtc_state(crtc_state);
 
-		if (intel_crtc_has_type(intel_crtc_state, INTEL_OUTPUT_EDP) &&
+		if (crtc_state->active &&
+		    intel_crtc_has_type(intel_crtc_state, INTEL_OUTPUT_EDP) &&
 		    intel_crtc_state->has_psr) {
 			/* Mark mode as changed to trigger a pipe->update() */
 			crtc_state->mode_changed = true;
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-03-06  6:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  6:47 [PATCH v5 1/9] drm/i915/psr: Remove PSR2 FIXME José Roberto de Souza
2019-03-06  6:47 ` José Roberto de Souza [this message]
2019-03-06  6:47 ` [PATCH v5 3/9] drm/i915: Compute and commit color features in fastsets José Roberto de Souza
2019-03-06  6:47 ` [PATCH v5 4/9] drm/i915/psr: Drop test for EDP in CRTC when forcing commit José Roberto de Souza
2019-03-07 20:26   ` Dhinakaran Pandiyan
2019-03-07 22:53     ` Souza, Jose
2019-03-07 22:55       ` Pandiyan, Dhinakaran
2019-03-06  6:47 ` [PATCH v5 5/9] drm/i915/crc: Make IPS workaround generic José Roberto de Souza
2019-03-07 20:18   ` Dhinakaran Pandiyan
2019-03-07 23:02     ` Souza, Jose
2019-03-06  6:47 ` [PATCH v5 6/9] drm/i915: Disable PSR2 while getting pipe CRC José Roberto de Souza
2019-03-07 20:47   ` Dhinakaran Pandiyan
2019-03-07 23:16     ` Souza, Jose
2019-03-06  6:47 ` [PATCH v5 7/9] drm/i915: Drop redundant checks to update PSR state José Roberto de Souza
2019-03-07 21:03   ` Dhinakaran Pandiyan
2019-03-06  6:47 ` [PATCH v5 8/9] drm/i915: Force PSR exit when getting pipe CRC José Roberto de Souza
2019-03-07 21:25   ` Dhinakaran Pandiyan
2019-03-07 21:57     ` Souza, Jose
2019-03-07 22:30       ` Dhinakaran Pandiyan
2019-03-07 23:46         ` Souza, Jose
2019-03-06  6:47 ` [PATCH v5 9/9] drm/i915: Enable PSR2 by default José Roberto de Souza
2019-03-07 21:33   ` Dhinakaran Pandiyan
2019-03-07 22:01     ` Souza, Jose
2019-03-06  7:17 ` ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/9] drm/i915/psr: Remove PSR2 FIXME Patchwork
2019-03-06  7:43 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-06 10:30 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306064728.8234-2-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.