All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Preston <thomas.preston@codethink.co.uk>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, airlied@linux.ie,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Thomas Preston <thomas.preston@codethink.co.uk>
Subject: [PATCH] drm/i915/ddi: Fix default eDP detection on port A
Date: Wed,  6 Mar 2019 20:06:18 +0000	[thread overview]
Message-ID: <20190306200618.17405-1-thomas.preston@codethink.co.uk> (raw)

We rely on VBT DDI port info for eDP detection on GEN9 platforms and
above. This breaks GEN9 platforms which don't have VBT because port A
eDP now defaults to false. Fix this by defaulting to true when VBT is
missing.

Fixes: commit a98d9c1d7e9b ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection")
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
 drivers/gpu/drm/i915/intel_bios.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 1faa494e2bc9..efbbfb64b55f 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1629,6 +1629,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
 		info->supports_dvi = (port != PORT_A && port != PORT_E);
 		info->supports_hdmi = info->supports_dvi;
 		info->supports_dp = (port != PORT_E);
+		info->supports_edp = (port == PORT_A);
 	}
 }
 
-- 
2.11.0


             reply	other threads:[~2019-03-06 20:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 20:06 Thomas Preston [this message]
2019-03-06 21:44 ` ✗ Fi.CI.BAT: failure for drm/i915/ddi: Fix default eDP detection on port A Patchwork
2019-03-07  8:18 ` [PATCH] " Jani Nikula
2019-03-07  8:18   ` Jani Nikula
2019-03-07 10:02   ` Thomas Preston
2019-03-07 10:34     ` Jani Nikula
2019-03-07 10:49       ` Thomas Preston
2019-03-07 10:49         ` Thomas Preston
2019-03-07 11:32         ` Jani Nikula
2019-03-07 11:32           ` Jani Nikula
2019-03-13 16:13           ` Jani Nikula
2019-03-07 16:03       ` Thomas Preston
2019-03-07 16:03         ` Thomas Preston
2019-03-07 14:43 ` ✓ Fi.CI.BAT: success for drm/i915/ddi: Fix default eDP detection on port A (rev2) Patchwork
2019-03-07 16:06 ` ✗ Fi.CI.BAT: failure for drm/i915/ddi: Fix default eDP detection on port A (rev3) Patchwork
2019-03-07 17:20 ` ✓ Fi.CI.IGT: success for drm/i915/ddi: Fix default eDP detection on port A (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306200618.17405-1-thomas.preston@codethink.co.uk \
    --to=thomas.preston@codethink.co.uk \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.