From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Liviu Dudau <Liviu.Dudau@arm.com>, Brian Starkey <brian.starkey@arm.com>, Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: [PATCH v6 01/18] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Date: Wed, 13 Mar 2019 02:05:15 +0200 [thread overview] Message-ID: <20190313000532.7087-2-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <20190313000532.7087-1-laurent.pinchart+renesas@ideasonboard.com> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to the DU continuously") The DU output mode does not rely on frames being supplied on the WPF as its pipeline is supplied from DRM. For the upcoming WPF writeback functionality, we will choose to enable writeback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 7ceaf3222145..328d686189be 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -307,11 +307,6 @@ static int vsp1_video_pipeline_setup_partitions(struct vsp1_pipeline *pipe) * This function completes the current buffer by filling its sequence number, * time stamp and payload size, and hands it back to the videobuf core. * - * When operating in DU output mode (deep pipeline to the DU through the LIF), - * the VSP1 needs to constantly supply frames to the display. In that case, if - * no other buffer is queued, reuse the one that has just been processed instead - * of handing it back to the videobuf core. - * * Return the next queued buffer or NULL if the queue is empty. */ static struct vsp1_vb2_buffer * @@ -333,12 +328,6 @@ vsp1_video_complete_buffer(struct vsp1_video *video) done = list_first_entry(&video->irqqueue, struct vsp1_vb2_buffer, queue); - /* In DU output mode reuse the buffer if the list is singular. */ - if (pipe->lif && list_is_singular(&video->irqqueue)) { - spin_unlock_irqrestore(&video->irqlock, flags); - return done; - } - list_del(&done->queue); if (!list_empty(&video->irqqueue)) -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham@ideasonboard.com>, Liviu Dudau <Liviu.Dudau@arm.com>, linux-media@vger.kernel.org Subject: [PATCH v6 01/18] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Date: Wed, 13 Mar 2019 02:05:15 +0200 [thread overview] Message-ID: <20190313000532.7087-2-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <20190313000532.7087-1-laurent.pinchart+renesas@ideasonboard.com> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to the DU continuously") The DU output mode does not rely on frames being supplied on the WPF as its pipeline is supplied from DRM. For the upcoming WPF writeback functionality, we will choose to enable writeback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 7ceaf3222145..328d686189be 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -307,11 +307,6 @@ static int vsp1_video_pipeline_setup_partitions(struct vsp1_pipeline *pipe) * This function completes the current buffer by filling its sequence number, * time stamp and payload size, and hands it back to the videobuf core. * - * When operating in DU output mode (deep pipeline to the DU through the LIF), - * the VSP1 needs to constantly supply frames to the display. In that case, if - * no other buffer is queued, reuse the one that has just been processed instead - * of handing it back to the videobuf core. - * * Return the next queued buffer or NULL if the queue is empty. */ static struct vsp1_vb2_buffer * @@ -333,12 +328,6 @@ vsp1_video_complete_buffer(struct vsp1_video *video) done = list_first_entry(&video->irqqueue, struct vsp1_vb2_buffer, queue); - /* In DU output mode reuse the buffer if the list is singular. */ - if (pipe->lif && list_is_singular(&video->irqqueue)) { - spin_unlock_irqrestore(&video->irqlock, flags); - return done; - } - list_del(&done->queue); if (!list_empty(&video->irqqueue)) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-13 0:05 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-13 0:05 [PATCH v6 00/18] R-Car DU display writeback support Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart [this message] 2019-03-13 0:05 ` [PATCH v6 01/18] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 02/18] media: vsp1: wpf: Fix partition configuration for display pipelines Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 03/18] media: vsp1: Replace leftover occurrence of fragment with body Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 04/18] media: vsp1: Fix addresses of display-related registers for VSP-DL Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 05/18] media: vsp1: Replace the display list internal flag with a flags field Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 06/18] media: vsp1: Add vsp1_dl_list argument to .configure_stream() operation Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 10:36 ` Kieran Bingham 2019-03-13 10:36 ` Kieran Bingham 2019-03-13 0:05 ` [PATCH v6 07/18] media: vsp1: dl: Allow chained display lists for display pipelines Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:07 ` Kieran Bingham 2019-03-13 11:07 ` Kieran Bingham 2019-03-13 0:05 ` [PATCH v6 08/18] media: vsp1: wpf: Add writeback support Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 10:59 ` Kieran Bingham 2019-03-13 10:59 ` Kieran Bingham 2019-03-13 11:15 ` Laurent Pinchart 2019-03-13 11:15 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 09/18] media: vsp1: drm: Split RPF format setting to separate function Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:12 ` Kieran Bingham 2019-03-13 11:12 ` Kieran Bingham 2019-03-13 11:17 ` Laurent Pinchart 2019-03-13 11:17 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 10/18] media: vsp1: drm: Extend frame completion API to the DU driver Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:26 ` Kieran Bingham 2019-03-13 11:26 ` Kieran Bingham 2019-03-13 15:50 ` Laurent Pinchart 2019-03-13 15:50 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 11/18] media: vsp1: drm: Implement writeback support Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:42 ` Kieran Bingham 2019-03-13 11:42 ` Kieran Bingham 2019-03-13 15:56 ` Laurent Pinchart 2019-03-13 15:56 ` Laurent Pinchart 2019-03-14 8:28 ` Kieran Bingham 2019-03-14 8:28 ` Kieran Bingham 2019-03-14 12:09 ` Laurent Pinchart 2019-03-14 12:09 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 12/18] drm: writeback: Cleanup job ownership handling when queuing job Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:45 ` Kieran Bingham 2019-03-13 11:45 ` Kieran Bingham 2019-03-13 0:05 ` [PATCH v6 13/18] drm: writeback: Fix leak of writeback job Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 14/18] drm: writeback: Add job prepare and cleanup operations Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-15 17:54 ` Liviu Dudau 2019-03-15 17:54 ` Liviu Dudau 2019-03-13 0:05 ` [PATCH v6 15/18] drm: rcar-du: Fix rcar_du_crtc structure documentation Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 16/18] drm: rcar-du: Store V4L2 fourcc in rcar_du_format_info structure Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 0:05 ` [PATCH v6 17/18] drm: rcar-du: vsp: Extract framebuffer (un)mapping to separate functions Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 11:54 ` Kieran Bingham 2019-03-13 11:54 ` Kieran Bingham 2019-03-13 0:05 ` [PATCH v6 18/18] drm: rcar-du: Add writeback support for R-Car Gen3 Laurent Pinchart 2019-03-13 0:05 ` Laurent Pinchart 2019-03-13 12:06 ` Kieran Bingham 2019-03-13 12:06 ` Kieran Bingham 2019-03-13 16:08 ` Laurent Pinchart 2019-03-13 16:08 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190313000532.7087-2-laurent.pinchart+renesas@ideasonboard.com \ --to=laurent.pinchart+renesas@ideasonboard.com \ --cc=Liviu.Dudau@arm.com \ --cc=brian.starkey@arm.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kieran.bingham@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.