From: Steven Price <steven.price@arm.com> To: linux-mm@kvack.org Cc: "Steven Price" <steven.price@arm.com>, "Andy Lutomirski" <luto@kernel.org>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Arnd Bergmann" <arnd@arndb.de>, "Borislav Petkov" <bp@alien8.de>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Ingo Molnar" <mingo@redhat.com>, "James Morse" <james.morse@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <will.deacon@arm.com>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Rutland" <Mark.Rutland@arm.com>, "Liang, Kan" <kan.liang@linux.intel.com> Subject: [PATCH v5 14/19] x86: mm: Don't display pages which aren't present in debugfs Date: Thu, 21 Mar 2019 14:19:48 +0000 [thread overview] Message-ID: <20190321141953.31960-15-steven.price@arm.com> (raw) In-Reply-To: <20190321141953.31960-1-steven.price@arm.com> For the /sys/kernel/debug/page_tables/ files, rather than outputing a mostly empty line when a block of memory isn't present just skip the line. This keeps the output shorter and will help with a future change switching to using the generic page walk code as we no longer care about the 'level' that the page table holes are at. Signed-off-by: Steven Price <steven.price@arm.com> --- arch/x86/mm/dump_pagetables.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index ca270fb00805..e2b53db92c34 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -304,8 +304,8 @@ static void note_page(struct seq_file *m, struct pg_state *st, /* * Now print the actual finished series */ - if (!st->marker->max_lines || - st->lines < st->marker->max_lines) { + if ((cur & _PAGE_PRESENT) && (!st->marker->max_lines || + st->lines < st->marker->max_lines)) { pt_dump_seq_printf(m, st->to_dmesg, "0x%0*lx-0x%0*lx ", width, st->start_address, @@ -321,7 +321,8 @@ static void note_page(struct seq_file *m, struct pg_state *st, printk_prot(m, st->current_prot, st->level, st->to_dmesg); } - st->lines++; + if (cur & _PAGE_PRESENT) + st->lines++; /* * We print markers for special areas of address space, -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: linux-mm@kvack.org Cc: "Mark Rutland" <Mark.Rutland@arm.com>, x86@kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Will Deacon" <will.deacon@arm.com>, linux-kernel@vger.kernel.org, "Steven Price" <steven.price@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: [PATCH v5 14/19] x86: mm: Don't display pages which aren't present in debugfs Date: Thu, 21 Mar 2019 14:19:48 +0000 [thread overview] Message-ID: <20190321141953.31960-15-steven.price@arm.com> (raw) In-Reply-To: <20190321141953.31960-1-steven.price@arm.com> For the /sys/kernel/debug/page_tables/ files, rather than outputing a mostly empty line when a block of memory isn't present just skip the line. This keeps the output shorter and will help with a future change switching to using the generic page walk code as we no longer care about the 'level' that the page table holes are at. Signed-off-by: Steven Price <steven.price@arm.com> --- arch/x86/mm/dump_pagetables.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index ca270fb00805..e2b53db92c34 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -304,8 +304,8 @@ static void note_page(struct seq_file *m, struct pg_state *st, /* * Now print the actual finished series */ - if (!st->marker->max_lines || - st->lines < st->marker->max_lines) { + if ((cur & _PAGE_PRESENT) && (!st->marker->max_lines || + st->lines < st->marker->max_lines)) { pt_dump_seq_printf(m, st->to_dmesg, "0x%0*lx-0x%0*lx ", width, st->start_address, @@ -321,7 +321,8 @@ static void note_page(struct seq_file *m, struct pg_state *st, printk_prot(m, st->current_prot, st->level, st->to_dmesg); } - st->lines++; + if (cur & _PAGE_PRESENT) + st->lines++; /* * We print markers for special areas of address space, -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-21 14:21 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-21 14:19 [PATCH v5 00/19] Convert x86 & arm64 to use generic page walk Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 01/19] arc: mm: Add p?d_large() definitions Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 02/19] arm64: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 03/19] mips: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 04/19] powerpc: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 05/19] riscv: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 06/19] s390: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 07/19] sparc: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 08/19] x86: " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 09/19] mm: Add generic p?d_large() macros Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 10/19] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 21:15 ` Mike Rapoport 2019-03-21 21:15 ` Mike Rapoport 2019-03-22 10:11 ` Steven Price 2019-03-22 10:11 ` Steven Price 2019-03-22 10:29 ` Mike Rapoport 2019-03-22 10:29 ` Mike Rapoport 2019-03-22 10:37 ` Steven Price 2019-03-22 10:37 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 11/19] mm: pagewalk: Allow walking without vma Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 12/19] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 13/19] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` Steven Price [this message] 2019-03-21 14:19 ` [PATCH v5 14/19] x86: mm: Don't display pages which aren't present in debugfs Steven Price 2019-03-21 14:19 ` [PATCH v5 15/19] x86: mm: Point to struct seq_file from struct pg_state Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 16/19] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 17/19] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 18/19] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-03-21 14:19 ` Steven Price 2019-03-21 14:19 ` [PATCH v5 19/19] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-03-21 14:19 ` Steven Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190321141953.31960-15-steven.price@arm.com \ --to=steven.price@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.