All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
	byungchul.park@lge.com, Ingo Molnar <mingo@redhat.com>,
	Josh Triplett <josh@joshtriplett.org>,
	kernel-team@android.com, Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kselftest@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"Paul E. McKenney" <paulmck@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	rcu@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Will Deacon <will.deacon@arm.com>
Subject: [PATCH v2 4/4] rcutorture: Add cpu0 to the set of CPUs to add jitter
Date: Tue, 26 Mar 2019 15:24:11 -0400	[thread overview]
Message-ID: <20190326192411.198070-4-joel@joelfernandes.org> (raw)
In-Reply-To: <20190326192411.198070-1-joel@joelfernandes.org>

jitter.sh currently does not add CPU0 to the list of CPUs for adding of
jitter. Let us add it to this list even when it is not hot-pluggable.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 tools/testing/selftests/rcutorture/bin/jitter.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh
index 47bd9829dc55..26faf5824a1f 100755
--- a/tools/testing/selftests/rcutorture/bin/jitter.sh
+++ b/tools/testing/selftests/rcutorture/bin/jitter.sh
@@ -49,8 +49,12 @@ do
 
 	# Set affinity to randomly selected online CPU
 	cpus=`grep 1 /sys/devices/system/cpu/*/online |
-		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' |
-		grep -v '^0*$'`
+		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//'`
+
+	# Do not leave out poor old cpu0 which may not be hot-pluggable
+	if [ ! -f "/sys/devices/system/cpu/cpu0/online" ]; then
+		cpus="0 $cpus"
+	fi
 
 	cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN {
 		srand(n + me + systime());
-- 
2.21.0.392.gf8f6787159e-goog


WARNING: multiple messages have this Message-ID (diff)
From: joel at joelfernandes.org (Joel Fernandes (Google))
Subject: [PATCH v2 4/4] rcutorture: Add cpu0 to the set of CPUs to add jitter
Date: Tue, 26 Mar 2019 15:24:11 -0400	[thread overview]
Message-ID: <20190326192411.198070-4-joel@joelfernandes.org> (raw)
In-Reply-To: <20190326192411.198070-1-joel@joelfernandes.org>

jitter.sh currently does not add CPU0 to the list of CPUs for adding of
jitter. Let us add it to this list even when it is not hot-pluggable.

Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>
---
 tools/testing/selftests/rcutorture/bin/jitter.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh
index 47bd9829dc55..26faf5824a1f 100755
--- a/tools/testing/selftests/rcutorture/bin/jitter.sh
+++ b/tools/testing/selftests/rcutorture/bin/jitter.sh
@@ -49,8 +49,12 @@ do
 
 	# Set affinity to randomly selected online CPU
 	cpus=`grep 1 /sys/devices/system/cpu/*/online |
-		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' |
-		grep -v '^0*$'`
+		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//'`
+
+	# Do not leave out poor old cpu0 which may not be hot-pluggable
+	if [ ! -f "/sys/devices/system/cpu/cpu0/online" ]; then
+		cpus="0 $cpus"
+	fi
 
 	cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN {
 		srand(n + me + systime());
-- 
2.21.0.392.gf8f6787159e-goog

WARNING: multiple messages have this Message-ID (diff)
From: joel@joelfernandes.org (Joel Fernandes (Google))
Subject: [PATCH v2 4/4] rcutorture: Add cpu0 to the set of CPUs to add jitter
Date: Tue, 26 Mar 2019 15:24:11 -0400	[thread overview]
Message-ID: <20190326192411.198070-4-joel@joelfernandes.org> (raw)
Message-ID: <20190326192411.r8CuQwCGXsyCF9ZafCieYTf4V8Pn7l2g09PhaP_CGUo@z> (raw)
In-Reply-To: <20190326192411.198070-1-joel@joelfernandes.org>

jitter.sh currently does not add CPU0 to the list of CPUs for adding of
jitter. Let us add it to this list even when it is not hot-pluggable.

Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>
---
 tools/testing/selftests/rcutorture/bin/jitter.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh
index 47bd9829dc55..26faf5824a1f 100755
--- a/tools/testing/selftests/rcutorture/bin/jitter.sh
+++ b/tools/testing/selftests/rcutorture/bin/jitter.sh
@@ -49,8 +49,12 @@ do
 
 	# Set affinity to randomly selected online CPU
 	cpus=`grep 1 /sys/devices/system/cpu/*/online |
-		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' |
-		grep -v '^0*$'`
+		sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//'`
+
+	# Do not leave out poor old cpu0 which may not be hot-pluggable
+	if [ ! -f "/sys/devices/system/cpu/cpu0/online" ]; then
+		cpus="0 $cpus"
+	fi
 
 	cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN {
 		srand(n + me + systime());
-- 
2.21.0.392.gf8f6787159e-goog

  parent reply	other threads:[~2019-03-26 19:24 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 19:24 [PATCH v2 1/4] lockdep: Add assertion to check if in an interrupt Joel Fernandes (Google)
2019-03-26 19:24 ` Joel Fernandes (Google)
2019-03-26 19:24 ` joel
2019-03-26 19:24 ` [PATCH v2 2/4] rcutree: Add checks for dynticks counters in rcu_is_cpu_rrupt_from_idle Joel Fernandes (Google)
2019-03-26 19:24   ` Joel Fernandes (Google)
2019-03-26 19:24   ` joel
2019-03-27  2:47   ` Paul E. McKenney
2019-03-27  2:47     ` Paul E. McKenney
2019-03-27  2:47     ` paulmck
2019-03-27 15:34     ` Joel Fernandes
2019-03-27 15:34       ` Joel Fernandes
2019-03-27 15:34       ` joel
2019-03-27 15:53       ` Paul E. McKenney
2019-03-27 15:53         ` Paul E. McKenney
2019-03-27 15:53         ` paulmck
2019-03-27 17:45         ` Joel Fernandes
2019-03-27 17:45           ` Joel Fernandes
2019-03-27 17:45           ` joel
2019-03-27 18:44           ` Paul E. McKenney
2019-03-27 18:44             ` Paul E. McKenney
2019-03-27 18:44             ` paulmck
2019-03-27 21:38             ` Joel Fernandes
2019-03-27 21:38               ` Joel Fernandes
2019-03-27 21:38               ` joel
2019-03-28 15:06               ` Paul E. McKenney
2019-03-28 15:06                 ` Paul E. McKenney
2019-03-28 15:06                 ` paulmck
2019-03-26 19:24 ` [PATCH v2 3/4] rcutorture: Select from only online CPUs Joel Fernandes (Google)
2019-03-26 19:24   ` Joel Fernandes (Google)
2019-03-26 19:24   ` joel
2019-03-26 19:24 ` Joel Fernandes (Google) [this message]
2019-03-26 19:24   ` [PATCH v2 4/4] rcutorture: Add cpu0 to the set of CPUs to add jitter Joel Fernandes (Google)
2019-03-26 19:24   ` joel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326192411.198070-4-joel@joelfernandes.org \
    --to=joel@joelfernandes.org \
    --cc=byungchul.park@lge.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.