All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/9] iotests: Fix test 200 on s390x without virtio-pci
Date: Tue,  2 Apr 2019 14:48:59 +0200	[thread overview]
Message-ID: <20190402124907.24421-2-kwolf@redhat.com> (raw)
In-Reply-To: <20190402124907.24421-1-kwolf@redhat.com>

From: Thomas Huth <thuth@redhat.com>

virtio-pci is optional on s390x, e.g. in downstream RHEL builds, it
is disabled. On s390x, virtio-ccw should be used instead. Other tests
like 051 or 240 already use virtio-scsi-ccw instead of virtio-scsi-pci
on s390x, so let's do the same here and always use virtio-scsi-ccw on
s390x.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/200 | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200
index 12d25f4a1c..1c0f8cafc2 100755
--- a/tests/qemu-iotests/200
+++ b/tests/qemu-iotests/200
@@ -52,13 +52,21 @@ ${QEMU_IMG} create -f $IMGFMT -F $IMGFMT "${TEST_IMG}" -b "${BACKING_IMG}" 512M
 
 ${QEMU_IO} -c "write -P 0xa5 512 300M" "${BACKING_IMG}" | _filter_qemu_io
 
+case "$QEMU_DEFAULT_MACHINE" in
+  s390-ccw-virtio)
+      virtio_scsi="-device virtio-scsi-ccw,id=scsi0,iothread=iothread0"
+      ;;
+  *)
+      virtio_scsi="-device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0
+          -device virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0"
+      ;;
+esac
+
 echo
 echo === Starting QEMU VM ===
 echo
 qemu_comm_method="qmp"
-_launch_qemu -device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0 \
-             -object iothread,id=iothread0 \
-             -device virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0 \
+_launch_qemu -object iothread,id=iothread0 $virtio_scsi \
              -drive file="${TEST_IMG}",media=disk,if=none,cache=$CACHEMODE,id=drive_sysdisk,format=$IMGFMT \
              -device scsi-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0
 h1=$QEMU_HANDLE
-- 
2.20.1

  reply	other threads:[~2019-04-02 12:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02 12:48 [Qemu-devel] [PULL 0/9] Block layer patches Kevin Wolf
2019-04-02 12:48 ` Kevin Wolf [this message]
2019-04-02 12:49 ` [Qemu-devel] [PULL 2/9] qemu-img: Enable BDRV_REQ_MAY_UNMAP in convert Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 3/9] block/gluster: limit the transfer size to 512 MiB Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 4/9] tests/qemu-iotests: Remove redundant COPYING file Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 5/9] block/file-posix: do not fail on unlock bytes Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 6/9] block: continue until base is found in bdrv_freeze_backing_chain() et al Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 7/9] block: freeze the backing chain earlier in stream_start() Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 8/9] block: test block-stream with a base node that is used by block-commit Kevin Wolf
2019-04-02 12:49 ` [Qemu-devel] [PULL 9/9] tests/qemu-iotests/235: Allow fallback to tcg Kevin Wolf
2019-04-02 13:51 ` [Qemu-devel] [PULL 0/9] Block layer patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402124907.24421-2-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.