All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trondmy@gmail.com>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 08/29] SUNRPC: Simplify queue timeouts using timer_reduce()
Date: Sun,  7 Apr 2019 13:58:51 -0400	[thread overview]
Message-ID: <20190407175912.23528-9-trond.myklebust@hammerspace.com> (raw)
In-Reply-To: <20190407175912.23528-8-trond.myklebust@hammerspace.com>

Simplify the setting of queue timeouts by using the timer_reduce()
function.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
 include/linux/sunrpc/sched.h | 1 -
 net/sunrpc/sched.c           | 6 ++----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h
index 0b7d333f624e..c41f5f498b3b 100644
--- a/include/linux/sunrpc/sched.h
+++ b/include/linux/sunrpc/sched.h
@@ -183,7 +183,6 @@ struct rpc_task_setup {
 struct rpc_timer {
 	struct timer_list timer;
 	struct list_head list;
-	unsigned long expires;
 };
 
 /*
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
index 40944c34a9e4..301e0f7f1dc9 100644
--- a/net/sunrpc/sched.c
+++ b/net/sunrpc/sched.c
@@ -92,8 +92,7 @@ __rpc_disable_timer(struct rpc_wait_queue *queue, struct rpc_task *task)
 static void
 rpc_set_queue_timer(struct rpc_wait_queue *queue, unsigned long expires)
 {
-	queue->timer_list.expires = expires;
-	mod_timer(&queue->timer_list.timer, expires);
+	timer_reduce(&queue->timer_list.timer, expires);
 }
 
 /*
@@ -107,8 +106,7 @@ __rpc_add_timer(struct rpc_wait_queue *queue, struct rpc_task *task,
 		task->tk_pid, jiffies_to_msecs(timeout - jiffies));
 
 	task->tk_timeout = timeout;
-	if (list_empty(&queue->timer_list.list) || time_before(timeout, queue->timer_list.expires))
-		rpc_set_queue_timer(queue, timeout);
+	rpc_set_queue_timer(queue, timeout);
 	list_add(&task->u.tk_wait.timer_list, &queue->timer_list.list);
 }
 
-- 
2.20.1


  reply	other threads:[~2019-04-07 18:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-07 17:58 [PATCH v3 00/29] Fix up soft mounts for NFSv4.x Trond Myklebust
2019-04-07 17:58 ` [PATCH v3 01/29] SUNRPC: Fix up task signalling Trond Myklebust
2019-04-07 17:58   ` [PATCH v3 02/29] SUNRPC: Refactor rpc_restart_call/rpc_restart_call_prepare Trond Myklebust
2019-04-07 17:58     ` [PATCH v3 03/29] SUNRPC: Refactor xprt_request_wait_receive() Trond Myklebust
2019-04-07 17:58       ` [PATCH v3 04/29] SUNRPC: Refactor rpc_sleep_on() Trond Myklebust
2019-04-07 17:58         ` [PATCH v3 05/29] SUNRPC: Remove unused argument 'action' from rpc_sleep_on_priority() Trond Myklebust
2019-04-07 17:58           ` [PATCH v3 06/29] SUNRPC: Add function rpc_sleep_on_timeout() Trond Myklebust
2019-04-07 17:58             ` [PATCH v3 07/29] SUNRPC: Fix up tracking of timeouts Trond Myklebust
2019-04-07 17:58               ` Trond Myklebust [this message]
2019-04-07 17:58                 ` [PATCH v3 09/29] SUNRPC: Declare RPC timers as TIMER_DEFERRABLE Trond Myklebust
2019-04-07 17:58                   ` [PATCH v3 10/29] SUNRPC: Ensure that the transport layer respect major timeouts Trond Myklebust
2019-04-07 17:58                     ` [PATCH v3 11/29] SUNRPC: Add tracking of RPC level errors Trond Myklebust
2019-04-07 17:58                       ` [PATCH v3 12/29] SUNRPC: Make "no retrans timeout" soft tasks behave like softconn for timeouts Trond Myklebust
2019-04-07 17:58                         ` [PATCH v3 13/29] SUNRPC: Start the first major timeout calculation at task creation Trond Myklebust
2019-04-07 17:58                           ` [PATCH v3 14/29] SUNRPC: Ensure to ratelimit the "server not responding" syslog messages Trond Myklebust
2019-04-07 17:58                             ` [PATCH v3 15/29] SUNRPC: Add the 'softerr' rpc_client flag Trond Myklebust
2019-04-07 17:58                               ` [PATCH v3 16/29] NFS: Consider ETIMEDOUT to be a fatal error Trond Myklebust
2019-04-07 17:59                                 ` [PATCH v3 17/29] NFS: Move internal constants out of uapi/linux/nfs_mount.h Trond Myklebust
2019-04-07 17:59                                   ` [PATCH v3 18/29] NFS: Add a mount option "softerr" to allow clients to see ETIMEDOUT errors Trond Myklebust
2019-04-07 17:59                                     ` [PATCH v3 19/29] NFS: Don't interrupt file writeout due to fatal errors Trond Myklebust
2019-04-07 17:59                                       ` [PATCH v3 20/29] NFS: Don't call generic_error_remove_page() while holding locks Trond Myklebust
2019-04-07 17:59                                         ` [PATCH v3 21/29] NFS: Don't inadvertently clear writeback errors Trond Myklebust
2019-04-07 17:59                                           ` [PATCH v3 22/29] NFS: Replace custom error reporting mechanism with generic one Trond Myklebust
2019-04-07 17:59                                             ` [PATCH v3 23/29] NFS: Fix up NFS I/O subrequest creation Trond Myklebust
2019-04-07 17:59                                               ` [PATCH v3 24/29] NFS: Remove unused argument from nfs_create_request() Trond Myklebust
2019-04-07 17:59                                                 ` [PATCH v3 25/29] pNFS: Add tracking to limit the number of pNFS retries Trond Myklebust
2019-04-07 17:59                                                   ` [PATCH v3 26/29] NFS: Allow signal interruption of NFS4ERR_DELAYed operations Trond Myklebust
2019-04-07 17:59                                                     ` [PATCH v3 27/29] NFS: Ensure that all nfs lock contexts have a valid open context Trond Myklebust
2019-04-07 17:59                                                       ` [PATCH v3 28/29] NFS: Add a helper to return a pointer to the open context of a struct nfs_page Trond Myklebust
2019-04-07 17:59                                                         ` [PATCH v3 29/29] NFS: Remove redundant open context from nfs_page Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190407175912.23528-9-trond.myklebust@hammerspace.com \
    --to=trondmy@gmail.com \
    --cc=Anna.Schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.