All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 03/10] tools lib traceevent: Removed unneeded !! and return parenthesis
Date: Mon,  8 Apr 2019 18:23:33 +0300	[thread overview]
Message-ID: <20190408152340.12450-4-tstoyanov@vmware.com> (raw)
In-Reply-To: <20190408152340.12450-1-tstoyanov@vmware.com>

From: Steven Rostedt (VMware) <rostedt@goodmis.org>

As return is not a function we do not need parenthesis around the return
value. Also, a function returning bool does not need to add !!.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Link: http://lkml.kernel.org/r/20190401164343.817886725@goodmis.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 lib/traceevent/event-parse-api.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/traceevent/event-parse-api.c b/lib/traceevent/event-parse-api.c
index f2e5d18..fb49d1b 100644
--- a/lib/traceevent/event-parse-api.c
+++ b/lib/traceevent/event-parse-api.c
@@ -88,7 +88,7 @@ void tep_clear_flag(struct tep_handle *tep, enum tep_flag flag)
 bool tep_test_flag(struct tep_handle *tep, enum tep_flag flag)
 {
 	if (tep)
-		return (tep->flags & flag);
+		return tep->flags & flag;
 	return false;
 }
 
@@ -367,7 +367,7 @@ int tep_get_parsing_failures(struct tep_handle *tep)
 bool tep_is_old_format(struct tep_handle *tep)
 {
 	if (tep)
-		return !!(tep->old_format);
+		return tep->old_format;
 	return false;
 }
 
-- 
2.20.1


  parent reply	other threads:[~2019-04-08 15:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 15:23 [PATCH v2 00/10] Backport of traceevent APIs cleanup changes from kernel tree to trace-cmd Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 01/10] tools lib traceevent: Change description of few APIs Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 02/10] tools lib traceevent: Implement new traceevent APIs for accessing struct tep_handler fields Tzvetomir Stoyanov
2019-04-08 15:23 ` Tzvetomir Stoyanov [this message]
2019-04-08 15:23 ` [PATCH v2 04/10] tools lib traceevent: Remove tep filter trivial APIs Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 05/10] tools lib traceevent: Remove call to exit() from tep_filter_add_filter_str() Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 06/10] tools tools, tools lib traceevent: Make traceevent APIs more consistent Tzvetomir Stoyanov
2019-04-08 16:39   ` Steven Rostedt
2019-04-08 15:23 ` [PATCH v2 07/10] tools lib traceevent: Rename input arguments of libtraceevent APIs from pevent to tep Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 08/10] perf tools, tools lib traceevent: Rename "pevent" member of struct tep_event to "tep" Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 09/10] perf tools, tools lib traceevent: Rename "pevent" member of struct tep_event_filter " Tzvetomir Stoyanov
2019-04-08 15:23 ` [PATCH v2 10/10] tools lib traceevent: Rename input arguments and local variables of libtraceevent from pevent to tep Tzvetomir Stoyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408152340.12450-4-tstoyanov@vmware.com \
    --to=tstoyanov@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.