All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Yong Deng <yong.deng@magewell.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH 1/6] clk: sunxi-ng: a83t: Add pll-video0 as parent of csi-mclk
Date: Tue,  9 Apr 2019 00:57:39 +0800	[thread overview]
Message-ID: <20190408165744.11672-2-wens@kernel.org> (raw)
In-Reply-To: <20190408165744.11672-1-wens@kernel.org>

From: Chen-Yu Tsai <wens@csie.org>

Allwinner's BSP for the A83T lists pll-video0 as the first parent to
csi-mclk with index 0. This parent is not listed in the datasheet, but
actually works, and makes more sense considering the index is the
default value out of reset.

Add pll-video0 as a parent to csi-mclk with index 0.

Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
index 2d6555d73170..5f714b4d8ee4 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
@@ -513,8 +513,9 @@ static SUNXI_CCU_GATE(csi_misc_clk, "csi-misc", "osc24M", 0x130, BIT(16), 0);
 
 static SUNXI_CCU_GATE(mipi_csi_clk, "mipi-csi", "osc24M", 0x130, BIT(31), 0);
 
-static const char * const csi_mclk_parents[] = { "pll-de", "osc24M" };
-static const u8 csi_mclk_table[] = { 3, 5 };
+static const char * const csi_mclk_parents[] = { "pll-video0", "pll-de",
+						 "osc24M" };
+static const u8 csi_mclk_table[] = { 0, 3, 5 };
 static SUNXI_CCU_M_WITH_MUX_TABLE_GATE(csi_mclk_clk, "csi-mclk",
 				       csi_mclk_parents, csi_mclk_table,
 				       0x134,
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Yong Deng <yong.deng@magewell.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [PATCH 1/6] clk: sunxi-ng: a83t: Add pll-video0 as parent of csi-mclk
Date: Tue,  9 Apr 2019 00:57:39 +0800	[thread overview]
Message-ID: <20190408165744.11672-2-wens@kernel.org> (raw)
In-Reply-To: <20190408165744.11672-1-wens@kernel.org>

From: Chen-Yu Tsai <wens@csie.org>

Allwinner's BSP for the A83T lists pll-video0 as the first parent to
csi-mclk with index 0. This parent is not listed in the datasheet, but
actually works, and makes more sense considering the index is the
default value out of reset.

Add pll-video0 as a parent to csi-mclk with index 0.

Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
index 2d6555d73170..5f714b4d8ee4 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
@@ -513,8 +513,9 @@ static SUNXI_CCU_GATE(csi_misc_clk, "csi-misc", "osc24M", 0x130, BIT(16), 0);
 
 static SUNXI_CCU_GATE(mipi_csi_clk, "mipi-csi", "osc24M", 0x130, BIT(31), 0);
 
-static const char * const csi_mclk_parents[] = { "pll-de", "osc24M" };
-static const u8 csi_mclk_table[] = { 3, 5 };
+static const char * const csi_mclk_parents[] = { "pll-video0", "pll-de",
+						 "osc24M" };
+static const u8 csi_mclk_table[] = { 0, 3, 5 };
 static SUNXI_CCU_M_WITH_MUX_TABLE_GATE(csi_mclk_clk, "csi-mclk",
 				       csi_mclk_parents, csi_mclk_table,
 				       0x134,
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-08 16:57 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 16:57 [PATCH 0/6] ARM: sun8i: a83t: Support Camera Sensor Interface controller Chen-Yu Tsai
2019-04-08 16:57 ` Chen-Yu Tsai
2019-04-08 16:57 ` Chen-Yu Tsai [this message]
2019-04-08 16:57   ` [PATCH 1/6] clk: sunxi-ng: a83t: Add pll-video0 as parent of csi-mclk Chen-Yu Tsai
2019-04-09  7:57   ` Maxime Ripard
2019-04-09  7:57     ` Maxime Ripard
2019-04-08 16:57 ` [PATCH 2/6] dt-bindings: media: sun6i-csi: Add compatible string for A83T variant Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-09  7:57   ` Maxime Ripard
2019-04-09  7:57     ` Maxime Ripard
2019-04-29 17:36   ` Rob Herring
2019-04-29 17:36     ` Rob Herring
2019-04-29 17:36     ` Rob Herring
2019-04-08 16:57 ` [PATCH 3/6] media: sun6i: Support " Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-09  7:56   ` Maxime Ripard
2019-04-09  7:56     ` Maxime Ripard
2019-04-08 16:57 ` [PATCH 4/6] ARM: dts: sun8i: a83t: Add device node for CSI (Camera Sensor Interface) Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-09  7:58   ` Maxime Ripard
2019-04-09  7:58     ` Maxime Ripard
2019-04-09  8:07     ` Chen-Yu Tsai
2019-04-09  8:07       ` Chen-Yu Tsai
2019-04-09  8:28       ` Maxime Ripard
2019-04-09  8:28         ` Maxime Ripard
2019-04-09  8:40         ` Chen-Yu Tsai
2019-04-09  8:40           ` Chen-Yu Tsai
2019-04-09 14:52           ` Maxime Ripard
2019-04-09 14:52             ` Maxime Ripard
2019-05-19 13:54             ` Ondřej Jirman
2019-05-19 13:54               ` Ondřej Jirman
2019-05-19 13:54               ` Ondřej Jirman
2019-05-20 11:10               ` Maxime Ripard
2019-05-20 11:10                 ` Maxime Ripard
2019-05-20 11:38                 ` Ondřej Jirman
2019-05-20 11:38                   ` Ondřej Jirman
2019-05-20 14:05                   ` Maxime Ripard
2019-05-20 14:05                     ` Maxime Ripard
2019-05-20 15:07                     ` Ondřej Jirman
2019-05-20 15:07                       ` Ondřej Jirman
2019-04-09 22:00         ` Ondřej Jirman
2019-04-09 22:00           ` Ondřej Jirman
2019-04-11 12:47           ` Paul Kocialkowski
2019-04-11 12:47             ` Paul Kocialkowski
2019-04-11 12:59             ` Ondřej Jirman
2019-04-11 12:59               ` Ondřej Jirman
2019-04-08 16:57 ` [PATCH 5/6] ARM: dts: sun8i: a83t: Add I2C2 pinmux setting for PE pins Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai
2019-04-09  7:58   ` Maxime Ripard
2019-04-09  7:58     ` Maxime Ripard
2019-04-08 16:57 ` [PATCH 6/6] [DO NOT MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable BPI OV5640 camera Chen-Yu Tsai
2019-04-08 16:57   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408165744.11672-2-wens@kernel.org \
    --to=wens@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=wens@csie.org \
    --cc=yong.deng@magewell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.