All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 7/7] drm/i915/icl: Don't warn on spurious interrupts
Date: Wed, 10 Apr 2019 13:59:23 +0300	[thread overview]
Message-ID: <20190410105923.18546-7-mika.kuoppala@linux.intel.com> (raw)
In-Reply-To: <20190410105923.18546-1-mika.kuoppala@linux.intel.com>

There is a chance we can see spurious interrupts in live
now. We have more engines enabled and that with more elaborate
access patterns with pm and display, increases the chances
hardware just makes a social call, without anything to work on.

Remove the error as we have tests to actually probe if
we really miss interrupt, instead of getting spurious ones.

Note that now we do write to intr_dw even with a zero
value. This is considered advantegous as the write
is an ack that sw is done.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 3531ef79ae21..d934545445e1 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3041,14 +3041,8 @@ gen11_gt_bank_handler(struct drm_i915_private * const i915,
 
 	intr_dw = raw_reg_read(regs, GEN11_GT_INTR_DW(bank));
 
-	if (unlikely(!intr_dw)) {
-		DRM_ERROR("GT_INTR_DW%u blank!\n", bank);
-		return;
-	}
-
 	for_each_set_bit(bit, &intr_dw, 32) {
-		const u32 ident = gen11_gt_engine_identity(i915,
-							   bank, bit);
+		const u32 ident = gen11_gt_engine_identity(i915, bank, bit);
 
 		gen11_gt_identity_handler(i915, ident);
 	}
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-04-10 10:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 10:59 [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Mika Kuoppala
2019-04-10 10:59 ` [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold Mika Kuoppala
2019-04-10 13:37   ` Chris Wilson
2019-04-10 13:53   ` Michal Wajdeczko
2019-04-10 10:59 ` [PATCH 3/7] drm/i915/icl: Enable media sampler powergate Mika Kuoppala
2019-04-10 13:38   ` Chris Wilson
2019-04-10 10:59 ` [PATCH 4/7] drm/i915/icl: Disable video turbo mode for rp control Mika Kuoppala
2019-04-10 11:04   ` Chris Wilson
2019-04-10 13:24     ` Mika Kuoppala
2019-04-10 13:43       ` Chris Wilson
2019-04-10 10:59 ` [PATCH 5/7] drm/i915/icl: Handle rps interrupts without irq lock Mika Kuoppala
2019-04-10 10:59 ` [PATCH 6/7] drm/i915: Use Engine1 instance for gen11 pm interrupts Mika Kuoppala
2019-04-10 13:39   ` Chris Wilson
2019-04-10 10:59 ` Mika Kuoppala [this message]
2019-04-10 11:07   ` [PATCH 7/7] drm/i915/icl: Don't warn on spurious interrupts Chris Wilson
2019-04-10 11:10 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Patchwork
2019-04-10 11:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-10 14:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 (rev2) Patchwork
2019-04-10 14:57 ` ✓ Fi.CI.IGT: success for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Patchwork
2019-04-10 15:01 ` ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 (rev2) Patchwork
2019-04-10 22:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-11  7:45   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410105923.18546-7-mika.kuoppala@linux.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.