From: Daniel Mack <daniel@zonque.org>
To: dmitry.torokhov@gmail.com, robh+dt@kernel.org
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Daniel Mack <daniel@zonque.org>,
Sven Neumann <Sven.Neumann@teufel.de>
Subject: [PATCH 2/2] input: touch: eeti: read hardware state once after wakeup
Date: Mon, 22 Apr 2019 10:35:40 +0200 [thread overview]
Message-ID: <20190422083540.8380-2-daniel@zonque.org> (raw)
In-Reply-To: <20190422083540.8380-1-daniel@zonque.org>
For systems in which the touch IRQ is acting as wakeup source, the interrupt
controller might not latch the GPIO IRQ during sleep. In such cases, the
interrupt will never occur again after resume, hence the touch screen
appears dead.
To fix this, call into eeti_ts_read() once to read the hardware status and
to arm the IRQ again.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Reported-by: Sven Neumann <Sven.Neumann@teufel.de>
---
drivers/input/touchscreen/eeti_ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
index f5724aaa815b..674386f910ba 100644
--- a/drivers/input/touchscreen/eeti_ts.c
+++ b/drivers/input/touchscreen/eeti_ts.c
@@ -117,6 +117,7 @@ static void eeti_ts_start(struct eeti_ts *eeti)
eeti->running = true;
wmb();
enable_irq(eeti->client->irq);
+ eeti_ts_read(eeti);
}
static void eeti_ts_stop(struct eeti_ts *eeti)
--
2.20.1
next prev parent reply other threads:[~2019-04-22 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 8:35 [PATCH 1/2] input: touch: eeti: move ISR code to own function Daniel Mack
2019-04-22 8:35 ` Daniel Mack [this message]
2019-04-23 3:17 ` [PATCH 2/2] input: touch: eeti: read hardware state once after wakeup Dmitry Torokhov
2019-04-23 4:51 ` Daniel Mack
2019-04-23 8:41 ` Dmitry Torokhov
2019-04-28 7:18 ` Daniel Mack
2019-04-28 17:36 ` Dmitry Torokhov
2019-04-28 19:30 ` Daniel Mack
2019-04-28 19:50 ` Daniel Mack
2019-04-29 1:17 ` Dmitry Torokhov
2019-04-29 5:49 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422083540.8380-2-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=Sven.Neumann@teufel.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.