All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiada Wang <jiada_wang@mentor.com>
To: <rui.zhang@intel.com>, <edubezval@gmail.com>,
	<daniel.lezcano@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<erosca@de.adit-jv.com>, <joshua_frkuska@mentor.com>,
	<jiada_wang@mentor.com>, <horms+renesas@verge.net.au>,
	<niklas.soderlund+renesas@ragnatech.se>,
	<geert+renesas@glider.be>, <sergei.shtylyov@cogentembedded.com>,
	<marek.vasut+renesas@gmail.com>,
	<kuninori.morimoto.gx@renesas.com>, <hien.dang.eb@renesas.com>,
	<fabrizio.castro@bp.renesas.com>, <dien.pham.ry@renesas.com>,
	<biju.das@bp.renesas.com>
Subject: [PATCH v2 0/2] thermal: rcar_gen3_thermal: fix IRQ issues
Date: Tue, 23 Apr 2019 15:12:16 +0900	[thread overview]
Message-ID: <20190423061218.29705-1-jiada_wang@mentor.com> (raw)

There are issues with interrupt handling in rcar_gen3_thermal driver.

Currently IRQ is remain enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
triggered but not able to clear IRQ status, thus cause system to hang.

Since the irq line isn't shared between different devices,
so the proper interrupt type flag should be IRQF_ONESHOT.

This patch-set fix these interrupt handling retated issues. 

---
v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED
    disable interrupt in .remove

v1: initial version

Jiada Wang (2):
  thermal: rcar_gen3_thermal: fix interrupt type
  thermal: rcar_gen3_thermal: disable interrupt in .remove

 drivers/thermal/rcar_gen3_thermal.c | 43 +++++++++--------------------
 1 file changed, 13 insertions(+), 30 deletions(-)

-- 
2.19.2


WARNING: multiple messages have this Message-ID (diff)
From: Jiada Wang <jiada_wang@mentor.com>
To: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	erosca@de.adit-jv.com, joshua_frkuska@mentor.com,
	jiada_wang@mentor.com, horms+renesas@verge.net.au,
	niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be,
	sergei.shtylyov@cogentembedded.com,
	marek.vasut+renesas@gmail.com, kuninori.morimoto.gx@renesas.com,
	hien.dang.eb@renesas.com, fabrizio.castro@bp.renesas.com,
	dien.pham.ry@renesas.com, biju.das@bp.renesas.com
Subject: [PATCH v2 0/2] thermal: rcar_gen3_thermal: fix IRQ issues
Date: Tue, 23 Apr 2019 15:12:16 +0900	[thread overview]
Message-ID: <20190423061218.29705-1-jiada_wang@mentor.com> (raw)

There are issues with interrupt handling in rcar_gen3_thermal driver.

Currently IRQ is remain enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
triggered but not able to clear IRQ status, thus cause system to hang.

Since the irq line isn't shared between different devices,
so the proper interrupt type flag should be IRQF_ONESHOT.

This patch-set fix these interrupt handling retated issues. 

---
v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED
    disable interrupt in .remove

v1: initial version

Jiada Wang (2):
  thermal: rcar_gen3_thermal: fix interrupt type
  thermal: rcar_gen3_thermal: disable interrupt in .remove

 drivers/thermal/rcar_gen3_thermal.c | 43 +++++++++--------------------
 1 file changed, 13 insertions(+), 30 deletions(-)

-- 
2.19.2

             reply	other threads:[~2019-04-23  6:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  6:12 Jiada Wang [this message]
2019-04-23  6:12 ` [PATCH v2 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Jiada Wang
2019-04-23  6:12 ` [PATCH v2 1/2] thermal: rcar_gen3_thermal: fix interrupt type Jiada Wang
2019-04-23  6:12   ` Jiada Wang
2019-04-23 13:07   ` Eugeniu Rosca
2019-04-23 13:07     ` Eugeniu Rosca
2019-04-23 13:09     ` Jiada Wang
2019-04-23 13:09       ` Jiada Wang
2019-04-23  6:12 ` [PATCH v2 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove Jiada Wang
2019-04-23  6:12   ` Jiada Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190423061218.29705-1-jiada_wang@mentor.com \
    --to=jiada_wang@mentor.com \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dien.pham.ry@renesas.com \
    --cc=edubezval@gmail.com \
    --cc=erosca@de.adit-jv.com \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=hien.dang.eb@renesas.com \
    --cc=horms+renesas@verge.net.au \
    --cc=joshua_frkuska@mentor.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=rui.zhang@intel.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.