All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yue Haibing <yuehaibing@huawei.com>
To: <jikos@kernel.org>, <benjamin.tissoires@redhat.com>,
	<hdegoede@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID
Date: Thu, 25 Apr 2019 15:39:42 +0800	[thread overview]
Message-ID: <20190425073942.36980-1-yuehaibing@huawei.com> (raw)

From: YueHaibing <yuehaibing@huawei.com>

During randconfig builds, I occasionally run into an invalid configuration

drivers/hid/hid-logitech-dj.o: In function `logi_dj_probe':
hid-logitech-dj.c:(.text+0x32dc): undefined reference to `usb_hid_driver'

This is because CONFIG_USB_HID is not set, So this
patch selects it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: da12b224b7d5 ("HID: logitech-dj: deal with some KVMs adding an extra interface to the usbdev")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 76d8206..c3c390c 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -521,6 +521,7 @@ config HID_LOGITECH
 
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
+	depends on USB_HID
 	depends on HIDRAW
 	depends on HID_LOGITECH
 	select HID_LOGITECH_HIDPP
-- 
2.7.4



WARNING: multiple messages have this Message-ID (diff)
From: Yue Haibing <yuehaibing@huawei.com>
To: jikos@kernel.org, benjamin.tissoires@redhat.com, hdegoede@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID
Date: Thu, 25 Apr 2019 15:39:42 +0800	[thread overview]
Message-ID: <20190425073942.36980-1-yuehaibing@huawei.com> (raw)

From: YueHaibing <yuehaibing@huawei.com>

During randconfig builds, I occasionally run into an invalid configuration

drivers/hid/hid-logitech-dj.o: In function `logi_dj_probe':
hid-logitech-dj.c:(.text+0x32dc): undefined reference to `usb_hid_driver'

This is because CONFIG_USB_HID is not set, So this
patch selects it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: da12b224b7d5 ("HID: logitech-dj: deal with some KVMs adding an extra interface to the usbdev")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 76d8206..c3c390c 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -521,6 +521,7 @@ config HID_LOGITECH
 
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
+	depends on USB_HID
 	depends on HIDRAW
 	depends on HID_LOGITECH
 	select HID_LOGITECH_HIDPP
-- 
2.7.4

             reply	other threads:[~2019-04-25  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25  7:39 Yue Haibing [this message]
2019-04-25  7:39 ` [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID Yue Haibing
2019-04-25  7:42 ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425073942.36980-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.