From: Xiaolei Li <xiaolei.li@mediatek.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at> Cc: linux-mediatek@lists.infradead.org, xiaolei.li@mediatek.com, linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com Subject: [PATCH 2/5] mtd: rawnand: mtk: Improve data sampling timing for read cycle Date: Mon, 29 Apr 2019 14:38:31 +0800 [thread overview] Message-ID: <20190429063834.45967-3-xiaolei.li@mediatek.com> (raw) In-Reply-To: <20190429063834.45967-1-xiaolei.li@mediatek.com> Currently, we expand RE# low level time by choosing the max value between RE# pulse width and RE# access time, and sample data at the rising edge of RE#. Then, if RE# access time is bigger than RE# pulse width, the real read cycle time may be more than NAND SPEC required. This makes read performance be worse than that expected. This patch improves data sampling timing by calculating RE# low level time according to RE# pulse width. If RE# access time is bigger than RE# pulse width, then delay sampling data timing. The result of contrast test base on MT2712 evaluat board is as follow. nand: Micron MT29F16G08ADBCAH4 nand: 2048 MiB, SLC, erase size: 256 KiB, page size: 4096, OOB size: 224 NFI 2x clock rate: 124800000 HZ. Test tool: mtd_speedtest.ko Read speed without this patch: mtd_speedtest: page read speed is 14012 KiB/s mtd_speedtest: 2 page read speed is 14860 KiB/s Read speed with this patch: mtd_speedtest: page read speed is 18724 KiB/s mtd_speedtest: 2 page read speed is 18713 KiB/s Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> --- drivers/mtd/nand/raw/mtk_nand.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c index dd855f860a4b..a2f7af536380 100644 --- a/drivers/mtd/nand/raw/mtk_nand.c +++ b/drivers/mtd/nand/raw/mtk_nand.c @@ -87,6 +87,10 @@ #define NFI_FDMM(x) (0xA4 + (x) * sizeof(u32) * 2) #define NFI_FDM_MAX_SIZE (8) #define NFI_FDM_MIN_SIZE (1) +#define NFI_DEBUG_CON1 (0x220) +#define STROBE_MASK GENMASK(4, 3) +#define STROBE_SHIFT (3) +#define MAX_STROBE_DLY (3) #define NFI_MASTER_STA (0x224) #define MASTER_STA_MASK (0x0FFF) #define NFI_EMPTY_THRESH (0x23C) @@ -509,6 +513,7 @@ static int mtk_nfc_setup_data_interface(struct nand_chip *chip, int csline, struct mtk_nfc *nfc = nand_get_controller_data(chip); const struct nand_sdr_timings *timings; u32 rate, tpoecs, tprecs, tc2r, tw2r, twh, twst = 0, trlt = 0; + u32 tsel, reg; timings = nand_get_sdr_timings(conf); if (IS_ERR(timings)) @@ -556,10 +561,25 @@ static int mtk_nfc_setup_data_interface(struct nand_chip *chip, int csline, if ((twh + 1) * 1000000 / rate < timings->tRC_min / 1000) trlt = (timings->tRC_min / 1000 - (twh + 1) * 1000000 / rate) * 1000; - trlt = max3(trlt, timings->tREA_max, timings->tRP_min) / 1000; + trlt = max(trlt, timings->tRP_min) / 1000; trlt = DIV_ROUND_UP(trlt * rate, 1000000) - 1; trlt &= 0xf; + /* Calculate strobe sel */ + reg = nfi_readl(nfc, NFI_DEBUG_CON1); + reg &= ~STROBE_MASK; + if ((trlt + 1) * 1000000 / rate < timings->tREA_max / 1000) { + tsel = timings->tREA_max / 1000; + tsel = DIV_ROUND_UP(tsel * rate, 1000000); + tsel -= (trlt + 1); + if (tsel > MAX_STROBE_DLY) { + trlt += tsel - MAX_STROBE_DLY; + tsel = MAX_STROBE_DLY; + } + reg |= tsel << STROBE_SHIFT; + } + nfi_writel(nfc, reg, NFI_DEBUG_CON1); + /* * ACCON: access timing control register * ------------------------------------- -- 2.18.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Xiaolei Li <xiaolei.li@mediatek.com> To: miquel.raynal@bootlin.com, richard@nod.at Cc: linux-mediatek@lists.infradead.org, xiaolei.li@mediatek.com, linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com Subject: [PATCH 2/5] mtd: rawnand: mtk: Improve data sampling timing for read cycle Date: Mon, 29 Apr 2019 14:38:31 +0800 [thread overview] Message-ID: <20190429063834.45967-3-xiaolei.li@mediatek.com> (raw) In-Reply-To: <20190429063834.45967-1-xiaolei.li@mediatek.com> Currently, we expand RE# low level time by choosing the max value between RE# pulse width and RE# access time, and sample data at the rising edge of RE#. Then, if RE# access time is bigger than RE# pulse width, the real read cycle time may be more than NAND SPEC required. This makes read performance be worse than that expected. This patch improves data sampling timing by calculating RE# low level time according to RE# pulse width. If RE# access time is bigger than RE# pulse width, then delay sampling data timing. The result of contrast test base on MT2712 evaluat board is as follow. nand: Micron MT29F16G08ADBCAH4 nand: 2048 MiB, SLC, erase size: 256 KiB, page size: 4096, OOB size: 224 NFI 2x clock rate: 124800000 HZ. Test tool: mtd_speedtest.ko Read speed without this patch: mtd_speedtest: page read speed is 14012 KiB/s mtd_speedtest: 2 page read speed is 14860 KiB/s Read speed with this patch: mtd_speedtest: page read speed is 18724 KiB/s mtd_speedtest: 2 page read speed is 18713 KiB/s Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> --- drivers/mtd/nand/raw/mtk_nand.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c index dd855f860a4b..a2f7af536380 100644 --- a/drivers/mtd/nand/raw/mtk_nand.c +++ b/drivers/mtd/nand/raw/mtk_nand.c @@ -87,6 +87,10 @@ #define NFI_FDMM(x) (0xA4 + (x) * sizeof(u32) * 2) #define NFI_FDM_MAX_SIZE (8) #define NFI_FDM_MIN_SIZE (1) +#define NFI_DEBUG_CON1 (0x220) +#define STROBE_MASK GENMASK(4, 3) +#define STROBE_SHIFT (3) +#define MAX_STROBE_DLY (3) #define NFI_MASTER_STA (0x224) #define MASTER_STA_MASK (0x0FFF) #define NFI_EMPTY_THRESH (0x23C) @@ -509,6 +513,7 @@ static int mtk_nfc_setup_data_interface(struct nand_chip *chip, int csline, struct mtk_nfc *nfc = nand_get_controller_data(chip); const struct nand_sdr_timings *timings; u32 rate, tpoecs, tprecs, tc2r, tw2r, twh, twst = 0, trlt = 0; + u32 tsel, reg; timings = nand_get_sdr_timings(conf); if (IS_ERR(timings)) @@ -556,10 +561,25 @@ static int mtk_nfc_setup_data_interface(struct nand_chip *chip, int csline, if ((twh + 1) * 1000000 / rate < timings->tRC_min / 1000) trlt = (timings->tRC_min / 1000 - (twh + 1) * 1000000 / rate) * 1000; - trlt = max3(trlt, timings->tREA_max, timings->tRP_min) / 1000; + trlt = max(trlt, timings->tRP_min) / 1000; trlt = DIV_ROUND_UP(trlt * rate, 1000000) - 1; trlt &= 0xf; + /* Calculate strobe sel */ + reg = nfi_readl(nfc, NFI_DEBUG_CON1); + reg &= ~STROBE_MASK; + if ((trlt + 1) * 1000000 / rate < timings->tREA_max / 1000) { + tsel = timings->tREA_max / 1000; + tsel = DIV_ROUND_UP(tsel * rate, 1000000); + tsel -= (trlt + 1); + if (tsel > MAX_STROBE_DLY) { + trlt += tsel - MAX_STROBE_DLY; + tsel = MAX_STROBE_DLY; + } + reg |= tsel << STROBE_SHIFT; + } + nfi_writel(nfc, reg, NFI_DEBUG_CON1); + /* * ACCON: access timing control register * ------------------------------------- -- 2.18.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-29 6:39 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-29 6:38 [PATCH 0/5] MTK NAND driver improvements and fixes Xiaolei Li 2019-04-29 6:38 ` Xiaolei Li 2019-04-29 6:38 ` [PATCH 1/5] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle Xiaolei Li 2019-04-29 6:38 ` Xiaolei Li 2019-04-29 9:03 ` Miquel Raynal 2019-04-29 9:03 ` Miquel Raynal 2019-04-29 9:35 ` xiaolei li 2019-04-29 9:35 ` xiaolei li 2019-04-29 10:02 ` Miquel Raynal 2019-04-29 10:02 ` Miquel Raynal 2019-04-30 0:59 ` xiaolei li 2019-04-30 0:59 ` xiaolei li 2019-04-29 6:38 ` Xiaolei Li [this message] 2019-04-29 6:38 ` [PATCH 2/5] mtd: rawnand: mtk: Improve data sampling timing for read cycle Xiaolei Li 2019-04-29 9:10 ` Miquel Raynal 2019-04-29 9:10 ` Miquel Raynal 2019-04-29 9:49 ` xiaolei li 2019-04-29 6:38 ` [PATCH 3/5] mtd: rawnand: mtk: Add validity check for CE# pin setting Xiaolei Li 2019-04-29 6:38 ` Xiaolei Li 2019-04-29 9:11 ` Miquel Raynal 2019-04-29 9:11 ` Miquel Raynal 2019-04-29 6:38 ` [PATCH 4/5] mtd: rawnand: mtk: Fix wrongly assigned oob buffer pointer issue Xiaolei Li 2019-04-29 6:38 ` Xiaolei Li 2019-04-29 9:14 ` Miquel Raynal 2019-04-29 9:14 ` Miquel Raynal 2019-04-29 9:52 ` xiaolei li 2019-04-29 9:52 ` xiaolei li 2019-04-29 6:38 ` [PATCH 5/5] mtd: rawnand: mtk: Setup empty page threshold correctly Xiaolei Li 2019-04-29 6:38 ` Xiaolei Li 2019-04-29 9:22 ` Miquel Raynal 2019-04-29 9:22 ` Miquel Raynal 2019-04-29 9:57 ` xiaolei li 2019-04-29 9:57 ` xiaolei li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190429063834.45967-3-xiaolei.li@mediatek.com \ --to=xiaolei.li@mediatek.com \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=srv_heupstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.