From: Ian Jackson <ian.jackson@eu.citrix.com> To: xen-devel@lists.xenproject.org Cc: Ian Jackson <ian.jackson@eu.citrix.com> Subject: [OSSTEST PATCH v2 02/15] TestSupport: target_var: Use host_V for host variables Date: Wed, 1 May 2019 11:48:26 +0100 [thread overview] Message-ID: <20190501104839.21621-3-ian.jackson@eu.citrix.com> (raw) In-Reply-To: <20190501104839.21621-1-ian.jackson@eu.citrix.com> Change `target_var' to set `IDENT_V' rather than just V. For compatibility with older flights and older flight construction, look for plain V too when looking up the variable. And, we now look at all_host_V before V. This has no functional change with existing flights, because existing flights only have all_host_suite all_host_di_version all_host_os and we never set the corresponding V form of those variables. So with existing flights the only functional change is a change to synth runvars, to add HOST_ to the name. Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> --- Osstest/TestSupport.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index f357434f..bb503559 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2479,8 +2479,7 @@ sub guest_await ($$) { sub target_var_prefix ($) { my ($ho) = @_; - if (exists $ho->{Guest}) { return $ho->{Guest}.'_'; } - return ''; + return (exists $ho->{Guest} ? $ho->{Guest} : $ho->{Ident}).'_'; } sub target_var ($$) { @@ -2491,6 +2490,7 @@ sub target_var ($$) { push @prefixes, 'all_guest_'; } else { push @prefixes, 'all_host_'; + push @prefixes, ''; } foreach my $prefix (@prefixes) { my $v = $r{ $prefix.$vn }; -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ian Jackson <ian.jackson@eu.citrix.com> To: <xen-devel@lists.xenproject.org> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Subject: [Xen-devel] [OSSTEST PATCH v2 02/15] TestSupport: target_var: Use host_V for host variables Date: Wed, 1 May 2019 11:48:26 +0100 [thread overview] Message-ID: <20190501104839.21621-3-ian.jackson@eu.citrix.com> (raw) Message-ID: <20190501104826.abIU8F0PIdFDFBMfuG2SI_nymf9BoQdt3N78YmYkXB4@z> (raw) In-Reply-To: <20190501104839.21621-1-ian.jackson@eu.citrix.com> Change `target_var' to set `IDENT_V' rather than just V. For compatibility with older flights and older flight construction, look for plain V too when looking up the variable. And, we now look at all_host_V before V. This has no functional change with existing flights, because existing flights only have all_host_suite all_host_di_version all_host_os and we never set the corresponding V form of those variables. So with existing flights the only functional change is a change to synth runvars, to add HOST_ to the name. Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> --- Osstest/TestSupport.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index f357434f..bb503559 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2479,8 +2479,7 @@ sub guest_await ($$) { sub target_var_prefix ($) { my ($ho) = @_; - if (exists $ho->{Guest}) { return $ho->{Guest}.'_'; } - return ''; + return (exists $ho->{Guest} ? $ho->{Guest} : $ho->{Ident}).'_'; } sub target_var ($$) { @@ -2491,6 +2490,7 @@ sub target_var ($$) { push @prefixes, 'all_guest_'; } else { push @prefixes, 'all_host_'; + push @prefixes, ''; } foreach my $prefix (@prefixes) { my $v = $r{ $prefix.$vn }; -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-01 10:48 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-01 10:48 [OSSTEST PATCH v2 00/15] Do armhf kernel builds on amd64 Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 01/15] TestSupport: target_var: Refactor to allow for another host case Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` Ian Jackson [this message] 2019-05-01 10:48 ` [Xen-devel] [OSSTEST PATCH v2 02/15] TestSupport: target_var: Use host_V for host variables Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 03/15] arch replumbing: ts-host-install: Move $kern_arch_info setting Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 04/15] arch replumbing: Provide $ho->{Arch} and $gho->{Arch} Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 05/15] arch replumbing: ts-debian-di-install: Remove unidiomatic { } Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 06/15] arch replumbing: ts-memdisk-try-append: Remove unidiomatic " " Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 07/15] arch replumbing: Replace many $r{arch} with $[g]ho->{Arch} Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 08/15] arch replumbing: make-flight: Fix $r{arch} comment Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 09/15] arch replumbing: ts-debian-di-install: Use $gho->{Arch} Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 10/15] ts-kernel-build: Introduce cmd() Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 11/15] cross builds: ts-kernel-build: Support cross target armhf Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 12/15] cross builds: mfi-common: Break out set_build_hostflags Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 13/15] cross builds: mfi-common: Prepare for kernel cross building Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 14/15] cross builds: Build armhf kernels on amd64 hosts Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson 2019-05-01 10:48 ` [OSSTEST PATCH v2 15/15] ts-kernel-build: Move main program to bottom of script Ian Jackson 2019-05-01 10:48 ` [Xen-devel] " Ian Jackson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190501104839.21621-3-ian.jackson@eu.citrix.com \ --to=ian.jackson@eu.citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.