From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org Cc: Sean Paul <seanpaul@chromium.org>, Zain Wang <wzz@rock-chips.com>, Tomasz Figa <tfiga@chromium.org>, Andrzej Hajda <a.hajda@samsung.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org Subject: [PATCH v3 07/10] drm/rockchip: Check for fast link training before enabling psr Date: Thu, 2 May 2019 15:49:49 -0400 [thread overview] Message-ID: <20190502194956.218441-8-sean@poorly.run> (raw) In-Reply-To: <20190502194956.218441-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> Once we start shutting off the link during PSR, we're going to want fast training to work. If the display doesn't support fast training, don't enable psr. Changes in v2: - None Changes in v3: - None Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-3-sean@poorly.run Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190326204509.96515-2-sean@poorly.run Cc: Zain Wang <wzz@rock-chips.com> Cc: Tomasz Figa <tfiga@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 225f5e5dd69b..af34554a5a02 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1040,16 +1040,17 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) if (ret) return ret; + /* Check whether panel supports fast training */ + ret = analogix_dp_fast_link_train_detection(dp); + if (ret) + dp->psr_enable = false; + if (dp->psr_enable) { ret = analogix_dp_enable_sink_psr(dp); if (ret) return ret; } - /* Check whether panel supports fast training */ - ret = analogix_dp_fast_link_train_detection(dp); - if (ret) - dp->psr_enable = false; return ret; } -- Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org Cc: Zain Wang <wzz@rock-chips.com>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>, Sean Paul <seanpaul@chromium.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Subject: [PATCH v3 07/10] drm/rockchip: Check for fast link training before enabling psr Date: Thu, 2 May 2019 15:49:49 -0400 [thread overview] Message-ID: <20190502194956.218441-8-sean@poorly.run> (raw) In-Reply-To: <20190502194956.218441-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> Once we start shutting off the link during PSR, we're going to want fast training to work. If the display doesn't support fast training, don't enable psr. Changes in v2: - None Changes in v3: - None Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-3-sean@poorly.run Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190326204509.96515-2-sean@poorly.run Cc: Zain Wang <wzz@rock-chips.com> Cc: Tomasz Figa <tfiga@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 225f5e5dd69b..af34554a5a02 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1040,16 +1040,17 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) if (ret) return ret; + /* Check whether panel supports fast training */ + ret = analogix_dp_fast_link_train_detection(dp); + if (ret) + dp->psr_enable = false; + if (dp->psr_enable) { ret = analogix_dp_enable_sink_psr(dp); if (ret) return ret; } - /* Check whether panel supports fast training */ - ret = analogix_dp_fast_link_train_detection(dp); - if (ret) - dp->psr_enable = false; return ret; } -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-02 19:50 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-02 19:49 [PATCH v3 00/10] drm: Add self refresh helpers Sean Paul 2019-05-02 19:49 ` [PATCH v3 01/10] drm: Add atomic variants of enable/disable to encoder helper funcs Sean Paul 2019-05-03 7:51 ` Daniel Vetter 2019-05-03 12:34 ` Sean Paul 2019-05-03 14:08 ` Daniel Vetter 2019-05-03 14:08 ` Daniel Vetter 2019-05-02 19:49 ` [PATCH v3 02/10] drm: Add drm_atomic_crtc_state_for_encoder helper Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-03 8:18 ` Daniel Vetter 2019-05-03 12:47 ` Sean Paul 2019-05-03 14:06 ` Daniel Vetter 2019-05-05 21:15 ` Daniel Vetter 2019-05-05 22:01 ` Laurent Pinchart 2019-05-05 22:01 ` Laurent Pinchart 2019-05-02 19:49 ` [PATCH v3 03/10] drm: Add atomic variants for bridge enable/disable Sean Paul 2019-05-03 7:45 ` Daniel Vetter 2019-05-02 19:49 ` [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-03 8:19 ` Daniel Vetter 2019-05-11 19:12 ` Laurent Pinchart 2019-05-11 19:12 ` Laurent Pinchart 2019-05-13 14:38 ` Sean Paul 2019-05-13 14:38 ` Sean Paul 2019-05-16 12:00 ` Laurent Pinchart 2019-05-16 12:00 ` Laurent Pinchart 2019-05-16 14:21 ` Sean Paul 2019-05-16 14:21 ` Sean Paul 2019-05-13 14:47 ` Daniel Vetter 2019-05-13 14:47 ` Daniel Vetter 2019-05-16 12:02 ` Laurent Pinchart 2019-05-16 12:02 ` Laurent Pinchart 2019-05-16 12:07 ` Daniel Vetter 2019-05-16 12:07 ` Daniel Vetter 2019-05-16 13:28 ` Ville Syrjälä 2019-05-16 13:28 ` Ville Syrjälä 2019-05-02 19:49 ` [PATCH v3 05/10] drm: Add helpers to kick off self refresh mode in drivers Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-03 7:36 ` Daniel Vetter 2019-05-02 19:49 ` [PATCH v3 06/10] drm/rockchip: Use dirtyfb helper Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` Sean Paul [this message] 2019-05-02 19:49 ` [PATCH v3 07/10] drm/rockchip: Check for fast link training before enabling psr Sean Paul 2019-05-02 19:49 ` [PATCH v3 08/10] drm/rockchip: Use the helpers for PSR Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` [PATCH v3 09/10] drm/rockchip: Don't fully disable vop on self refresh Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` [PATCH v3 10/10] drm/rockchip: Use drm_atomic_helper_commit_tail_rpm Sean Paul 2019-05-02 19:49 ` Sean Paul 2019-05-02 19:49 ` Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190502194956.218441-8-sean@poorly.run \ --to=sean@poorly.run \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=seanpaul@chromium.org \ --cc=tfiga@chromium.org \ --cc=wzz@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.