All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jyri Sarha <jsarha@ti.com>, Benoit Parrot <bparrot@ti.com>,
	dri-devel@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCHv3 11/23] drm/bridge: tc358767: disable only video stream in tc_stream_disable
Date: Fri, 3 May 2019 15:29:37 +0300	[thread overview]
Message-ID: <20190503122949.12266-12-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <20190503122949.12266-1-tomi.valkeinen@ti.com>

Currently the code writes 0 to DP0CTL in tc_stream_disable(), which
disables the whole DP link instead of just the video stream. We always
disable the link and the stream together from tc_bridge_disable(), so
this doesn't cause any issues.

Nevertheless, fix this by only clearing VID_EN in tc_stream_disable to
stop the video stream while keeping the link enabled.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/bridge/tc358767.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index b22f5fe7ccfd..86e2e16c5a90 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1076,10 +1076,13 @@ static int tc_stream_enable(struct tc_data *tc)
 static int tc_stream_disable(struct tc_data *tc)
 {
 	int ret;
+	u32 val;
 
 	dev_dbg(tc->dev, "disable video stream\n");
 
-	tc_write(DP0CTL, 0);
+	tc_read(DP0CTL, &val);
+	val &= ~VID_EN;
+	tc_write(DP0CTL, val);
 
 	tc_pxl_pll_dis(tc);
 
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-05-03 12:31 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 12:29 [PATCHv3 00/23] drm/bridge: tc358767: DP support Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 01/23] drm/bridge: tc358767: fix tc_aux_get_status error handling Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 02/23] drm/bridge: tc358767: reset voltage-swing & pre-emphasis Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 03/23] drm/bridge: tc358767: fix ansi 8b10b use Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 04/23] drm/bridge: tc358767: cleanup spread & scrambler_dis Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 05/23] drm/bridge: tc358767: remove unused swing & preemp Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 06/23] drm/bridge: tc358767: cleanup aux_link_setup Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 07/23] drm/bridge: tc358767: move video stream setup to tc_main_link_stream Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 08/23] drm/bridge: tc358767: split stream enable/disable Tomi Valkeinen
2019-05-20  9:35   ` Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 09/23] drm/bridge: tc358767: move PXL PLL enable/disable to " Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 10/23] drm/bridge: tc358767: add link disable function Tomi Valkeinen
2019-05-20  9:36   ` Andrzej Hajda
2019-05-03 12:29 ` Tomi Valkeinen [this message]
2019-05-20 10:53   ` [PATCHv3 11/23] drm/bridge: tc358767: disable only video stream in tc_stream_disable Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 12/23] drm/bridge: tc358767: ensure DP is disabled before LT Tomi Valkeinen
2019-05-20 10:54   ` Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 13/23] drm/bridge: tc358767: remove unnecessary msleep Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 14/23] drm/bridge: tc358767: use more reliable seq when finishing LT Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 15/23] drm/bridge: tc358767: cleanup LT result check Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 16/23] drm/bridge: tc358767: clean-up link training Tomi Valkeinen
2019-05-20 11:29   ` Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 17/23] drm/bridge: tc358767: remove check for video mode in link enable Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 18/23] drm/bridge: tc358767: use bridge mode_valid Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 19/23] drm/bridge: tc358767: remove tc_connector_best_encoder Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 20/23] drm/bridge: tc358767: copy the mode data, instead of storing the pointer Tomi Valkeinen
2019-05-21  6:14   ` Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 21/23] drm/bridge: tc358767: add GPIO & interrupt registers Tomi Valkeinen
2019-05-03 12:29 ` [PATCHv3 22/23] drm/bridge: tc358767: add IRQ and HPD support Tomi Valkeinen
2019-05-21  7:07   ` Andrzej Hajda
2019-05-21 11:34     ` Tomi Valkeinen
2019-05-21 14:18       ` Andrzej Hajda
2019-05-27 15:11         ` Tomi Valkeinen
2019-05-28 10:59           ` Andrzej Hajda
2019-05-03 12:29 ` [PATCHv3 23/23] dt-bindings: tc358767: add " Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503122949.12266-12-tomi.valkeinen@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=bparrot@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=l.stach@pengutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.