From: Dan Carpenter <dan.carpenter@oracle.com> To: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna.schumaker@netapp.com>, "J. Bruce Fields" <bfields@fieldses.org>, Jeff Layton <jlayton@kernel.org>, Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neilb@suse.com>, linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] SUNRPC: Fix an error code in gss_alloc_msg() Date: Fri, 03 May 2019 12:30:09 +0000 [thread overview] Message-ID: <20190503123009.GC29695@mwanda> (raw) If kstrdup_const() then this function returns zero (success) but it should return -ENOMEM. Fixes: ac83228a7101 ("SUNRPC: Use namespace of listening daemon in the client AUTH_GSS upcall") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/sunrpc/auth_gss/auth_gss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index b2cbc83d39c7..06fe17c2aea1 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -553,8 +553,10 @@ gss_alloc_msg(struct gss_auth *gss_auth, gss_msg->auth = gss_auth; if (service_name) { gss_msg->service_name = kstrdup_const(service_name, GFP_NOFS); - if (!gss_msg->service_name) + if (!gss_msg->service_name) { + err = -ENOMEM; goto err_put_pipe_version; + } } return gss_msg; err_put_pipe_version: -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna.schumaker@netapp.com>, "J. Bruce Fields" <bfields@fieldses.org>, Jeff Layton <jlayton@kernel.org>, Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neilb@suse.com>, linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] SUNRPC: Fix an error code in gss_alloc_msg() Date: Fri, 3 May 2019 15:30:09 +0300 [thread overview] Message-ID: <20190503123009.GC29695@mwanda> (raw) If kstrdup_const() then this function returns zero (success) but it should return -ENOMEM. Fixes: ac83228a7101 ("SUNRPC: Use namespace of listening daemon in the client AUTH_GSS upcall") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/sunrpc/auth_gss/auth_gss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index b2cbc83d39c7..06fe17c2aea1 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -553,8 +553,10 @@ gss_alloc_msg(struct gss_auth *gss_auth, gss_msg->auth = gss_auth; if (service_name) { gss_msg->service_name = kstrdup_const(service_name, GFP_NOFS); - if (!gss_msg->service_name) + if (!gss_msg->service_name) { + err = -ENOMEM; goto err_put_pipe_version; + } } return gss_msg; err_put_pipe_version: -- 2.18.0
next reply other threads:[~2019-05-03 12:30 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-03 12:30 Dan Carpenter [this message] 2019-05-03 12:30 ` [PATCH] SUNRPC: Fix an error code in gss_alloc_msg() Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190503123009.GC29695@mwanda \ --to=dan.carpenter@oracle.com \ --cc=anna.schumaker@netapp.com \ --cc=bfields@fieldses.org \ --cc=chuck.lever@oracle.com \ --cc=jlayton@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=neilb@suse.com \ --cc=trond.myklebust@hammerspace.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.