From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org, Stephen Checkoway <stephen.checkoway@oberlin.edu> Cc: "Markus Armbruster" <armbru@redhat.com>, "Max Reitz" <mreitz@redhat.com>, "Thomas Huth" <thuth@redhat.com>, "Laurent Vivier" <lvivier@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>, "Kevin Wolf" <kwolf@redhat.com>, "Peter Maydell" <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [Qemu-devel] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes Date: Mon, 6 May 2019 00:15:31 +0200 [thread overview] Message-ID: <20190505221544.31568-1-philmd@redhat.com> (raw) Hi, While reviewing Stephen Checkoway's v4 "Implement missing AMD pflash functionality" [*] I found it hard (for me) to digest, so I took step by step notes. This series is the result of those notes. Regarding Stephen's series, this series only contains the generic code movement and trivial cleanup. The other patches are rather dense and I need more time to study the specs. Stephen: If you take out the patch #2 ("Use the GLib API"), you can rebase your series on top of this. I'd appreciate if you can adapt your tests to use the GLib functions, else I plan to do it later. Regards, Phil. [*] https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04595.html Philippe Mathieu-Daudé (10): tests/pflash-cfi02: Use the GLib API tests/pflash-cfi02: Use IEC binary prefixes for size constants hw/block/pflash_cfi02: Fix debug format string hw/block/pflash_cfi02: Add an enum to define the write cycles hw/block/pflash_cfi02: Add helpers to manipulate the status bits hw/block/pflash_cfi02: Simplify a statement using fall through hw/block/pflash_cfi02: Use the ldst API in pflash_write() hw/block/pflash_cfi02: Use the ldst API in pflash_read() hw/block/pflash_cfi02: Extract the pflash_data_read() function hw/block/pflash_cfi02: Unify the MemoryRegionOps Stephen Checkoway (3): tests/pflash-cfi02: Add test for supported CFI commands hw/block/pflash_cfi02: Fix command address comparison hw/block/pflash_cfi02: Use the chip erase time specified in the CFI table hw/block/pflash_cfi02.c | 234 +++++++++++++++++--------------------- tests/Makefile.include | 2 + tests/pflash-cfi02-test.c | 232 +++++++++++++++++++++++++++++++++++++ 3 files changed, 339 insertions(+), 129 deletions(-) create mode 100644 tests/pflash-cfi02-test.c -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org, Stephen Checkoway <stephen.checkoway@oberlin.edu> Cc: "Laurent Vivier" <lvivier@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>, qemu-block@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Markus Armbruster" <armbru@redhat.com>, "Max Reitz" <mreitz@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org> Subject: [Qemu-devel] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes Date: Mon, 6 May 2019 00:15:31 +0200 [thread overview] Message-ID: <20190505221544.31568-1-philmd@redhat.com> (raw) Message-ID: <20190505221531.VR5NsmQZunj_wBIujHIHvBD_2NdpiUXdM4IlbuBpQzw@z> (raw) Hi, While reviewing Stephen Checkoway's v4 "Implement missing AMD pflash functionality" [*] I found it hard (for me) to digest, so I took step by step notes. This series is the result of those notes. Regarding Stephen's series, this series only contains the generic code movement and trivial cleanup. The other patches are rather dense and I need more time to study the specs. Stephen: If you take out the patch #2 ("Use the GLib API"), you can rebase your series on top of this. I'd appreciate if you can adapt your tests to use the GLib functions, else I plan to do it later. Regards, Phil. [*] https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04595.html Philippe Mathieu-Daudé (10): tests/pflash-cfi02: Use the GLib API tests/pflash-cfi02: Use IEC binary prefixes for size constants hw/block/pflash_cfi02: Fix debug format string hw/block/pflash_cfi02: Add an enum to define the write cycles hw/block/pflash_cfi02: Add helpers to manipulate the status bits hw/block/pflash_cfi02: Simplify a statement using fall through hw/block/pflash_cfi02: Use the ldst API in pflash_write() hw/block/pflash_cfi02: Use the ldst API in pflash_read() hw/block/pflash_cfi02: Extract the pflash_data_read() function hw/block/pflash_cfi02: Unify the MemoryRegionOps Stephen Checkoway (3): tests/pflash-cfi02: Add test for supported CFI commands hw/block/pflash_cfi02: Fix command address comparison hw/block/pflash_cfi02: Use the chip erase time specified in the CFI table hw/block/pflash_cfi02.c | 234 +++++++++++++++++--------------------- tests/Makefile.include | 2 + tests/pflash-cfi02-test.c | 232 +++++++++++++++++++++++++++++++++++++ 3 files changed, 339 insertions(+), 129 deletions(-) create mode 100644 tests/pflash-cfi02-test.c -- 2.20.1
next reply other threads:[~2019-05-05 22:16 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-05 22:15 Philippe Mathieu-Daudé [this message] 2019-05-05 22:15 ` [Qemu-devel] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 01/13] tests/pflash-cfi02: Add test for supported CFI commands Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 02/13] tests/pflash-cfi02: Use the GLib API Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 03/13] tests/pflash-cfi02: Use IEC binary prefixes for size constants Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 04/13] hw/block/pflash_cfi02: Fix debug format string Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 05/13] hw/block/pflash_cfi02: Add an enum to define the write cycles Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 06/13] hw/block/pflash_cfi02: Add helpers to manipulate the status bits Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 07/13] hw/block/pflash_cfi02: Simplify a statement using fall through Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 08/13] hw/block/pflash_cfi02: Use the ldst API in pflash_write() Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 09/13] hw/block/pflash_cfi02: Use the ldst API in pflash_read() Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 10/13] hw/block/pflash_cfi02: Extract the pflash_data_read() function Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 11/13] hw/block/pflash_cfi02: Unify the MemoryRegionOps Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 12/13] hw/block/pflash_cfi02: Fix command address comparison Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-05-05 22:15 ` [Qemu-devel] [PATCH 13/13] hw/block/pflash_cfi02: Use the chip erase time specified in the CFI table Philippe Mathieu-Daudé 2019-05-05 22:15 ` Philippe Mathieu-Daudé 2019-06-26 20:33 ` [Qemu-devel] [Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes John Snow 2019-06-26 21:06 ` Philippe Mathieu-Daudé 2019-06-26 21:09 ` John Snow
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190505221544.31568-1-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=alex.bennee@linaro.org \ --cc=armbru@redhat.com \ --cc=kwolf@redhat.com \ --cc=lvivier@redhat.com \ --cc=mreitz@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=stephen.checkoway@oberlin.edu \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.