All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Liang <xiliang@redhat.com>
To: linux-block@vger.kernel.org, osandov@fb.com
Cc: xiliang@redhat.com
Subject: [PATCH blktests] block/005,008: do exit if fio did not finish within timeout
Date: Tue,  7 May 2019 13:47:21 +0800	[thread overview]
Message-ID: <20190507054721.6056-1-xiliang@redhat.com> (raw)

In some bad situation, fio needs taking over several hours to complete
random read operations with specipied size. The test may skip out in such
cases and does not block other cases run.

With this patch, the case will be ended within $TIMEOUT(if set) or 900s.
block/005 => nvme1n1 (switch schedulers while doing IO)      [failed]
    runtime      ...  1800.477s
    read iops    ...
    --- tests/block/005.out	2019-03-31 14:29:39.905449312 +0000
    +++ /home/ec2-user/blktests/results/nvme1n1/block/005.out.bad	2019-05-07 04:10:16.026681842 +0000
    @@ -1,2 +1,4 @@
     Running block/005
    +fio did not finish after 900 seconds which probably caused by
    +lower disk performance
     Test complete

Signed-off-by: Xiao Liang <xiliang@redhat.com>
---
 tests/block/005 | 10 ++++++++++
 tests/block/008 | 10 ++++++++++
 2 files changed, 20 insertions(+)

diff --git a/tests/block/005 b/tests/block/005
index 8ab6791..96b16a4 100755
--- a/tests/block/005
+++ b/tests/block/005
@@ -31,10 +31,20 @@ test_device() {
 	_run_fio_rand_io --filename="$TEST_DEV" --size="$size" &
 
 	# while job is running, switch between schedulers
+	# fio test may take too long time to complete read/write in special size on some bad 
+	# performance disks. Set a timeout here which does not block overall test.
+	start_time=$(date +%s)
+	timeout=${TIMEOUT:=900}
 	while kill -0 $! 2>/dev/null; do
 		idx=$((RANDOM % ${#scheds[@]}))
 		_test_dev_queue_set scheduler "${scheds[$idx]}"
 		sleep .2
+		end_time=$(date +%s)
+		if (( end_time - start_time > timeout )); then
+			echo "fio did not finish after $timeout seconds which probably caused by 
+lower disk performance"
+			break
+		fi
 	done
 
 	FIO_PERF_FIELDS=("read iops")
diff --git a/tests/block/008 b/tests/block/008
index 4a88056..c25b908 100755
--- a/tests/block/008
+++ b/tests/block/008
@@ -45,6 +45,10 @@ test_device() {
 	done
 
 	# while job is running, hotplug CPUs
+	# fio test may take too long time to complete read/write in special size on some bad 
+	# performance disks. Set a timeout here which does not block overall test.
+	start_time=$(date +%s)
+	timeout=${TIMEOUT:=900}
 	while sleep .2; kill -0 $! 2> /dev/null; do
 		if (( offlining && ${#offline_cpus[@]} == max_offline )); then
 			offlining=0
@@ -65,6 +69,12 @@ test_device() {
 			unset offline_cpus["$idx"]
 			offline_cpus=("${offline_cpus[@]}")
 		fi
+		end_time=$(date +%s)
+		if (( end_time - start_time > timeout )); then
+			echo "fio did not finish after $timeout seconds which probably caused by 
+lower disk performance"
+			break
+		fi
 	done
 
 	FIO_PERF_FIELDS=("read iops")
-- 
2.17.2


             reply	other threads:[~2019-05-07  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  5:47 Xiao Liang [this message]
2019-05-10 18:20 ` [PATCH blktests] block/005,008: do exit if fio did not finish within timeout Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507054721.6056-1-xiliang@redhat.com \
    --to=xiliang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.