From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: linux-kernel@vger.kernel.org Cc: dan.carpenter@oracle.com, stefan.wahren@i2se.com, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Eric Anholt <eric@anholt.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org Subject: [PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" Date: Thu, 9 May 2019 16:31:33 +0200 [thread overview] Message-ID: <20190509143137.31254-2-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20190509143137.31254-1-nsaenzjulienne@suse.de> The killable version of down() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Fixes: ff5979ad8636 ("staging: vchiq_2835_arm: quit using custom down_interruptible()") Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c index a9a22917ecdb..49d3b39b1059 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c @@ -514,7 +514,7 @@ create_pagelist(char __user *buf, size_t count, unsigned short type) (g_cache_line_size - 1)))) { char *fragments; - if (down_killable(&g_free_fragments_sema)) { + if (down_interruptible(&g_free_fragments_sema) != 0) { cleanup_pagelistinfo(pagelistinfo); return NULL; } -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: linux-kernel@vger.kernel.org Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Eric Anholt <eric@anholt.net>, linux-rpi-kernel@lists.infradead.org, dan.carpenter@oracle.com, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" Date: Thu, 9 May 2019 16:31:33 +0200 [thread overview] Message-ID: <20190509143137.31254-2-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20190509143137.31254-1-nsaenzjulienne@suse.de> The killable version of down() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Fixes: ff5979ad8636 ("staging: vchiq_2835_arm: quit using custom down_interruptible()") Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c index a9a22917ecdb..49d3b39b1059 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c @@ -514,7 +514,7 @@ create_pagelist(char __user *buf, size_t count, unsigned short type) (g_cache_line_size - 1)))) { char *fragments; - if (down_killable(&g_free_fragments_sema)) { + if (down_interruptible(&g_free_fragments_sema) != 0) { cleanup_pagelistinfo(pagelistinfo); return NULL; } -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-09 14:31 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-09 14:31 [PATCH v3 0/4] staging: vchiq: use interruptible waits Nicolas Saenz Julienne 2019-05-09 14:31 ` Nicolas Saenz Julienne 2019-05-09 14:31 ` Nicolas Saenz Julienne [this message] 2019-05-09 14:31 ` [PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" Nicolas Saenz Julienne 2019-05-15 9:52 ` Stefan Wahren 2019-05-15 9:52 ` Stefan Wahren 2019-05-09 14:31 ` [PATCH v3 2/4] staging: vchiq: revert "switch to wait_for_completion_killable" Nicolas Saenz Julienne 2019-05-09 14:31 ` Nicolas Saenz Julienne 2019-05-09 14:31 ` [PATCH v3 3/4] staging: vchiq: make wait events interruptible Nicolas Saenz Julienne 2019-05-09 14:31 ` Nicolas Saenz Julienne 2019-05-09 14:31 ` [PATCH v3 4/4] staging: vchiq: stop explicitly comparing with zero to catch errors Nicolas Saenz Julienne 2019-05-09 14:31 ` Nicolas Saenz Julienne 2019-05-09 14:41 ` Dan Carpenter 2019-05-09 14:41 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190509143137.31254-2-nsaenzjulienne@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=dan.carpenter@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=eric@anholt.net \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=stefan.wahren@i2se.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.