All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org
Cc: jack@suse.cz, mst@redhat.com, jasowang@redhat.com,
	david@fromorbit.com, lcapitulino@redhat.com,
	adilger.kernel@dilger.ca, zwisler@kernel.org,
	aarcange@redhat.com, jstaron@google.com, darrick.wong@oracle.com,
	david@redhat.com, willy@infradead.org, hch@infradead.org,
	nilal@redhat.com, lenb@kernel.org, kilobyte@angband.pl,
	riel@surriel.com, yuval.shaia@oracle.com, stefanha@redhat.com,
	pbonzini@redhat.com, kwolf@redhat.com, tytso@mit.edu,
	xiaoguangrong.eric@gmail.com, cohuck@redhat.com,
	rjw@rjwysocki.net, imammedo@redhat.com
Subject: [PATCH v8 6/6] xfs: disable map_sync for async flush
Date: Fri, 10 May 2019 21:22:02 +0530	[thread overview]
Message-ID: <20190510155202.14737-7-pagupta@redhat.com> (raw)
In-Reply-To: <20190510155202.14737-1-pagupta@redhat.com>

Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_file.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index a7ceae90110e..f17652cca5ff 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1203,11 +1203,14 @@ xfs_file_mmap(
 	struct file	*filp,
 	struct vm_area_struct *vma)
 {
+	struct dax_device 	*dax_dev;
+
+	dax_dev = xfs_find_daxdev_for_inode(file_inode(filp));
 	/*
-	 * We don't support synchronous mappings for non-DAX files. At least
-	 * until someone comes with a sensible use case.
+	 * We don't support synchronous mappings for non-DAX files and
+	 * for DAX files if underneath dax_device is not synchronous.
 	 */
-	if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC))
+	if (!daxdev_mapping_supported(vma, dax_dev))
 		return -EOPNOTSUPP;
 
 	file_accessed(filp);
-- 
2.20.1

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org
Cc: dan.j.williams@intel.com, zwisler@kernel.org,
	vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com,
	jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net,
	hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu,
	adilger.kernel@dilger.ca, darrick.wong@oracle.com,
	lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com,
	jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com,
	stefanha@redhat.com, aarcange@redhat.com, david@redhat.com,
	david@fromorbit.com, cohuck@redhat.com,
	xiaoguangrong.eric@gmail.com, pbonzini@redhat.com,
	kilobyte@angband.pl, yuval.shaia@oracle.com, jstaron@google.com,
	pagupta@redhat.com
Subject: [PATCH v8 6/6] xfs: disable map_sync for async flush
Date: Fri, 10 May 2019 21:22:02 +0530	[thread overview]
Message-ID: <20190510155202.14737-7-pagupta@redhat.com> (raw)
In-Reply-To: <20190510155202.14737-1-pagupta@redhat.com>

Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_file.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index a7ceae90110e..f17652cca5ff 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1203,11 +1203,14 @@ xfs_file_mmap(
 	struct file	*filp,
 	struct vm_area_struct *vma)
 {
+	struct dax_device 	*dax_dev;
+
+	dax_dev = xfs_find_daxdev_for_inode(file_inode(filp));
 	/*
-	 * We don't support synchronous mappings for non-DAX files. At least
-	 * until someone comes with a sensible use case.
+	 * We don't support synchronous mappings for non-DAX files and
+	 * for DAX files if underneath dax_device is not synchronous.
 	 */
-	if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC))
+	if (!daxdev_mapping_supported(vma, dax_dev))
 		return -EOPNOTSUPP;
 
 	file_accessed(filp);
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org
Cc: pagupta@redhat.com, jack@suse.cz, mst@redhat.com,
	jasowang@redhat.com, david@fromorbit.com, lcapitulino@redhat.com,
	adilger.kernel@dilger.ca, zwisler@kernel.org,
	aarcange@redhat.com, dave.jiang@intel.com, jstaron@google.com,
	darrick.wong@oracle.com, vishal.l.verma@intel.com,
	david@redhat.com, willy@infradead.org, hch@infradead.org,
	jmoyer@redhat.com, nilal@redhat.com, lenb@kernel.org,
	kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com,
	stefanha@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, kwolf@redhat.com, tytso@mit.edu,
	xiaoguangrong.eric@gmail.com, cohuck@redhat.com,
	rjw@rjwysocki.net, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v8 6/6] xfs: disable map_sync for async flush
Date: Fri, 10 May 2019 21:22:02 +0530	[thread overview]
Message-ID: <20190510155202.14737-7-pagupta@redhat.com> (raw)
In-Reply-To: <20190510155202.14737-1-pagupta@redhat.com>

Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_file.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index a7ceae90110e..f17652cca5ff 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1203,11 +1203,14 @@ xfs_file_mmap(
 	struct file	*filp,
 	struct vm_area_struct *vma)
 {
+	struct dax_device 	*dax_dev;
+
+	dax_dev = xfs_find_daxdev_for_inode(file_inode(filp));
 	/*
-	 * We don't support synchronous mappings for non-DAX files. At least
-	 * until someone comes with a sensible use case.
+	 * We don't support synchronous mappings for non-DAX files and
+	 * for DAX files if underneath dax_device is not synchronous.
 	 */
-	if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC))
+	if (!daxdev_mapping_supported(vma, dax_dev))
 		return -EOPNOTSUPP;
 
 	file_accessed(filp);
-- 
2.20.1



  parent reply	other threads:[~2019-05-10 15:55 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 15:51 [PATCH v8 0/6] virtio pmem driver Pankaj Gupta
2019-05-10 15:51 ` Pankaj Gupta
2019-05-10 15:51 ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:51 ` Pankaj Gupta
2019-05-10 15:51 ` [PATCH v8 1/6] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-05-10 15:51 ` Pankaj Gupta
2019-05-10 15:51   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:51   ` Pankaj Gupta
2019-05-10 15:51 ` [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-05-10 15:51   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:51   ` Pankaj Gupta
2019-05-12 16:51   ` Michael S. Tsirkin
2019-05-12 16:51   ` Michael S. Tsirkin
2019-05-12 16:51     ` [Qemu-devel] " Michael S. Tsirkin
2019-05-12 16:51     ` Michael S. Tsirkin
2019-05-13  4:43     ` [Qemu-devel] " Pankaj Gupta
2019-05-13  4:43       ` Pankaj Gupta
2019-05-13  4:43       ` Pankaj Gupta
2019-05-13  4:43     ` Pankaj Gupta
2019-05-14  8:19   ` David Hildenbrand
2019-05-14  8:19   ` David Hildenbrand
2019-05-14  8:19     ` [Qemu-devel] " David Hildenbrand
2019-05-14  8:19     ` David Hildenbrand
2019-05-14  9:27     ` Pankaj Gupta
2019-05-14  9:27       ` [Qemu-devel] " Pankaj Gupta
2019-05-14  9:27       ` Pankaj Gupta
2019-05-14  9:34       ` David Hildenbrand
2019-05-14  9:34       ` David Hildenbrand
2019-05-14  9:34         ` [Qemu-devel] " David Hildenbrand
2019-05-14  9:34         ` David Hildenbrand
2019-05-14  9:47         ` Pankaj Gupta
2019-05-14  9:47           ` [Qemu-devel] " Pankaj Gupta
2019-05-14  9:47           ` Pankaj Gupta
2019-05-14  9:57           ` David Hildenbrand
2019-05-14  9:57             ` [Qemu-devel] " David Hildenbrand
2019-05-14  9:57             ` David Hildenbrand
2019-05-14 10:02             ` Pankaj Gupta
2019-05-14 10:02               ` [Qemu-devel] " Pankaj Gupta
2019-05-14 10:02               ` Pankaj Gupta
2019-05-14 10:02             ` Pankaj Gupta
2019-05-14  9:57           ` David Hildenbrand
2019-05-14  9:47         ` Pankaj Gupta
2019-05-14  9:27     ` Pankaj Gupta
2019-05-10 15:51 ` Pankaj Gupta
2019-05-10 15:51 ` [PATCH v8 3/6] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-05-10 15:51 ` Pankaj Gupta
2019-05-10 15:51   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:51   ` Pankaj Gupta
2019-05-10 20:14   ` Dan Williams
2019-05-10 20:14   ` Dan Williams
2019-05-10 20:14     ` [Qemu-devel] " Dan Williams
2019-05-11  0:45     ` Pankaj Gupta
2019-05-11  0:45     ` Pankaj Gupta
2019-05-11  0:45       ` [Qemu-devel] " Pankaj Gupta
2019-05-11  0:45       ` Pankaj Gupta
2019-05-11  0:59       ` Dan Williams
2019-05-11  0:59         ` [Qemu-devel] " Dan Williams
2019-05-11  0:59         ` Dan Williams
2019-05-11  1:23         ` [Qemu-devel] " Pankaj Gupta
2019-05-11  1:23           ` Pankaj Gupta
2019-05-11  1:23           ` Pankaj Gupta
2019-05-11  1:23           ` Pankaj Gupta
2019-05-13 17:32           ` Pankaj Gupta
2019-05-13 17:32           ` Pankaj Gupta
2019-05-13 17:32             ` Pankaj Gupta
2019-05-13 17:32             ` Pankaj Gupta
2019-05-13 17:52             ` Dan Williams
2019-05-13 17:52               ` Dan Williams
2019-05-13 17:52               ` Dan Williams
2019-05-13 17:52               ` Dan Williams
2019-05-14  5:27               ` Pankaj Gupta
2019-05-14  5:27                 ` Pankaj Gupta
2019-05-14  5:27                 ` Pankaj Gupta
2019-05-14  5:27                 ` Pankaj Gupta
2019-05-11  0:59       ` Dan Williams
2019-05-10 15:52 ` [PATCH v8 4/6] dax: check synchronous mapping is supported Pankaj Gupta
2019-05-10 15:52 ` Pankaj Gupta
2019-05-10 15:52   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:52   ` Pankaj Gupta
2019-05-10 15:52 ` [PATCH v8 5/6] ext4: disable map_sync for async flush Pankaj Gupta
2019-05-10 15:52 ` Pankaj Gupta
2019-05-10 15:52   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:52   ` Pankaj Gupta
2019-05-10 15:52 ` [PATCH v8 6/6] xfs: " Pankaj Gupta
2019-05-10 15:52 ` Pankaj Gupta [this message]
2019-05-10 15:52   ` [Qemu-devel] " Pankaj Gupta
2019-05-10 15:52   ` Pankaj Gupta
2019-05-10 16:30 ` [PATCH v8 0/6] virtio pmem driver Michael S. Tsirkin
2019-05-10 16:30 ` Michael S. Tsirkin
2019-05-10 16:30   ` [Qemu-devel] " Michael S. Tsirkin
2019-05-10 16:30   ` Michael S. Tsirkin
2019-05-10 20:15 ` Dan Williams
2019-05-10 20:15   ` [Qemu-devel] " Dan Williams
2019-05-10 20:15   ` Dan Williams
2019-05-10 23:33   ` Pankaj Gupta
2019-05-10 23:33     ` Pankaj Gupta
2019-05-10 23:33     ` [Qemu-devel] " Pankaj Gupta
2019-05-10 23:33     ` Pankaj Gupta
2019-05-12 16:52     ` Michael S. Tsirkin
2019-05-12 16:52       ` Michael S. Tsirkin
2019-05-12 16:52       ` [Qemu-devel] " Michael S. Tsirkin
2019-05-12 16:52       ` Michael S. Tsirkin
2019-05-10 20:15 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510155202.14737-7-pagupta@redhat.com \
    --to=pagupta@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=cohuck@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=david@redhat.com \
    --cc=hch@infradead.org \
    --cc=imammedo@redhat.com \
    --cc=jack@suse.cz \
    --cc=jasowang@redhat.com \
    --cc=jstaron@google.com \
    --cc=kilobyte@angband.pl \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riel@surriel.com \
    --cc=rjw@rjwysocki.net \
    --cc=stefanha@redhat.com \
    --cc=tytso@mit.edu \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=yuval.shaia@oracle.com \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.