All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Mark Brown <broonie@kernel.org>,
	Benson Leung <bleung@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-rockchip@lists.infradead.org, drinkcat@chromium.org,
	Guenter Roeck <groeck@chromium.org>,
	briannorris@chromium.org, mka@chromium.org,
	Douglas Anderson <dianders@chromium.org>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread
Date: Fri, 10 May 2019 15:34:34 -0700	[thread overview]
Message-ID: <20190510223437.84368-2-dianders@chromium.org> (raw)
In-Reply-To: <20190510223437.84368-1-dianders@chromium.org>

If a controller specifies that it needs high priority for sending
messages we should always schedule our transfers on the thread.  If we
don't do this we'll do the transfer in the caller's context which
might not be very high priority.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/spi/spi.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 8eb7460dd744..0597f7086de3 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1230,8 +1230,11 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread)
 		return;
 	}
 
-	/* If another context is idling the device then defer */
-	if (ctlr->idling) {
+	/*
+	 * If another context is idling the device then defer.
+	 * If we are high priority then the thread should do the transfer.
+	 */
+	if (ctlr->idling || (ctlr->rt && !in_kthread)) {
 		kthread_queue_work(&ctlr->kworker, &ctlr->pump_messages);
 		spin_unlock_irqrestore(&ctlr->queue_lock, flags);
 		return;
-- 
2.21.0.1020.gf2820cf01a-goog


  reply	other threads:[~2019-05-10 22:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 22:34 [PATCH 0/4] spi: A better solution for cros_ec_spi reliability Douglas Anderson
2019-05-10 22:34 ` Douglas Anderson [this message]
2019-05-11  0:24   ` [PATCH 1/4] spi: For controllers that need realtime always use the pump thread Guenter Roeck
2019-05-12  7:33   ` Mark Brown
2019-05-12  7:33     ` Mark Brown
2019-05-13 20:24     ` Doug Anderson
2019-05-14  9:30       ` Mark Brown
2019-05-14 14:42         ` Doug Anderson
2019-05-14 15:06           ` Mark Brown
2019-05-10 22:34 ` [PATCH 2/4] spi: Allow SPI devices to specify that they are timing sensitive Douglas Anderson
2019-05-11  0:31   ` Guenter Roeck
2019-05-11  0:31     ` Guenter Roeck
2019-05-12  7:42   ` Mark Brown
2019-05-12  7:42     ` Mark Brown
2019-05-10 22:34 ` [PATCH 3/4] platform/chrome: cros_ec_spi: Set ourselves as " Douglas Anderson
2019-05-11  0:32   ` Guenter Roeck
2019-05-10 22:34 ` [PATCH 4/4] Revert "platform/chrome: cros_ec_spi: Transfer messages at high priority" Douglas Anderson
2019-05-10 22:34   ` Douglas Anderson
2019-05-11  0:32   ` Guenter Roeck
2019-05-12  7:45   ` Mark Brown
2019-05-12  7:45     ` Mark Brown
2019-05-13 15:57     ` Doug Anderson
2019-05-13 16:01       ` Mark Brown
2019-05-13 16:03         ` Doug Anderson
2019-05-13 16:47           ` Mark Brown
2019-05-13 20:21             ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510223437.84368-2-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.