All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Scott Wood <oss@buserror.net>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Mark Rutland <mark.rutland@arm.com>,
	Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	Rasmus Villemoes <Rasmus.Villemoes@prevas.se>
Subject: [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier
Date: Mon, 13 May 2019 11:14:54 +0000	[thread overview]
Message-ID: <20190513111442.25724-2-rasmus.villemoes@prevas.dk> (raw)
In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk>

The local variable snum_init has no reason to have static storage duration.

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Qiang Zhao <qiang.zhao@nxp.com>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/soc/fsl/qe/qe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
 		0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
 		0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
 	};
-	static const u8 *snum_init;
+	const u8 *snum_init;
 
 	qe_num_of_snum = qe_get_num_of_snums();
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Scott Wood <oss@buserror.net>,
	Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
	Rob Herring <robh+dt@kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier
Date: Mon, 13 May 2019 11:14:54 +0000	[thread overview]
Message-ID: <20190513111442.25724-2-rasmus.villemoes@prevas.dk> (raw)
In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk>

The local variable snum_init has no reason to have static storage duration.

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Qiang Zhao <qiang.zhao@nxp.com>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/soc/fsl/qe/qe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
 		0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
 		0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
 	};
-	static const u8 *snum_init;
+	const u8 *snum_init;
 
 	qe_num_of_snum = qe_get_num_of_snums();
 
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Scott Wood <oss@buserror.net>,
	Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
	Rob Herring <robh+dt@kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier
Date: Mon, 13 May 2019 11:14:54 +0000	[thread overview]
Message-ID: <20190513111442.25724-2-rasmus.villemoes@prevas.dk> (raw)
In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk>

The local variable snum_init has no reason to have static storage duration.

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Qiang Zhao <qiang.zhao@nxp.com>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/soc/fsl/qe/qe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
 		0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
 		0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
 	};
-	static const u8 *snum_init;
+	const u8 *snum_init;
 
 	qe_num_of_snum = qe_get_num_of_snums();
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Scott Wood <oss@buserror.net>,
	Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
	Rob Herring <robh+dt@kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier
Date: Mon, 13 May 2019 11:14:54 +0000	[thread overview]
Message-ID: <20190513111442.25724-2-rasmus.villemoes@prevas.dk> (raw)
In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk>

The local variable snum_init has no reason to have static storage duration.

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Qiang Zhao <qiang.zhao@nxp.com>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/soc/fsl/qe/qe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
 		0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
 		0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
 	};
-	static const u8 *snum_init;
+	const u8 *snum_init;
 
 	qe_num_of_snum = qe_get_num_of_snums();
 
-- 
2.20.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-13 11:15 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 13:36 [PATCH RESEND 0/5] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 17:03   ` Christophe Leroy
2019-04-30 17:03     ` Christophe Leroy
2019-04-30 17:03     ` Christophe Leroy
2019-04-30 13:36 ` [PATCH 2/5] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 17:12   ` Christophe Leroy
2019-04-30 17:12     ` Christophe Leroy
2019-04-30 17:12     ` Christophe Leroy
2019-05-01  5:51     ` Rasmus Villemoes
2019-05-01  5:51       ` Rasmus Villemoes
2019-05-01  5:51       ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 3/5] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 17:14   ` Christophe Leroy
2019-04-30 17:14     ` Christophe Leroy
2019-04-30 17:14     ` Christophe Leroy
2019-04-30 13:36 ` [PATCH 4/5] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 17:19   ` Christophe Leroy
2019-04-30 17:19     ` Christophe Leroy
2019-04-30 17:19     ` Christophe Leroy
2019-05-01  6:00     ` Rasmus Villemoes
2019-05-01  6:00       ` Rasmus Villemoes
2019-05-01  6:00       ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 5/5] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 13:36   ` Rasmus Villemoes
2019-04-30 17:27   ` Christophe Leroy
2019-04-30 17:27     ` Christophe Leroy
2019-04-30 17:27     ` Christophe Leroy
2019-05-01  9:29 ` [PATCH v2 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-05-01  9:29   ` Rasmus Villemoes
2019-05-01  9:29   ` Rasmus Villemoes
2019-05-01  9:29   ` Rasmus Villemoes
2019-05-01  9:29   ` [PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29   ` [PATCH v2 2/6] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-02  4:51     ` Christophe Leroy
2019-05-02  4:51       ` Christophe Leroy
2019-05-02  4:51       ` Christophe Leroy
2019-05-01  9:29   ` [PATCH v2 3/6] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29   ` [PATCH v2 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01 15:12     ` Joakim Tjernlund
2019-05-01 15:12       ` Joakim Tjernlund
2019-05-01 15:12       ` Joakim Tjernlund
2019-05-01 15:12       ` Joakim Tjernlund
2019-05-01 18:47       ` Rasmus Villemoes
2019-05-01 18:47         ` Rasmus Villemoes
2019-05-01 18:47         ` Rasmus Villemoes
2019-05-01 18:47         ` Rasmus Villemoes
2019-05-01 21:00     ` Rob Herring
2019-05-01 21:00       ` Rob Herring
2019-05-01 21:00       ` Rob Herring
2019-05-01 21:00       ` Rob Herring
2019-05-01  9:29   ` [PATCH v2 5/6] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-02  4:52     ` Christophe Leroy
2019-05-02  4:52       ` Christophe Leroy
2019-05-02  4:52       ` Christophe Leroy
2019-05-02  4:52       ` Christophe Leroy
2019-05-01  9:29   ` [PATCH v2 6/6] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-01  9:29     ` Rasmus Villemoes
2019-05-02  4:54     ` Christophe Leroy
2019-05-02  4:54       ` Christophe Leroy
2019-05-02  4:54       ` Christophe Leroy
2019-05-02  4:54       ` Christophe Leroy
2019-05-09  2:35     ` [EXT] " Qiang Zhao
2019-05-09  2:35       ` Qiang Zhao
2019-05-09  2:35       ` Qiang Zhao
2019-05-09  2:35       ` Qiang Zhao
2019-05-13 11:14   ` [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-05-13 11:14     ` Rasmus Villemoes
2019-05-13 11:14     ` Rasmus Villemoes
2019-05-13 11:14     ` Rasmus Villemoes
2019-05-13 11:14     ` Rasmus Villemoes [this message]
2019-05-13 11:14       ` [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14     ` [PATCH v3 2/6] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14     ` [PATCH v3 3/6] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14     ` [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:14       ` Rasmus Villemoes
2019-05-13 11:39       ` Joakim Tjernlund
2019-05-13 11:39         ` Joakim Tjernlund
2019-05-13 11:39         ` Joakim Tjernlund
2019-05-13 11:39         ` Joakim Tjernlund
2019-05-13 17:51       ` Rob Herring
2019-05-13 17:51         ` Rob Herring
2019-05-13 17:51         ` Rob Herring
2019-05-13 17:51         ` Rob Herring
2019-05-13 11:15     ` [PATCH v3 5/6] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-05-13 11:15     ` [PATCH v3 6/6] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-05-13 11:15       ` Rasmus Villemoes
2019-06-03 19:53     ` [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-06-03 19:53       ` Rasmus Villemoes
2019-06-03 19:53       ` Rasmus Villemoes
2019-06-03 19:53       ` Rasmus Villemoes
2019-06-03 19:55       ` Leo Li
2019-06-03 19:55         ` Leo Li
2019-06-03 19:55         ` Leo Li
2019-06-03 19:55         ` Leo Li
2019-06-04 20:29     ` Li Yang
2019-06-04 20:29       ` Li Yang
2019-06-04 20:29       ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513111442.25724-2-rasmus.villemoes@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=Rasmus.Villemoes@prevas.se \
    --cc=christophe.leroy@c-s.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=oss@buserror.net \
    --cc=qiang.zhao@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.