[PATCH v4 02/14] arm64: Make use of is_compat_task instead of hardcoding this test

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Alexandre Ghiti <alex@ghiti.fr>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paul.burton@mips.com>,
	James Hogan <jhogan@kernel.org>,
	Palmer Dabbelt <palmer@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Alexandre Ghiti <alex@ghiti.fr>
Subject: [PATCH v4 02/14] arm64: Make use of is_compat_task instead of hardcoding this test
Date: Sun, 26 May 2019 09:47:34 -0400	[thread overview]
Message-ID: <20190526134746.9315-3-alex@ghiti.fr> (raw)
In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr>

Each architecture has its own way to determine if a task is a compat task,
by using is_compat_task in arch_mmap_rnd, it allows more genericity and
then it prepares its moving to mm/.

Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
Acked-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm64/mm/mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
index 842c8a5fcd53..ed4f9915f2b8 100644
--- a/arch/arm64/mm/mmap.c
+++ b/arch/arm64/mm/mmap.c
@@ -54,7 +54,7 @@ unsigned long arch_mmap_rnd(void)
 	unsigned long rnd;
 
 #ifdef CONFIG_COMPAT
-	if (test_thread_flag(TIF_32BIT))
+	if (is_compat_task())
 		rnd = get_random_long() & ((1UL << mmap_rnd_compat_bits) - 1);
 	else
 #endif
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)

From: Alexandre Ghiti <alex@ghiti.fr>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
	Kees Cook <keescook@chromium.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Paul Burton <paul.burton@mips.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	James Hogan <jhogan@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-mips@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v4 02/14] arm64: Make use of is_compat_task instead of hardcoding this test
Date: Sun, 26 May 2019 09:47:34 -0400	[thread overview]
Message-ID: <20190526134746.9315-3-alex@ghiti.fr> (raw)
In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr>

Each architecture has its own way to determine if a task is a compat task,
by using is_compat_task in arch_mmap_rnd, it allows more genericity and
then it prepares its moving to mm/.

Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
Acked-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm64/mm/mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
index 842c8a5fcd53..ed4f9915f2b8 100644
--- a/arch/arm64/mm/mmap.c
+++ b/arch/arm64/mm/mmap.c
@@ -54,7 +54,7 @@ unsigned long arch_mmap_rnd(void)
 	unsigned long rnd;
 
 #ifdef CONFIG_COMPAT
-	if (test_thread_flag(TIF_32BIT))
+	if (is_compat_task())
 		rnd = get_random_long() & ((1UL << mmap_rnd_compat_bits) - 1);
 	else
 #endif
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)

From: Alexandre Ghiti <alex@ghiti.fr>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
	Kees Cook <keescook@chromium.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Paul Burton <paul.burton@mips.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	James Hogan <jhogan@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-mips@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v4 02/14] arm64: Make use of is_compat_task instead of hardcoding this test
Date: Sun, 26 May 2019 09:47:34 -0400	[thread overview]
Message-ID: <20190526134746.9315-3-alex@ghiti.fr> (raw)
In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr>

Each architecture has its own way to determine if a task is a compat task,
by using is_compat_task in arch_mmap_rnd, it allows more genericity and
then it prepares its moving to mm/.

Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
Acked-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm64/mm/mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
index 842c8a5fcd53..ed4f9915f2b8 100644
--- a/arch/arm64/mm/mmap.c
+++ b/arch/arm64/mm/mmap.c
@@ -54,7 +54,7 @@ unsigned long arch_mmap_rnd(void)
 	unsigned long rnd;
 
 #ifdef CONFIG_COMPAT
-	if (test_thread_flag(TIF_32BIT))
+	if (is_compat_task())
 		rnd = get_random_long() & ((1UL << mmap_rnd_compat_bits) - 1);
 	else
 #endif
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2019-05-26 13:50 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-26 13:47 [PATCH v4 00/14] Provide generic top-down mmap layout functions Alexandre Ghiti
2019-05-26 13:47 ` Alexandre Ghiti
2019-05-26 13:47 ` Alexandre Ghiti
2019-05-26 13:47 ` [PATCH v4 01/14] mm, fs: Move randomize_stack_top from fs to mm Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47 ` Alexandre Ghiti [this message]
2019-05-26 13:47   ` [PATCH v4 02/14] arm64: Make use of is_compat_task instead of hardcoding this test Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-06-03 17:32   ` Catalin Marinas
2019-06-03 17:32     ` Catalin Marinas
2019-06-03 17:32     ` Catalin Marinas
2019-05-26 13:47 ` [PATCH v4 03/14] arm64: Consider stack randomization for mmap base only when necessary Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-06-03 17:37   ` Catalin Marinas
2019-06-03 17:37     ` Catalin Marinas
2019-06-03 17:37     ` Catalin Marinas
2019-05-26 13:47 ` [PATCH v4 04/14] arm64, mm: Move generic mmap layout functions to mm Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:10   ` Kees Cook
2019-05-29 20:10     ` Kees Cook
2019-05-29 20:10     ` Kees Cook
2019-06-03 17:38   ` Catalin Marinas
2019-06-03 17:38     ` Catalin Marinas
2019-06-03 17:38     ` Catalin Marinas
2019-05-26 13:47 ` [PATCH v4 05/14] arm64, mm: Make randomization selected by generic topdown mmap layout Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:10   ` Kees Cook
2019-05-29 20:10     ` Kees Cook
2019-05-29 20:10     ` Kees Cook
2019-06-01  9:04   ` Christoph Hellwig
2019-06-01  9:04     ` Christoph Hellwig
2019-06-01  9:04     ` Christoph Hellwig
2019-06-03  7:05     ` Alexandre Ghiti
2019-06-03  7:05       ` Alexandre Ghiti
2019-06-03  7:05       ` Alexandre Ghiti
2019-06-03 17:40   ` Catalin Marinas
2019-06-03 17:40     ` Catalin Marinas
2019-06-03 17:40     ` Catalin Marinas
2019-06-04  6:20     ` Alex Ghiti
2019-06-04  6:20       ` Alex Ghiti
2019-06-04  6:20       ` Alex Ghiti
2019-05-26 13:47 ` [PATCH v4 06/14] arm: Properly account for stack randomization and stack guard gap Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47 ` [PATCH v4 07/14] arm: Use STACK_TOP when computing mmap base address Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47 ` [PATCH v4 08/14] arm: Use generic mmap top-down layout and brk randomization Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 19:26   ` Kees Cook
2019-05-29 19:26     ` Kees Cook
2019-05-29 19:26     ` Kees Cook
2019-05-31  4:49     ` Alex Ghiti
2019-05-31  4:49       ` Alex Ghiti
2019-05-31  4:49       ` Alex Ghiti
2019-05-26 13:47 ` [PATCH v4 09/14] mips: Properly account for stack randomization and stack guard gap Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47 ` [PATCH v4 10/14] mips: Use STACK_TOP when computing mmap base address Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47 ` [PATCH v4 11/14] mips: Adjust brk randomization offset to fit generic version Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:12   ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-26 13:47 ` [PATCH v4 12/14] mips: Replace arch specific way to determine 32bit task with " Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:12   ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-26 13:47 ` [PATCH v4 13/14] mips: Use generic mmap top-down layout and brk randomization Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:12   ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-29 20:12     ` Kees Cook
2019-05-26 13:47 ` [PATCH v4 14/14] riscv: Make mmap allocation top-down by default Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-26 13:47   ` Alexandre Ghiti
2019-05-29 20:16 ` [PATCH v4 00/14] Provide generic top-down mmap layout functions Kees Cook
2019-05-29 20:16   ` Kees Cook
2019-05-29 20:16   ` Kees Cook
2019-05-31  5:04   ` Alex Ghiti
2019-05-31  5:04     ` Alex Ghiti
2019-05-31  5:04     ` Alex Ghiti
2019-06-13  5:29 ` Alex Ghiti
2019-06-13  5:29   ` Alex Ghiti
2019-06-13  5:29   ` Alex Ghiti
2019-06-30 15:34   ` Alex Ghiti
2019-06-30 15:34     ` Alex Ghiti
2019-06-30 15:34     ` Alex Ghiti

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:842c8a5fcd5 dfblob:842c8a5fcd5 dfblob:842c8a5fcd5
dfblob:ed4f9915f2b dfblob:ed4f9915f2b dfblob:ed4f9915f2b
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190526134746.9315-3-alex@ghiti.fr \
    --to=alex@ghiti.fr \
    --cc=akpm@linux-foundation.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=catalin.marinas@arm.com \
    --cc=hch@lst.de \
    --cc=jhogan@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcgrof@kernel.org \
    --cc=palmer@sifive.com \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.