From: Fred Klassen <fklassen@appneta.com>
To: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Cc: Fred Klassen <fklassen@appneta.com>
Subject: [PATCH net-next v2 3/3] net/udpgso_bench.sh test fails on error
Date: Tue, 28 May 2019 11:47:08 -0700 [thread overview]
Message-ID: <20190528184708.16516-4-fklassen@appneta.com> (raw)
In-Reply-To: <20190528184708.16516-1-fklassen@appneta.com>
Ensure that failure on any individual test results in an overall
failure of the test script.
Signed-off-by: Fred Klassen <fklassen@appneta.com>
---
tools/testing/selftests/net/udpgso_bench.sh | 33 +++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 89c7de97b832..3a8543b14d3f 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -3,6 +3,10 @@
#
# Run a series of udpgso benchmarks
+GREEN='\033[0;92m'
+RED='\033[0;31m'
+NC='\033[0m' # No Color
+
wake_children() {
local -r jobs="$(jobs -p)"
@@ -29,59 +33,88 @@ run_in_netns() {
run_udp() {
local -r args=$@
+ local errors=0
echo "udp"
run_in_netns ${args}
+ errors=$(( $errors + $? ))
echo "udp gso"
run_in_netns ${args} -S 0
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy"
run_in_netns ${args} -S 0 -z
+ errors=$(( $errors + $? ))
echo "udp gso timestamp"
run_in_netns ${args} -S 0 -T
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy audit"
run_in_netns ${args} -S 0 -z -a
+ errors=$(( $errors + $? ))
echo "udp gso timestamp audit"
run_in_netns ${args} -S 0 -T -a
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy timestamp audit"
run_in_netns ${args} -S 0 -T -z -a
+ errors=$(( $errors + $? ))
+
+ return $errors
}
run_tcp() {
local -r args=$@
+ local errors=0
echo "tcp"
run_in_netns ${args} -t
+ errors=$(( $errors + $? ))
echo "tcp zerocopy"
run_in_netns ${args} -t -z
+ errors=$(( $errors + $? ))
# excluding for now because test fails intermittently
#echo "tcp zerocopy audit"
#run_in_netns ${args} -t -z -P -a
+ #errors=$(( $errors + $? ))
+
+ return $errors
}
run_all() {
local -r core_args="-l 3"
local -r ipv4_args="${core_args} -4 -D 127.0.0.1"
local -r ipv6_args="${core_args} -6 -D ::1"
+ local errors=0
echo "ipv4"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv4_args}"
+ errors=$(( $errors + $? ))
echo "ipv6"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv6_args}"
+ errors=$(( $errors + $? ))
+
+ return $errors
}
if [[ $# -eq 0 ]]; then
run_all
+ if [ $? -ne 0 ]; then
+ echo -e "$(basename $0): ${RED}FAIL${NC}"
+ exit 1
+ fi
+
+ echo -e "$(basename $0): ${GREEN}PASS${NC}"
elif [[ $1 == "__subprocess" ]]; then
shift
run_one $@
--
2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: fklassen at appneta.com (Fred Klassen)
Subject: [PATCH net-next v2 3/3] net/udpgso_bench.sh test fails on error
Date: Tue, 28 May 2019 11:47:08 -0700 [thread overview]
Message-ID: <20190528184708.16516-4-fklassen@appneta.com> (raw)
In-Reply-To: <20190528184708.16516-1-fklassen@appneta.com>
Ensure that failure on any individual test results in an overall
failure of the test script.
Signed-off-by: Fred Klassen <fklassen at appneta.com>
---
tools/testing/selftests/net/udpgso_bench.sh | 33 +++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 89c7de97b832..3a8543b14d3f 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -3,6 +3,10 @@
#
# Run a series of udpgso benchmarks
+GREEN='\033[0;92m'
+RED='\033[0;31m'
+NC='\033[0m' # No Color
+
wake_children() {
local -r jobs="$(jobs -p)"
@@ -29,59 +33,88 @@ run_in_netns() {
run_udp() {
local -r args=$@
+ local errors=0
echo "udp"
run_in_netns ${args}
+ errors=$(( $errors + $? ))
echo "udp gso"
run_in_netns ${args} -S 0
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy"
run_in_netns ${args} -S 0 -z
+ errors=$(( $errors + $? ))
echo "udp gso timestamp"
run_in_netns ${args} -S 0 -T
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy audit"
run_in_netns ${args} -S 0 -z -a
+ errors=$(( $errors + $? ))
echo "udp gso timestamp audit"
run_in_netns ${args} -S 0 -T -a
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy timestamp audit"
run_in_netns ${args} -S 0 -T -z -a
+ errors=$(( $errors + $? ))
+
+ return $errors
}
run_tcp() {
local -r args=$@
+ local errors=0
echo "tcp"
run_in_netns ${args} -t
+ errors=$(( $errors + $? ))
echo "tcp zerocopy"
run_in_netns ${args} -t -z
+ errors=$(( $errors + $? ))
# excluding for now because test fails intermittently
#echo "tcp zerocopy audit"
#run_in_netns ${args} -t -z -P -a
+ #errors=$(( $errors + $? ))
+
+ return $errors
}
run_all() {
local -r core_args="-l 3"
local -r ipv4_args="${core_args} -4 -D 127.0.0.1"
local -r ipv6_args="${core_args} -6 -D ::1"
+ local errors=0
echo "ipv4"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv4_args}"
+ errors=$(( $errors + $? ))
echo "ipv6"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv6_args}"
+ errors=$(( $errors + $? ))
+
+ return $errors
}
if [[ $# -eq 0 ]]; then
run_all
+ if [ $? -ne 0 ]; then
+ echo -e "$(basename $0): ${RED}FAIL${NC}"
+ exit 1
+ fi
+
+ echo -e "$(basename $0): ${GREEN}PASS${NC}"
elif [[ $1 == "__subprocess" ]]; then
shift
run_one $@
--
2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: fklassen@appneta.com (Fred Klassen)
Subject: [PATCH net-next v2 3/3] net/udpgso_bench.sh test fails on error
Date: Tue, 28 May 2019 11:47:08 -0700 [thread overview]
Message-ID: <20190528184708.16516-4-fklassen@appneta.com> (raw)
Message-ID: <20190528184708.xyNV3ZuVN-SZH3uwz7y7oUlCVXnL1my7lRY4Ia9g1rA@z> (raw)
In-Reply-To: <20190528184708.16516-1-fklassen@appneta.com>
Ensure that failure on any individual test results in an overall
failure of the test script.
Signed-off-by: Fred Klassen <fklassen at appneta.com>
---
tools/testing/selftests/net/udpgso_bench.sh | 33 +++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 89c7de97b832..3a8543b14d3f 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -3,6 +3,10 @@
#
# Run a series of udpgso benchmarks
+GREEN='\033[0;92m'
+RED='\033[0;31m'
+NC='\033[0m' # No Color
+
wake_children() {
local -r jobs="$(jobs -p)"
@@ -29,59 +33,88 @@ run_in_netns() {
run_udp() {
local -r args=$@
+ local errors=0
echo "udp"
run_in_netns ${args}
+ errors=$(( $errors + $? ))
echo "udp gso"
run_in_netns ${args} -S 0
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy"
run_in_netns ${args} -S 0 -z
+ errors=$(( $errors + $? ))
echo "udp gso timestamp"
run_in_netns ${args} -S 0 -T
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy audit"
run_in_netns ${args} -S 0 -z -a
+ errors=$(( $errors + $? ))
echo "udp gso timestamp audit"
run_in_netns ${args} -S 0 -T -a
+ errors=$(( $errors + $? ))
echo "udp gso zerocopy timestamp audit"
run_in_netns ${args} -S 0 -T -z -a
+ errors=$(( $errors + $? ))
+
+ return $errors
}
run_tcp() {
local -r args=$@
+ local errors=0
echo "tcp"
run_in_netns ${args} -t
+ errors=$(( $errors + $? ))
echo "tcp zerocopy"
run_in_netns ${args} -t -z
+ errors=$(( $errors + $? ))
# excluding for now because test fails intermittently
#echo "tcp zerocopy audit"
#run_in_netns ${args} -t -z -P -a
+ #errors=$(( $errors + $? ))
+
+ return $errors
}
run_all() {
local -r core_args="-l 3"
local -r ipv4_args="${core_args} -4 -D 127.0.0.1"
local -r ipv6_args="${core_args} -6 -D ::1"
+ local errors=0
echo "ipv4"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv4_args}"
+ errors=$(( $errors + $? ))
echo "ipv6"
run_tcp "${ipv4_args}"
+ errors=$(( $errors + $? ))
run_udp "${ipv6_args}"
+ errors=$(( $errors + $? ))
+
+ return $errors
}
if [[ $# -eq 0 ]]; then
run_all
+ if [ $? -ne 0 ]; then
+ echo -e "$(basename $0): ${RED}FAIL${NC}"
+ exit 1
+ fi
+
+ echo -e "$(basename $0): ${GREEN}PASS${NC}"
elif [[ $1 == "__subprocess" ]]; then
shift
run_one $@
--
2.11.0
next prev parent reply other threads:[~2019-05-28 18:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 18:47 [PATCH net-next v2 0/3] UDP GSO audit tests Fred Klassen
2019-05-28 18:47 ` Fred Klassen
2019-05-28 18:47 ` fklassen
2019-05-28 18:47 ` [PATCH net-next v2 1/3] net/udpgso_bench_tx: options to exercise TX CMSG Fred Klassen
2019-05-28 18:47 ` Fred Klassen
2019-05-28 18:47 ` fklassen
2019-05-28 21:35 ` Willem de Bruijn
2019-05-28 21:35 ` Willem de Bruijn
2019-05-28 21:35 ` willemdebruijn.kernel
2019-06-13 23:17 ` Fred Klassen
2019-05-28 21:36 ` Willem de Bruijn
2019-05-28 21:36 ` Willem de Bruijn
2019-05-28 21:36 ` willemdebruijn.kernel
2019-05-28 18:47 ` [PATCH net-next v2 2/3] net/udpgso_bench.sh add UDP GSO audit tests Fred Klassen
2019-05-28 18:47 ` Fred Klassen
2019-05-28 18:47 ` fklassen
2019-05-28 20:09 ` Willem de Bruijn
2019-05-28 20:09 ` Willem de Bruijn
2019-05-28 20:09 ` willemdebruijn.kernel
2019-05-28 18:47 ` Fred Klassen [this message]
2019-05-28 18:47 ` [PATCH net-next v2 3/3] net/udpgso_bench.sh test fails on error Fred Klassen
2019-05-28 18:47 ` fklassen
2019-05-28 20:08 ` Willem de Bruijn
2019-05-28 20:08 ` Willem de Bruijn
2019-05-28 20:08 ` willemdebruijn.kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528184708.16516-4-fklassen@appneta.com \
--to=fklassen@appneta.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.