All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: heiko.carstens@de.ibm.com
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	linux-s390@vger.kernel.org
Subject: [PATCH] kbuild: s390, do not remove autogenerated headers on clean
Date: Wed,  5 Jun 2019 13:14:16 +0200	[thread overview]
Message-ID: <20190605111416.13341-1-jslaby@suse.cz> (raw)

'make clean' does NOT remove autogenerated headers generated from
arch/s390/kernel/syscalls/. For example:
asm-offsets.h
irq_regs.h
irq_work.h
unistd_nr.h

But 'make clean' DOES currently remove dis-defs.h and facility-defs.h
generated from arch/s390/tools/.

The issue is that facility-defs.h is included from <asm/facility.h> and
builds of external modules fail due to missing header. (When cleaned
build directory is used.)

Fix this by adding these targets to no-clean-files.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org
---

I would love to see comments from KBuild guys as I am not sure if this
fix is correct at all.

 arch/s390/tools/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 2342b84b3386..984b2f43651e 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -7,6 +7,7 @@ kapi := arch/$(ARCH)/include/generated/asm
 kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h
 
 targets += $(addprefix ../../../,$(kapi-hdrs-y))
+no-clean-files += $(targets)
 PHONY += kapi
 
 kapi:	$(kapi-hdrs-y)
-- 
2.21.0


             reply	other threads:[~2019-06-05 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 11:14 Jiri Slaby [this message]
2019-06-05 11:29 ` [PATCH] kbuild: s390, do not remove autogenerated headers on clean Masahiro Yamada
2019-06-06  5:40   ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605111416.13341-1-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.