From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: <linux-kernel@vger.kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Steve French <stfrench@microsoft.com>,
<linux-cifs@vger.kernel.org>
Subject: [PATCH] fs: cifs: Drop unlikely before IS_ERR(_OR_NULL)
Date: Wed, 5 Jun 2019 22:24:25 +0800 [thread overview]
Message-ID: <20190605142428.84784-2-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20190605142428.84784-1-wangkefeng.wang@huawei.com>
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag,
so no need to do that again from its callers. Drop it.
Cc: Steve French <stfrench@microsoft.com>
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
fs/cifs/dfs_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index e3e1c13df439..1692c0c6c23a 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -492,7 +492,7 @@ static struct dfs_cache_entry *__find_cache_entry(unsigned int hash,
#ifdef CONFIG_CIFS_DEBUG2
char *name = get_tgt_name(ce);
- if (unlikely(IS_ERR(name))) {
+ if (IS_ERR(name)) {
rcu_read_unlock();
return ERR_CAST(name);
}
--
2.20.1
next prev parent reply other threads:[~2019-06-05 14:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 14:24 [PATCH] fs: gfs2: Use IS_ERR_OR_NULL Kefeng Wang
2019-06-05 14:24 ` [Cluster-devel] " Kefeng Wang
2019-06-05 14:24 ` Kefeng Wang [this message]
2019-06-05 14:24 ` [PATCH net-next] net: Drop unlikely before IS_ERR(_OR_NULL) Kefeng Wang
2019-06-05 14:24 ` Kefeng Wang
2019-06-05 16:13 ` Jesse Brandeburg
2019-06-05 16:13 ` Jesse Brandeburg
2019-06-06 1:39 ` Kefeng Wang
2019-06-06 1:39 ` Kefeng Wang
2019-06-06 20:41 ` Enrico Weigelt, metux IT consult
2019-06-06 20:41 ` Enrico Weigelt, metux IT consult
2019-06-05 16:40 ` Neil Horman
2019-06-05 16:40 ` Neil Horman
2019-06-05 14:24 ` [PATCH] block: " Kefeng Wang
2019-06-05 14:22 ` Jens Axboe
2019-06-05 18:24 ` Enrico Weigelt, metux IT consult
2019-06-05 18:32 ` Joe Perches
2019-06-05 20:55 ` Enrico Weigelt, metux IT consult
2019-06-05 14:24 ` [PATCH] Input: alps: " Kefeng Wang
2019-06-05 14:24 ` Kefeng Wang
2019-06-05 14:42 ` Pali Rohár
2019-06-06 1:08 ` Kefeng Wang
2019-06-06 1:08 ` Kefeng Wang
2019-06-06 2:28 ` Joe Perches
2019-06-12 0:59 ` Dmitry Torokhov
2019-06-12 7:14 ` Pali Rohár
2019-06-12 8:35 ` Joe Perches
2019-06-11 16:23 ` [PATCH] fs: gfs2: Use IS_ERR_OR_NULL Andreas Gruenbacher
2019-06-11 16:23 ` [Cluster-devel] " Andreas Gruenbacher
2019-06-12 1:07 ` Kefeng Wang
2019-06-12 1:07 ` [Cluster-devel] " Kefeng Wang
2019-06-12 1:17 ` [PATCH v2] " Kefeng Wang
2019-06-12 1:17 ` [Cluster-devel] " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605142428.84784-2-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.