From: Christoph Hellwig <hch@lst.de> To: Palmer Dabbelt <palmer@sifive.com> Cc: Damien Le Moal <damien.lemoal@wdc.com>, linux-riscv@lists.infradead.org, uclinux-dev@uclinux.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/17] riscv: improve the default power off implementation Date: Tue, 11 Jun 2019 00:16:13 +0200 [thread overview] Message-ID: <20190610221621.10938-10-hch@lst.de> (raw) In-Reply-To: <20190610221621.10938-1-hch@lst.de> Only call the SBI code if we are not running in M mode, and if we didn't do the SBI call, or it didn't succeed call wfi in a loop to at least save some power. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/riscv/kernel/reset.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index cfb6eb1d762d..17c810985ad0 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -8,8 +8,11 @@ static void default_power_off(void) { +#ifndef CONFIG_M_MODE sbi_shutdown(); - while (1); +#endif + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Palmer Dabbelt <palmer@sifive.com> Cc: linux-mm@kvack.org, Damien Le Moal <damien.lemoal@wdc.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: [PATCH 09/17] riscv: improve the default power off implementation Date: Tue, 11 Jun 2019 00:16:13 +0200 [thread overview] Message-ID: <20190610221621.10938-10-hch@lst.de> (raw) In-Reply-To: <20190610221621.10938-1-hch@lst.de> Only call the SBI code if we are not running in M mode, and if we didn't do the SBI call, or it didn't succeed call wfi in a loop to at least save some power. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/riscv/kernel/reset.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index cfb6eb1d762d..17c810985ad0 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -8,8 +8,11 @@ static void default_power_off(void) { +#ifndef CONFIG_M_MODE sbi_shutdown(); - while (1); +#endif + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.20.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-06-10 22:16 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-10 22:16 RISC-V nommu support Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 01/17] mm: provide a print_vma_addr stub for !CONFIG_MMU Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-11 10:11 ` Vladimir Murzin 2019-06-11 10:11 ` Vladimir Murzin 2019-06-10 22:16 ` [PATCH 02/17] mm: stub out all of swapops.h " Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-11 10:15 ` Vladimir Murzin 2019-06-11 10:15 ` Vladimir Murzin 2019-06-11 14:18 ` Christoph Hellwig 2019-06-11 14:18 ` Christoph Hellwig 2019-06-11 14:36 ` Vladimir Murzin 2019-06-11 14:36 ` Vladimir Murzin 2019-06-14 9:48 ` Christoph Hellwig 2019-06-14 9:48 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 03/17] mm/nommu: fix the MAP_UNINITIALIZED flag Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-11 10:19 ` Vladimir Murzin 2019-06-11 10:19 ` Vladimir Murzin 2019-06-10 22:16 ` [PATCH 04/17] irqchip/sifive-plic: set max threshold for ignored handlers Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 05/17] riscv: use CSR_SATP instead of the legacy sptbr name in switch_mm Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 06/17] riscv: clear the instruction cache and all registers when booting Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 07/17] riscv: refactor the IPI code Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 08/17] riscv: abstract out CSR names for supervisor vs machine mode Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig [this message] 2019-06-10 22:16 ` [PATCH 09/17] riscv: improve the default power off implementation Christoph Hellwig 2019-06-10 22:16 ` [PATCH 10/17] riscv: provide a flat entry loader Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 11/17] riscv: read hart ID from mhartid on boot Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 12/17] riscv: provide native clint access for M-mode Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 13/17] riscv: implement remote sfence.i natively " Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 14/17] riscv: poison SBI calls " Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 15/17] riscv: don't allow selecting SBI-based drivers " Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 16/17] riscv: use the correct interrupt levels " Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-10 22:16 ` [PATCH 17/17] riscv: add nommu support Christoph Hellwig 2019-06-10 22:16 ` Christoph Hellwig 2019-06-11 10:32 ` Vladimir Murzin 2019-06-11 10:32 ` Vladimir Murzin 2019-06-11 12:44 ` David Hildenbrand 2019-06-11 12:44 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190610221621.10938-10-hch@lst.de \ --to=hch@lst.de \ --cc=damien.lemoal@wdc.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@sifive.com \ --cc=uclinux-dev@uclinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.