All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/3] Improved FS_IOC_FSSETXATTR tests
Date: Tue, 11 Jun 2019 19:08:36 +0300	[thread overview]
Message-ID: <20190611160839.14777-1-amir73il@gmail.com> (raw)

Eryu,

Overlayfs gained support for FS_IOC_FSSETXATTR ioctl in v5.2-rc4
with buggy capability check. The fix is trivial so it should land
upstream soon.

This series adds a generic test to cover the bug in overlayfs v5.2-rc4.
It also adds a proper _require directive to test filesystem support
for FS_IOC_FSSETXATTR and let the tests that use this ioctl require
filesystem support for it.

The only existing generic test that needed this requirement is the
recently added generic/553 copy_range immutable file test. When run on
overlayfs over xfs/ext4/btrfs, generic/553 would fail instead of _notrun
with kernel v5.2-rc3.

But the requirement fix is not only for overlayfs, other filesystems
that support FS_IOC_SETFLAGS but not FS_IOC_FSSETXATTR (e.g. ext2),
need those fixes to _notrun generic/553.

Thanks,
Amir.


Amir Goldstein (3):
  fstests: print out xfs_io parameter when command fails
  fstests: check for filesystem FS_IOC_FSSETXATTR support
  generic: check CAP_LINUX_IMMUTABLE capability with FS_IOC_FSSETXATTR

 common/rc                    | 30 ++++++++++-----
 doc/requirement-checking.txt |  2 +-
 tests/generic/553            |  3 +-
 tests/generic/555            | 74 ++++++++++++++++++++++++++++++++++++
 tests/generic/555.out        |  9 +++++
 tests/generic/group          |  1 +
 tests/xfs/260                |  2 +-
 tests/xfs/431                |  2 +-
 8 files changed, 108 insertions(+), 15 deletions(-)
 create mode 100755 tests/generic/555
 create mode 100644 tests/generic/555.out

-- 
2.17.1

             reply	other threads:[~2019-06-11 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 16:08 Amir Goldstein [this message]
2019-06-11 16:08 ` [PATCH 1/3] fstests: print out xfs_io parameter when command fails Amir Goldstein
2019-06-11 16:08 ` [PATCH 2/3] fstests: check for filesystem FS_IOC_FSSETXATTR support Amir Goldstein
2019-06-11 16:08 ` [PATCH 3/3] generic: check CAP_LINUX_IMMUTABLE capability with FS_IOC_FSSETXATTR Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611160839.14777-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.