All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 03/19] ALSA: bebob: obsolete useless member of private structure
Date: Wed, 12 Jun 2019 17:44:06 +0900	[thread overview]
Message-ID: <20190612084422.5344-4-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20190612084422.5344-1-o-takashi@sakamocchi.jp>

The private structure of this driver has 'connected' member but nowadays
it's useless. This commit removes it.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/bebob/bebob.h        | 2 --
 sound/firewire/bebob/bebob_stream.c | 7 -------
 2 files changed, 9 deletions(-)

diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
index c30ed44aced9..20ed2dbd8d61 100644
--- a/sound/firewire/bebob/bebob.h
+++ b/sound/firewire/bebob/bebob.h
@@ -93,8 +93,6 @@ struct snd_bebob {
 	unsigned int midi_input_ports;
 	unsigned int midi_output_ports;
 
-	bool connected;
-
 	struct amdtp_stream tx_stream;
 	struct amdtp_stream rx_stream;
 	struct cmp_connection out_conn;
diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c
index d6e7f13ef42d..c3cc31df49e0 100644
--- a/sound/firewire/bebob/bebob_stream.c
+++ b/sound/firewire/bebob/bebob_stream.c
@@ -422,9 +422,6 @@ static int make_both_connections(struct snd_bebob *bebob)
 {
 	int err = 0;
 
-	if (bebob->connected)
-		return 0;
-
 	err = cmp_connection_establish(&bebob->out_conn,
 			amdtp_stream_get_max_payload(&bebob->tx_stream));
 	if (err < 0)
@@ -437,8 +434,6 @@ static int make_both_connections(struct snd_bebob *bebob)
 		return err;
 	}
 
-	bebob->connected = true;
-
 	return 0;
 }
 
@@ -448,8 +443,6 @@ break_both_connections(struct snd_bebob *bebob)
 	cmp_connection_break(&bebob->in_conn);
 	cmp_connection_break(&bebob->out_conn);
 
-	bebob->connected = false;
-
 	/* These models seems to be in transition state for a longer time. */
 	if (bebob->maudio_special_quirk != NULL)
 		msleep(200);
-- 
2.20.1

  parent reply	other threads:[~2019-06-12  8:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  8:44 [PATCH 00/19] ALSA: bebob/fireworks/oxfw: code refactoring toward rework for reservation of isochronous resources Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 01/19] ALSA: bebob: configure sampling transfer frequency in pcm.hw_params callback Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 02/19] ALSA: bebob: don't set XRUN in stop streaming Takashi Sakamoto
2019-06-12  8:44 ` Takashi Sakamoto [this message]
2019-06-12  8:44 ` [PATCH 04/19] ALSA: bebob: code refactoring to initialize/destroy stream data Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 05/19] ALSA: fireworks: unify substream counter Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 06/19] ALSA: fireworks: code refactoring for rawmidi.open/close Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 07/19] ALSA: fireworks: code refactoring for pcm.hw_params/hw_free Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 08/19] ALSA: fireworks: configure sampling transfer frequency in pcm.hw_params callback Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 09/19] ALSA: fireworks: configure stream parameters " Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 10/19] ALSA: fireworks: don't set XRUN in stop streaming Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 11/19] ALSA: oxfw: code refactoring for stop condition of packet streaming Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 12/19] ALSA: oxfw: set packet parameter according to current configuration Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 13/19] ALSA: oxfw: start duplex streams if supported Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 14/19] ALSA: oxfw: break packet streaming at bus-reset handler Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 15/19] ALSA: oxfw: expand stop procedure for packet streaming Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 16/19] ALSA: oxfw: rename helper functions for duplex streams Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 17/19] ALSA: oxfw: unify substreams counter Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 18/19] ALSA: oxfw: configure packet format in pcm.hw_params callback Takashi Sakamoto
2019-06-12  8:44 ` [PATCH 19/19] ALSA: oxfw: configure stream parameter " Takashi Sakamoto
2019-06-12 13:30 ` [PATCH 00/19] ALSA: bebob/fireworks/oxfw: code refactoring toward rework for reservation of isochronous resources Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612084422.5344-4-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.