All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: anna.schumaker@netapp.com
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v3 00/19] for-5.3 patches
Date: Mon, 17 Jun 2019 11:31:29 -0400	[thread overview]
Message-ID: <20190617152657.12090.11389.stgit@manet.1015granger.net> (raw)

Hi Anna-

I think these are ready for merge.

This is a series of fixes and architectural changes that should
improve robustness and result in better scalability of NFS/RDMA.

The fundamental observation is that the RPC work queues are BOUND,
thus rescheduling work in the Receive completion handler to one of
these work queues just forces it to run later on the same CPU. So
try to do more work right in the Receive completion handler to
reduce context switch overhead.

A secondary concern is that the average amount of wall-clock time
it takes to handle a single Receive completion caps the IOPS rate
(both per-xprt and per-NIC). In this patch series I've taken a few
steps to reduce that latency, and I'm looking into a few others.

This series can be fetched from:

git://git.linux-nfs.org/projects/cel/cel-2.6.git

in topic branch "nfs-for-5.3".


Changes since v2:
* Rebased on v5.2-rc5
* Changed trace points to display errors as negative values
* Used BIT() when defining trace point flag values
* Updated NFS lookup flags as well

Changes since RFC:
* Rebased on v5.2-rc4
* Clarified some patch descriptions and comments
* Addressed Anna's compiler warning in frwr_unmap_[a]sync
* Cross-ported recent xs_connect changes to xprt_rdma_connect
* Fixed several trace-event bugs

---

Chuck Lever (19):
      xprtrdma: Fix a BUG when tracing is enabled with NFSv4.1 on RDMA
      xprtrdma: Fix use-after-free in rpcrdma_post_recvs
      xprtrdma: Replace use of xdr_stream_pos in rpcrdma_marshal_req
      xprtrdma: Fix occasional transport deadlock
      xprtrdma: Remove the RPCRDMA_REQ_F_PENDING flag
      xprtrdma: Remove fr_state
      xprtrdma: Add mechanism to place MRs back on the free list
      xprtrdma: Reduce context switching due to Local Invalidation
      xprtrdma: Wake RPCs directly in rpcrdma_wc_send path
      xprtrdma: Simplify rpcrdma_rep_create
      xprtrdma: Streamline rpcrdma_post_recvs
      xprtrdma: Refactor chunk encoding
      xprtrdma: Remove rpcrdma_req::rl_buffer
      xprtrdma: Modernize ops->connect
      NFS4: Add a trace event to record invalid CB sequence IDs
      NFS: Fix show_nfs_errors macros again
      NFS: Display symbolic status code names in trace log
      NFS: Update symbolic flags displayed by trace events
      NFS: Record task, client ID, and XID in xdr_status trace points


 fs/nfs/callback_proc.c          |   28 ++-
 fs/nfs/nfs2xdr.c                |    2 
 fs/nfs/nfs3xdr.c                |    2 
 fs/nfs/nfs4trace.h              |  207 +++++++++++++++----------
 fs/nfs/nfs4xdr.c                |    2 
 fs/nfs/nfstrace.h               |  233 +++++++++++++++++++++-------
 include/linux/sunrpc/xprt.h     |    3 
 include/trace/events/rpcrdma.h  |   90 ++++++++---
 net/sunrpc/sched.c              |    1 
 net/sunrpc/xprt.c               |   32 ++++
 net/sunrpc/xprtrdma/frwr_ops.c  |  327 ++++++++++++++++++++++++++-------------
 net/sunrpc/xprtrdma/rpc_rdma.c  |  148 ++++++++----------
 net/sunrpc/xprtrdma/transport.c |   83 ++++++++--
 net/sunrpc/xprtrdma/verbs.c     |  115 ++++++--------
 net/sunrpc/xprtrdma/xprt_rdma.h |   44 +----
 net/sunrpc/xprtsock.c           |   23 ---
 16 files changed, 837 insertions(+), 503 deletions(-)

--
Chuck Lever

             reply	other threads:[~2019-06-17 15:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 15:31 Chuck Lever [this message]
2019-06-17 15:31 ` [PATCH v3 01/19] xprtrdma: Fix a BUG when tracing is enabled with NFSv4.1 on RDMA Chuck Lever
2019-06-17 15:31 ` [PATCH v3 02/19] xprtrdma: Fix use-after-free in rpcrdma_post_recvs Chuck Lever
2019-06-17 15:31 ` [PATCH v3 03/19] xprtrdma: Replace use of xdr_stream_pos in rpcrdma_marshal_req Chuck Lever
2019-06-17 15:31 ` [PATCH v3 04/19] xprtrdma: Fix occasional transport deadlock Chuck Lever
2019-06-17 15:31 ` [PATCH v3 05/19] xprtrdma: Remove the RPCRDMA_REQ_F_PENDING flag Chuck Lever
2019-06-17 15:32 ` [PATCH v3 06/19] xprtrdma: Remove fr_state Chuck Lever
2019-06-17 20:36   ` Chuck Lever
2019-06-17 15:32 ` [PATCH v3 07/19] xprtrdma: Add mechanism to place MRs back on the free list Chuck Lever
2019-06-17 15:32 ` [PATCH v3 08/19] xprtrdma: Reduce context switching due to Local Invalidation Chuck Lever
2019-06-17 15:32 ` [PATCH v3 09/19] xprtrdma: Wake RPCs directly in rpcrdma_wc_send path Chuck Lever
2019-06-17 15:32 ` [PATCH v3 10/19] xprtrdma: Simplify rpcrdma_rep_create Chuck Lever
2019-06-17 15:32 ` [PATCH v3 11/19] xprtrdma: Streamline rpcrdma_post_recvs Chuck Lever
2019-06-17 15:32 ` [PATCH v3 12/19] xprtrdma: Refactor chunk encoding Chuck Lever
2019-06-17 15:32 ` [PATCH v3 13/19] xprtrdma: Remove rpcrdma_req::rl_buffer Chuck Lever
2019-06-17 15:32 ` [PATCH v3 14/19] xprtrdma: Modernize ops->connect Chuck Lever
2019-06-17 15:32 ` [PATCH v3 15/19] NFS4: Add a trace event to record invalid CB sequence IDs Chuck Lever
2019-06-17 15:32 ` [PATCH v3 16/19] NFS: Fix show_nfs_errors macros again Chuck Lever
2019-06-17 15:33 ` [PATCH v3 17/19] NFS: Display symbolic status code names in trace log Chuck Lever
2019-06-17 15:33 ` [PATCH v3 18/19] NFS: Update symbolic flags displayed by trace events Chuck Lever
2019-06-17 15:33 ` [PATCH v3 19/19] NFS: Record task, client ID, and XID in xdr_status trace points Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617152657.12090.11389.stgit@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.