From: Anthony PERARD <anthony.perard@citrix.com> To: <qemu-devel@nongnu.org> Cc: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Paul Durrant <paul.durrant@citrix.com>, Stefano Stabellini <sstabellini@kernel.org> Subject: [Qemu-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h Date: Tue, 18 Jun 2019 12:23:40 +0100 [thread overview] Message-ID: <20190618112341.513-4-anthony.perard@citrix.com> (raw) In-Reply-To: <20190618112341.513-1-anthony.perard@citrix.com> xen-mapcache.c doesn't needs params.h. xen-hvm.c uses defines available in params.h but so is xen_common.h which is included before. HVM_PARAM_* flags are only needed to make xc_hvm_param_{get,set} calls so including only xenctrl.h, which is where the definition the function is, should be enough. (xenctrl.h does include params.h) Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: v2: - new patch replacing "xen: Import Xen public headers used by xen-hvm.c" - only drop includes of params.h, and don't import the other two; ioreq.h is an interface with Xen; e820.h is just used by QEMU to figure out the guest memory layout without proper communication with the Xen toolstacks or something like that. hw/i386/xen/xen-hvm.c | 1 - hw/i386/xen/xen-mapcache.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 2939122e7c..ae3deb4ef3 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -27,7 +27,6 @@ #include "exec/address-spaces.h" #include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> #include <xen/hvm/e820.h> //#define DEBUG_XEN_HVM diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index 254759f776..dc73c86c61 100644 --- a/hw/i386/xen/xen-mapcache.c +++ b/hw/i386/xen/xen-mapcache.c @@ -17,8 +17,6 @@ #include "hw/xen/xen-legacy-backend.h" #include "qemu/bitmap.h" -#include <xen/hvm/params.h> - #include "sysemu/xen-mapcache.h" #include "trace.h" -- Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com> To: <qemu-devel@nongnu.org> Cc: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Paul Durrant <paul.durrant@citrix.com>, Stefano Stabellini <sstabellini@kernel.org> Subject: [Xen-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h Date: Tue, 18 Jun 2019 12:23:40 +0100 [thread overview] Message-ID: <20190618112341.513-4-anthony.perard@citrix.com> (raw) In-Reply-To: <20190618112341.513-1-anthony.perard@citrix.com> xen-mapcache.c doesn't needs params.h. xen-hvm.c uses defines available in params.h but so is xen_common.h which is included before. HVM_PARAM_* flags are only needed to make xc_hvm_param_{get,set} calls so including only xenctrl.h, which is where the definition the function is, should be enough. (xenctrl.h does include params.h) Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: v2: - new patch replacing "xen: Import Xen public headers used by xen-hvm.c" - only drop includes of params.h, and don't import the other two; ioreq.h is an interface with Xen; e820.h is just used by QEMU to figure out the guest memory layout without proper communication with the Xen toolstacks or something like that. hw/i386/xen/xen-hvm.c | 1 - hw/i386/xen/xen-mapcache.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 2939122e7c..ae3deb4ef3 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -27,7 +27,6 @@ #include "exec/address-spaces.h" #include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> #include <xen/hvm/e820.h> //#define DEBUG_XEN_HVM diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index 254759f776..dc73c86c61 100644 --- a/hw/i386/xen/xen-mapcache.c +++ b/hw/i386/xen/xen-mapcache.c @@ -17,8 +17,6 @@ #include "hw/xen/xen-legacy-backend.h" #include "qemu/bitmap.h" -#include <xen/hvm/params.h> - #include "sysemu/xen-mapcache.h" #include "trace.h" -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-18 11:29 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 11:23 [Qemu-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup Anthony PERARD 2019-06-18 11:23 ` [Xen-devel] " Anthony PERARD 2019-06-18 11:23 ` [Qemu-devel] [PATCH v2 1/4] xen: Fix build with public headers Anthony PERARD 2019-06-18 11:23 ` [Xen-devel] " Anthony PERARD 2019-06-18 12:14 ` [Qemu-devel] " Daniel P. Berrangé 2019-06-18 12:14 ` [Xen-devel] " Daniel P. Berrangé 2019-06-20 14:44 ` Anthony PERARD 2019-06-20 14:44 ` [Xen-devel] " Anthony PERARD 2019-06-18 11:23 ` [Qemu-devel] [PATCH v2 2/4] xen: Import other xen/io/*.h Anthony PERARD 2019-06-18 11:23 ` [Xen-devel] " Anthony PERARD 2019-06-18 11:23 ` Anthony PERARD [this message] 2019-06-18 11:23 ` [Xen-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h Anthony PERARD 2019-06-18 11:51 ` [Qemu-devel] " Paul Durrant 2019-06-18 11:51 ` [Xen-devel] " Paul Durrant 2019-06-18 11:23 ` [Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA Anthony PERARD 2019-06-18 11:23 ` [Xen-devel] " Anthony PERARD 2019-06-18 11:35 ` [Qemu-devel] " Philippe Mathieu-Daudé 2019-06-18 11:35 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-06-18 11:52 ` Paul Durrant 2019-06-18 11:52 ` [Xen-devel] " Paul Durrant 2019-06-18 12:00 ` [Qemu-devel] [Xen-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup no-reply 2019-06-18 12:00 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190618112341.513-4-anthony.perard@citrix.com \ --to=anthony.perard@citrix.com \ --cc=paul.durrant@citrix.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.