All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 8/8] ALSA: oxfw: ensure to release isochronous resources in pcm.hw_params callback
Date: Tue, 18 Jun 2019 22:26:22 +0900	[thread overview]
Message-ID: <20190618132622.32659-9-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20190618132622.32659-1-o-takashi@sakamocchi.jp>

When stopping packet streaming in reserve function for duplex streams,
isochronous resources should be released.

Fixes: 7bc93821a70a ("ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/oxfw/oxfw-stream.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/firewire/oxfw/oxfw-stream.c b/sound/firewire/oxfw/oxfw-stream.c
index a8bc798731ff..a7502810a3ad 100644
--- a/sound/firewire/oxfw/oxfw-stream.c
+++ b/sound/firewire/oxfw/oxfw-stream.c
@@ -283,10 +283,12 @@ int snd_oxfw_stream_reserve_duplex(struct snd_oxfw *oxfw,
 	if (formation.rate != rate || formation.pcm != pcm_channels) {
 		amdtp_stream_stop(&oxfw->rx_stream);
 		cmp_connection_break(&oxfw->in_conn);
+		cmp_connection_release(&oxfw->in_conn);
 
 		if (oxfw->has_output) {
 			amdtp_stream_stop(&oxfw->tx_stream);
 			cmp_connection_break(&oxfw->out_conn);
+			cmp_connection_release(&oxfw->out_conn);
 		}
 	}
 
-- 
2.20.1

  parent reply	other threads:[~2019-06-18 13:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 13:26 [PATCH 0/8] ALSA: firewire: minor code refactoring and bug Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 1/8] ALSA: firewire-tascam: unify stop and release method for duplex streams Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 2/8] ALSA: fireface: " Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 3/8] ALSA: firewire-motu: " Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 4/8] ALSA: firewire-digi00x: " Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 5/8] ALSA: dice: " Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 6/8] ALSA: bebob: ensure to release isochronous resources in pcm.hw_params callback Takashi Sakamoto
2019-06-18 13:26 ` [PATCH 7/8] ALSA: fireworks: " Takashi Sakamoto
2019-06-18 13:26 ` Takashi Sakamoto [this message]
2019-06-21  9:47 ` [PATCH 0/8] ALSA: firewire: minor code refactoring and bug Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618132622.32659-9-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.