All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL 2/8] blockdev: enable non-root nodes for transaction drive-backup source
Date: Fri, 21 Jun 2019 15:23:18 +0200	[thread overview]
Message-ID: <20190621132324.2165-3-mreitz@redhat.com> (raw)
In-Reply-To: <20190621132324.2165-1-mreitz@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

We forget to enable it for transaction .prepare, while it is already
enabled in do_drive_backup since commit a2d665c1bc362
    "blockdev: loosen restrictions on drive-backup source node"

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190618140804.59214-1-vsementsov@virtuozzo.com
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 blockdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blockdev.c b/blockdev.c
index 5d6a13dea9..4d141e9a1f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1774,7 +1774,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp)
     assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
     backup = common->action->u.drive_backup.data;
 
-    bs = qmp_get_root_bs(backup->device, errp);
+    bs = bdrv_lookup_bs(backup->device, backup->device, errp);
     if (!bs) {
         return;
     }
-- 
2.21.0



  parent reply	other threads:[~2019-06-21 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 13:23 [Qemu-devel] [PULL 0/8] Block patches Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 1/8] nvme: do not advertise support for unsupported arbitration mechanism Max Reitz
2019-06-21 13:23 ` Max Reitz [this message]
2019-06-21 13:23 ` [Qemu-devel] [PULL 3/8] iotest 134: test cluster-misaligned encrypted write Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 4/8] vmdk: Fix comment regarding max l1_size coverage Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 5/8] vmdk: Reduce the max bound for L1 table size Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 6/8] vmdk: Add read-only support for seSparse snapshots Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 7/8] ssh: switch from libssh2 to libssh Max Reitz
2019-06-21 13:23 ` [Qemu-devel] [PULL 8/8] iotests: Fix 205 for concurrent runs Max Reitz
2019-06-23 17:18 ` [Qemu-devel] [PULL 0/8] Block patches Peter Maydell
2019-06-24 12:20   ` Max Reitz
2019-06-24 13:15     ` Pino Toscano
2019-06-24 14:49       ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621132324.2165-3-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.