All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ammy Yi <ammy.yi@intel.com>
Subject: [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU
Date: Fri, 21 Jun 2019 19:19:29 +0300	[thread overview]
Message-ID: <20190621161930.60785-4-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <20190621161930.60785-1-alexander.shishkin@linux.intel.com>

Commit 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU") switched
the single mode code to use dma mapping pages obtained from the page
allocator, but with IOMMU disabled, that may lead to using SWIOTLB bounce
buffers and without additional sync'ing, produces empty trace buffers.

Fix this by using a DMA32 GFP flag to the page allocation in single mode,
as the device supports full 32-bit DMA addressing.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Fixes: 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: Ammy Yi <ammy.yi@intel.com>
---
 drivers/hwtracing/intel_th/msu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 6bfce03c6489..cfd48c81b9d9 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -667,7 +667,7 @@ static int msc_buffer_contig_alloc(struct msc *msc, unsigned long size)
 		goto err_out;
 
 	ret = -ENOMEM;
-	page = alloc_pages(GFP_KERNEL | __GFP_ZERO, order);
+	page = alloc_pages(GFP_KERNEL | __GFP_ZERO | GFP_DMA32, order);
 	if (!page)
 		goto err_free_sgt;
 
-- 
2.20.1


  parent reply	other threads:[~2019-06-21 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 16:19 [GIT PULL 0/4] intel_th: Fixes for v5.2 Alexander Shishkin
2019-06-21 16:19 ` [GIT PULL 1/4] intel_th: msu: Fix unused variable warning on arm64 platform Alexander Shishkin
2019-06-21 16:19 ` [GIT PULL 2/4] intel_th: msu: Remove set but not used variable 'last' Alexander Shishkin
2019-06-21 16:19 ` Alexander Shishkin [this message]
2019-07-03 15:36   ` [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU Greg Kroah-Hartman
2019-06-21 16:19 ` [GIT PULL 4/4] intel_th: pci: Add Ice Lake NNPI support Alexander Shishkin
2019-07-03 15:26 ` [GIT PULL 0/4] intel_th: Fixes for v5.2 Alexander Shishkin
2019-07-03 15:34   ` Greg Kroah-Hartman
2019-07-03 15:35 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621161930.60785-4-alexander.shishkin@linux.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=ammy.yi@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.