From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [RFC 0/4] Display uncore
Date: Mon, 24 Jun 2019 13:31:48 -0700 [thread overview]
Message-ID: <20190624203152.13725-1-daniele.ceraolospurio@intel.com> (raw)
More focused proposal for display/GT uncore split.
A few notes/considerations:
- I've copied the MMIO ranges check in patch 3 from a patch from Ville
that did something similar in regards to splitting GT/DE register
access. I'm seeing some check failures on gen 3 and 4 [1], so I'd
appreciate it if someone could double check those ranges since I'm
not familiar with those gens. For the same reason I don't expect BAT
to pass.
- Instead of doing a range check to find erroneous accesses, I
considered using a new structure for display registers (wrapping
i915_reg_t) and therefore force a compile-time check, but the sheer
amount of register definitions that would need updating makes this
hard to merge together with the switch to the new functions without
hitting conflicts. If there is interest in this option, I'll put
something out after all the display register accesses have
transitioned to the new accessors.
- When MMIO debug is enabled, the accesses from GT and DE are still
serialized because the HW debug infrastructure is shared. Since our
testing defaults the MMIO debug on, we won't really test parallel
accesses. After the series settles down I'm going to submit a CI run
with MMIO debug off, but maybe we should update some tests to run
with MMIO debug disabled. Thoughts?
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
[1] https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4491/?
Daniele Ceraolo Spurio (4):
drm/i915: split out uncore_mmio_debug
drm/i915: rework mmio debug stop/start
drm/i915: introduce display_uncore
drm/i915: convert intel_hdmi to display reg accessors
drivers/gpu/drm/i915/display/intel_hdmi.c | 278 ++++++++++------------
drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
drivers/gpu/drm/i915/i915_drv.c | 20 +-
drivers/gpu/drm/i915/i915_drv.h | 59 +++++
drivers/gpu/drm/i915/intel_uncore.c | 100 +++++---
drivers/gpu/drm/i915/intel_uncore.h | 18 +-
6 files changed, 292 insertions(+), 185 deletions(-)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-06-24 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 20:31 Daniele Ceraolo Spurio [this message]
2019-06-24 20:31 ` [RFC 1/4] drm/i915: split out uncore_mmio_debug Daniele Ceraolo Spurio
2019-06-26 10:02 ` Chris Wilson
2019-06-26 17:38 ` Daniele Ceraolo Spurio
2019-06-26 17:58 ` Chris Wilson
2019-06-26 18:20 ` Daniele Ceraolo Spurio
2019-06-24 20:31 ` [RFC 2/4] drm/i915: rework mmio debug stop/start Daniele Ceraolo Spurio
2019-06-24 20:31 ` [RFC 3/4] drm/i915: introduce display_uncore Daniele Ceraolo Spurio
2019-06-26 18:42 ` Ville Syrjälä
2019-06-26 20:27 ` Daniele Ceraolo Spurio
2019-06-27 12:41 ` Ville Syrjälä
2019-06-24 20:31 ` [RFC 4/4] drm/i915: convert intel_hdmi to display reg accessors Daniele Ceraolo Spurio
2019-06-24 20:43 ` ✗ Fi.CI.SPARSE: warning for Display uncore (rev2) Patchwork
2019-06-24 21:37 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-25 1:04 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624203152.13725-1-daniele.ceraolospurio@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.