All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH 3/7] drm/vc4: Use drm_gem_fb_prepare_fb
Date: Tue, 25 Jun 2019 22:42:04 +0200	[thread overview]
Message-ID: <20190625204208.5614-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190625204208.5614-1-daniel.vetter@ffwll.ch>

vc4 has switched to using drm_fb->obj[], so we can just use the helper
unchanged.

v2: Make it compile ... oops.

Cc: Eric Anholt <eric@anholt.net>
Cc: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_plane.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index 0a0207c350a5..a996ca8ff972 100644
--- a/drivers/gpu/drm/vc4/vc4_plane.c
+++ b/drivers/gpu/drm/vc4/vc4_plane.c
@@ -20,6 +20,7 @@
 #include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_atomic_uapi.h>
+#include <drm/drm_gem_framebuffer_helper.h>
 
 #include "uapi/drm/vc4_drm.h"
 #include "vc4_drv.h"
@@ -1123,7 +1124,6 @@ static int vc4_prepare_fb(struct drm_plane *plane,
 			  struct drm_plane_state *state)
 {
 	struct vc4_bo *bo;
-	struct dma_fence *fence;
 	int ret;
 
 	if (!state->fb)
@@ -1131,8 +1131,7 @@ static int vc4_prepare_fb(struct drm_plane *plane,
 
 	bo = to_vc4_bo(&drm_fb_cma_get_gem_obj(state->fb, 0)->base);
 
-	fence = reservation_object_get_excl_rcu(bo->base.base.resv);
-	drm_atomic_set_fence_for_plane(state, fence);
+	drm_gem_fb_prepare_fb(plane, state);
 
 	if (plane->state->fb == state->fb)
 		return 0;
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-06-25 20:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 20:42 [PATCH 0/7] gem_bo.resv prime unification, leftovers Daniel Vetter
2019-06-25 20:42 ` [PATCH 1/7] drm/fb-helper: use gem_bo.resv, not dma_buf.resv in prepare_fb Daniel Vetter
2019-06-25 20:50   ` Sam Ravnborg
2019-06-26  0:07   ` Eric Anholt
2019-06-25 20:42 ` [PATCH 2/7] drm/msm: Use drm_gem_fb_prepare_fb Daniel Vetter
2019-06-25 20:42   ` Daniel Vetter
2019-06-25 20:57   ` Rob Clark
2019-06-25 20:57     ` Rob Clark
2019-06-25 20:42 ` Daniel Vetter [this message]
2019-06-27  7:38   ` [PATCH 3/7] drm/vc4: " Daniel Vetter
     [not found] ` <20190625204208.5614-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-06-25 20:42   ` [PATCH 4/7] drm/radeon: Fill out gem_object->resv Daniel Vetter
     [not found]     ` <20190625204208.5614-5-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-06-25 20:52       ` Sam Ravnborg
2019-07-25 13:18         ` Daniel Vetter
2019-06-26  7:10       ` Koenig, Christian
     [not found]         ` <4cfa949e-1a20-149c-0758-e1bd97fd3cf5-5C7GfCeVMHo@public.gmane.org>
2019-06-26  8:23           ` Daniel Vetter
     [not found]             ` <20190626082312.GI12905-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-06-27  7:33               ` Daniel Vetter
     [not found]                 ` <20190627073350.GG12905-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-07-19 13:00                   ` Daniel Vetter
2019-06-25 20:42   ` [PATCH 5/7] drm/nouveau: " Daniel Vetter
2019-06-25 20:42 ` [PATCH 6/7] drm/amdgpu: " Daniel Vetter
2019-06-25 20:42 ` [PATCH 7/7] drm/prime: Ditch gem_prime_res_obj hook Daniel Vetter
2019-06-26 10:04 ` [PATCH 0/7] gem_bo.resv prime unification, leftovers Mike Lothian
2019-06-27 12:16 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625204208.5614-4-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.