All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 15/17] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out
Date: Wed, 26 Jun 2019 04:32:49 +0300	[thread overview]
Message-ID: <20190626013252.30470-16-digetx@gmail.com> (raw)
In-Reply-To: <20190626013252.30470-1-digetx@gmail.com>

There is another kHz-conversion bug in the code, resulting in integer
overflow. Although, this time the resulting value is 4294966296 and it's
close to ULONG_MAX, which is okay in this case.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/devfreq/tegra30-devfreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 1dcc2d2fa9e0..c03135000af7 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -172,7 +172,7 @@ struct tegra_actmon_emc_ratio {
 };
 
 static const struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
-	{ 1400000, ULONG_MAX },
+	{ 1400000, ULONG_MAX / KHZ },
 	{ 1200000,    750000 },
 	{ 1100000,    600000 },
 	{ 1000000,    500000 },
-- 
2.22.0

  parent reply	other threads:[~2019-06-26  1:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  1:32 [PATCH v2 00/17] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 01/17] PM / devfreq: tegra30: Change irq type to unsigned int Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 02/17] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 03/17] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 04/17] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 05/17] PM / devfreq: tegra30: Set up watermarks properly Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 06/17] PM / devfreq: tegra30: Tuneup boosting thresholds Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 07/17] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 08/17] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 09/17] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 10/17] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 11/17] PM / devfreq: tegra30: Add debug messages Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 12/17] PM / devfreq: tegra30: Inline all one-line functions Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 13/17] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 14/17] PM / devfreq: tegra30: Ensure that target freq won't overflow Dmitry Osipenko
2019-06-26  1:32 ` Dmitry Osipenko [this message]
2019-06-26  1:32 ` [PATCH v2 16/17] PM / devfreq: tegra30: Use kHz units uniformly in the code Dmitry Osipenko
2019-06-26  1:32 ` [PATCH v2 17/17] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626013252.30470-16-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.