All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
	<David1.Zhou@amd.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<harry.wentland@amd.com>, <tianci.yin@amd.com>,
	<tao.zhou1@amd.com>, <leo.liu@amd.com>, <ray.huang@amd.com>,
	<Jack.Xiao@amd.com>, <Hawking.Zhang@amd.com>,
	<kenneth.feng@amd.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
	<amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'
Date: Thu, 27 Jun 2019 07:53:50 +0000	[thread overview]
Message-ID: <20190627075350.86800-1-yuehaibing@huawei.com> (raw)

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_common_early_init':
drivers/gpu/drm/amd/amdgpu/nv.c:471:7: warning:
 variable 'psp_enabled' set but not used [-Wunused-but-set-variable]

It's not used since inroduction in
commit c6b6a42175f5 ("drm/amdgpu: add navi10 common ip block (v3)")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/amd/amdgpu/nv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index af20ffb55c54..8b9fa3db8daa 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -468,7 +468,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =
 
 static int nv_common_early_init(void *handle)
 {
-	bool psp_enabled = false;
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
 	adev->smc_rreg = NULL;
@@ -485,10 +484,6 @@ static int nv_common_early_init(void *handle)
 
 	adev->asic_funcs = &nv_asic_funcs;
 
-	if (amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_PSP) &&
-	    (amdgpu_ip_block_mask & (1 << AMD_IP_BLOCK_TYPE_PSP)))
-		psp_enabled = true;
-
 	adev->rev_id = nv_get_rev_id(adev);
 	adev->external_rev_id = 0xff;
 	switch (adev->asic_type) {




WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
	David1.Zhou@amd.com, airlied@linux.ie, daniel@ffwll.ch,
	harry.wentland@amd.com, tianci.yin@amd.com, tao.zhou1@amd.com,
	leo.liu@amd.com, ray.huang@amd.com, Jack.Xiao@amd.com,
	Hawking.Zhang@amd.com, kenneth.feng@amd.com
Cc: YueHaibing <yuehaibing@huawei.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'
Date: Thu, 27 Jun 2019 07:53:50 +0000	[thread overview]
Message-ID: <20190627075350.86800-1-yuehaibing@huawei.com> (raw)
In-Reply-To: <1537971334-130152-1-git-send-email-yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_common_early_init':
drivers/gpu/drm/amd/amdgpu/nv.c:471:7: warning:
 variable 'psp_enabled' set but not used [-Wunused-but-set-variable]

It's not used since inroduction in
commit c6b6a42175f5 ("drm/amdgpu: add navi10 common ip block (v3)")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/amd/amdgpu/nv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index af20ffb55c54..8b9fa3db8daa 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -468,7 +468,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs  
 static int nv_common_early_init(void *handle)
 {
-	bool psp_enabled = false;
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
 	adev->smc_rreg = NULL;
@@ -485,10 +484,6 @@ static int nv_common_early_init(void *handle)
 
 	adev->asic_funcs = &nv_asic_funcs;
 
-	if (amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_PSP) &&
-	    (amdgpu_ip_block_mask & (1 << AMD_IP_BLOCK_TYPE_PSP)))
-		psp_enabled = true;
-
 	adev->rev_id = nv_get_rev_id(adev);
 	adev->external_rev_id = 0xff;
 	switch (adev->asic_type) {

WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
	David1.Zhou@amd.com, airlied@linux.ie, daniel@ffwll.ch,
	harry.wentland@amd.com, tianci.yin@amd.com, tao.zhou1@amd.com,
	leo.liu@amd.com, ray.huang@amd.com, Jack.Xiao@amd.com,
	Hawking.Zhang@amd.com, kenneth.feng@amd.com
Cc: YueHaibing <yuehaibing@huawei.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'
Date: Thu, 27 Jun 2019 07:53:50 +0000	[thread overview]
Message-ID: <20190627075350.86800-1-yuehaibing@huawei.com> (raw)

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_common_early_init':
drivers/gpu/drm/amd/amdgpu/nv.c:471:7: warning:
 variable 'psp_enabled' set but not used [-Wunused-but-set-variable]

It's not used since inroduction in
commit c6b6a42175f5 ("drm/amdgpu: add navi10 common ip block (v3)")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/amd/amdgpu/nv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index af20ffb55c54..8b9fa3db8daa 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -468,7 +468,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =
 
 static int nv_common_early_init(void *handle)
 {
-	bool psp_enabled = false;
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
 	adev->smc_rreg = NULL;
@@ -485,10 +484,6 @@ static int nv_common_early_init(void *handle)
 
 	adev->asic_funcs = &nv_asic_funcs;
 
-	if (amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_PSP) &&
-	    (amdgpu_ip_block_mask & (1 << AMD_IP_BLOCK_TYPE_PSP)))
-		psp_enabled = true;
-
 	adev->rev_id = nv_get_rev_id(adev);
 	adev->external_rev_id = 0xff;
 	switch (adev->asic_type) {

             reply	other threads:[~2019-06-27  7:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  7:53 YueHaibing [this message]
2019-06-27  7:53 ` [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled' YueHaibing
2019-06-27  7:53 ` YueHaibing
2019-08-22  2:37 ` Alex Deucher
2019-08-22  2:37   ` Alex Deucher
2019-08-22  2:37   ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2019-02-26  5:48 [PATCH -next] drm/amdgpu: remove set but not used variable 'vbi_time_out' YueHaibing
2019-02-26  5:48 ` YueHaibing
2019-02-26  5:48 ` YueHaibing
2019-02-28  2:47 ` Alex Deucher
2019-02-28  2:47   ` Alex Deucher
2019-02-28  2:47   ` Alex Deucher
2018-12-08 14:58 [PATCH -next] drm/amdgpu: remove set but not used variable 'amdgpu_connector' YueHaibing
2018-12-08 14:58 ` YueHaibing
2018-12-08 14:58 ` YueHaibing
2018-09-29 11:39 [PATCH -next] drm/amdgpu: remove set but not used variable 'ring' in psp_v11_0_ring_stop YueHaibing
2018-09-29 11:39 ` YueHaibing
2018-09-29 11:39 ` YueHaibing
2018-10-10 19:13 ` Alex Deucher
2018-10-10 19:13   ` Alex Deucher
2018-10-10 19:13   ` Alex Deucher
2018-09-29 11:16 [PATCH -next] drm/amdgpu: remove set but not used variable 'ring' in psp_v3_1_ring_stop YueHaibing
2018-09-29 11:16 ` YueHaibing
2018-09-29 11:16 ` YueHaibing
2018-09-26 14:15 [PATCH -next] drm/amdgpu: remove set but not used variable 'header' YueHaibing
2018-09-26 14:15 ` YueHaibing
2018-09-26 14:15 ` YueHaibing
2018-10-10 19:18 ` Alex Deucher
2018-10-10 19:18   ` Alex Deucher
2018-10-10 19:18   ` Alex Deucher
2018-12-08 14:53 ` [PATCH -next] drm/amdgpu: remove set but not used variable 'grbm_soft_reset' YueHaibing
2018-12-08 15:01   ` YueHaibing
2018-12-08 15:01   ` YueHaibing
2018-12-10  2:48   ` Zhou, David(ChunMing)
2018-12-10  2:48     ` Zhou, David(ChunMing)
2018-12-10  2:48     ` Zhou, David(ChunMing)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627075350.86800-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=David1.Zhou@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Jack.Xiao@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kenneth.feng@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=leo.liu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray.huang@amd.com \
    --cc=tao.zhou1@amd.com \
    --cc=tianci.yin@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.