All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Murray <andrew.murray@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Mike Leach <mike.leach@linaro.org>
Subject: [PATCH v2 3/5] coresight: etm4x: use module_param instead of module_param_named
Date: Thu, 27 Jun 2019 09:35:23 +0100	[thread overview]
Message-ID: <20190627083525.37463-4-andrew.murray@arm.com> (raw)
In-Reply-To: <20190627083525.37463-1-andrew.murray@arm.com>

Given that the user-exposed module parameter for 'boot_enable' matches
the variable that it sets, let's use module_param instead of
module_param_named.

Let's also use octal permissions (checkpatch recommends this) and
provide a module parameter description.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 drivers/hwtracing/coresight/coresight-etm4x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index 68e8e3954cef..a47f29ecdd38 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -34,7 +34,8 @@
 #include "coresight-etm-perf.h"
 
 static int boot_enable;
-module_param_named(boot_enable, boot_enable, int, S_IRUGO);
+module_param(boot_enable, int, 0444);
+MODULE_PARM_DESC(boot_enable, "Enable tracing on boot");
 
 /* The number of ETMv4 currently registered */
 static int etm4_count;
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-27  8:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  8:35 [PATCH v2 0/5] coresight: etm4x: save/restore ETMv4 context across CPU low power states Andrew Murray
2019-06-27  8:35 ` [PATCH v2 1/5] coresight: etm4x: remove superfluous setting of os_unlock Andrew Murray
2019-06-27  8:35 ` [PATCH v2 2/5] coresight: etm4x: use explicit barriers on enable/disable Andrew Murray
2019-06-27  8:35   ` Andrew Murray
2019-06-27  9:16   ` Suzuki K Poulose
2019-06-27  9:16     ` Suzuki K Poulose
2019-06-27 11:41     ` Andrew Murray
2019-06-27 11:41       ` Andrew Murray
2019-06-28  2:45   ` Leo Yan
2019-06-28  2:45     ` Leo Yan
2019-06-28  8:35     ` Andrew Murray
2019-06-28  8:35       ` Andrew Murray
2019-06-28  8:51       ` Leo Yan
2019-06-28  8:51         ` Leo Yan
2019-06-28  9:00         ` Andrew Murray
2019-06-28  9:00           ` Andrew Murray
2019-06-28  9:41           ` Leo Yan
2019-06-28  9:41             ` Leo Yan
2019-07-01  8:58             ` Suzuki K Poulose
2019-07-01  8:58               ` Suzuki K Poulose
2019-07-01  9:59               ` Leo Yan
2019-07-01  9:59                 ` Leo Yan
2019-06-27  8:35 ` Andrew Murray [this message]
2019-06-27  8:35 ` [PATCH v2 4/5] coresight: etm4x: improve clarity of etm4_os_unlock comment Andrew Murray
2019-06-27  8:35 ` [PATCH v2 5/5] coresight: etm4x: save/restore state across CPU low power states Andrew Murray
2019-06-27 14:25   ` Mike Leach
2019-06-27 14:55     ` Andrew Murray
2019-06-27 16:01       ` Suzuki K Poulose
2019-07-08 14:35         ` Andrew Murray
2019-06-28  8:07   ` Leo Yan
2019-06-28  8:53     ` Andrew Murray
2019-06-28  9:12       ` Leo Yan
2019-06-28  9:22         ` Andrew Murray
2019-07-01  2:07           ` Leo Yan
2019-07-01  9:34             ` Andrew Murray
2019-07-01  9:48               ` Leo Yan
2019-07-01  9:54                 ` Andrew Murray
2019-07-01 10:14                   ` Leo Yan
2019-07-04 10:21                     ` Andrew Murray
2019-07-04 14:27                       ` Mathieu Poirier
2019-07-05  1:52                         ` Leo Yan
2019-07-01 13:15   ` Suzuki K Poulose
2019-07-04  9:59     ` Andrew Murray
2019-07-03 21:21   ` Mathieu Poirier
2019-07-04 10:06     ` Andrew Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627083525.37463-4-andrew.murray@arm.com \
    --to=andrew.murray@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=sudeep.holla@arm.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.