All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, ebiggers@kernel.org,
	horia.geanta@nxp.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 07/30] crypto: cpt/des - switch to new verification routines
Date: Thu, 27 Jun 2019 14:02:51 +0200	[thread overview]
Message-ID: <20190627120314.7197-8-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20190627120314.7197-1-ard.biesheuvel@linaro.org>

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 drivers/crypto/cavium/cpt/cptvf_algs.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/crypto/cavium/cpt/cptvf_algs.c b/drivers/crypto/cavium/cpt/cptvf_algs.c
index f6b0c9df12ed..f9b0ac792d6d 100644
--- a/drivers/crypto/cavium/cpt/cptvf_algs.c
+++ b/drivers/crypto/cavium/cpt/cptvf_algs.c
@@ -10,7 +10,7 @@
 #include <crypto/aes.h>
 #include <crypto/algapi.h>
 #include <crypto/authenc.h>
-#include <crypto/des.h>
+#include <crypto/internal/des.h>
 #include <crypto/xts.h>
 #include <linux/crypto.h>
 #include <linux/err.h>
@@ -325,14 +325,11 @@ static int cvm_cfb_aes_setkey(struct crypto_ablkcipher *cipher, const u8 *key,
 static int cvm_cbc_des3_setkey(struct crypto_ablkcipher *cipher, const u8 *key,
 			       u32 keylen)
 {
-	u32 flags = crypto_ablkcipher_get_flags(cipher);
 	int err;
 
-	err = __des3_verify_key(&flags, key);
-	if (unlikely(err)) {
-		crypto_ablkcipher_set_flags(cipher, flags);
+	err = crypto_des3_ede_verify_key(crypto_ablkcipher_tfm(cipher), key);
+	if (unlikely(err))
 		return err;
-	}
 
 	return cvm_setkey(cipher, key, keylen, DES3_CBC);
 }
@@ -340,14 +337,11 @@ static int cvm_cbc_des3_setkey(struct crypto_ablkcipher *cipher, const u8 *key,
 static int cvm_ecb_des3_setkey(struct crypto_ablkcipher *cipher, const u8 *key,
 			       u32 keylen)
 {
-	u32 flags = crypto_ablkcipher_get_flags(cipher);
 	int err;
 
-	err = __des3_verify_key(&flags, key);
-	if (unlikely(err)) {
-		crypto_ablkcipher_set_flags(cipher, flags);
+	err = crypto_des3_ede_verify_key(crypto_ablkcipher_tfm(cipher), key);
+	if (unlikely(err))
 		return err;
-	}
 
 	return cvm_setkey(cipher, key, keylen, DES3_ECB);
 }
-- 
2.20.1


  parent reply	other threads:[~2019-06-27 12:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 12:02 [PATCH v2 00/30] crypto: DES/3DES cleanup Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 01/30] crypto: des/3des_ede - add new helpers to verify key length Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 02/30] crypto: s390/des - switch to new verification routines Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 03/30] crypto: sparc/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 04/30] crypto: atmel/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 05/30] crypto: bcm/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 06/30] crypto: caam/des " Ard Biesheuvel
2019-06-27 13:26   ` Horia Geanta
2019-06-27 13:45     ` Ard Biesheuvel
2019-06-27 12:02 ` Ard Biesheuvel [this message]
2019-06-27 12:02 ` [PATCH v2 08/30] crypto: nitrox/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 09/30] crypto: ccp/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 10/30] crypto: ccree/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 11/30] crypto: hifn/des " Ard Biesheuvel
2019-06-27 16:19   ` Eric Biggers
2019-06-27 16:34     ` Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 12/30] crypto: hisilicon/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 13/30] crypto: safexcel/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 14/30] crypto: ixp4xx/des " Ard Biesheuvel
2019-06-27 12:02 ` [PATCH v2 15/30] crypto: cesa/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 16/30] crypto: n2/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 17/30] crypto: omap/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 18/30] crypto: picoxcell/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 19/30] crypto: qce/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 20/30] crypto: rk3288/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 21/30] crypto: stm32/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 22/30] crypto: sun4i/des " Ard Biesheuvel
2019-06-27 16:16   ` Eric Biggers
2019-06-27 12:03 ` [PATCH v2 23/30] crypto: talitos/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 24/30] crypto: ux500/des " Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 25/30] crypto: 3des - move verification out of exported routine Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 26/30] crypto: des - remove unused function Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 27/30] crypto: des - split off DES library from generic DES cipher driver Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 28/30] crypto: x86/des - switch to library interface Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 29/30] crypto: des - remove now unused __des3_ede_setkey() Ard Biesheuvel
2019-06-27 12:03 ` [PATCH v2 30/30] fs: cifs: move from the crypto cipher API to the new DES library interface Ard Biesheuvel
2019-06-27 14:44 ` [PATCH v2 00/30] crypto: DES/3DES cleanup Horia Geanta
2019-06-27 14:50   ` Ard Biesheuvel
2019-06-27 14:54     ` Ard Biesheuvel
2019-06-27 15:42       ` Horia Geanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627120314.7197-8-ard.biesheuvel@linaro.org \
    --to=ard.biesheuvel@linaro.org \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.