All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 01/22] PM / devfreq: tegra30: Change irq type to unsigned int
Date: Fri, 28 Jun 2019 00:10:54 +0300	[thread overview]
Message-ID: <20190627211115.21138-2-digetx@gmail.com> (raw)
In-Reply-To: <20190627211115.21138-1-digetx@gmail.com>

IRQ numbers are always positive, hence the corresponding variable should
be unsigned to keep types consistent. This is a minor change that cleans
up code a tad more.

Suggested-by: Thierry Reding <thierry.reding@gmail.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/devfreq/tegra30-devfreq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index a6ba75f4106d..a27300f40b0b 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -160,7 +160,7 @@ struct tegra_devfreq {
 
 	struct tegra_devfreq_device devices[ARRAY_SIZE(actmon_device_configs)];
 
-	int irq;
+	unsigned int		irq;
 };
 
 struct tegra_actmon_emc_ratio {
@@ -618,12 +618,12 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 		return PTR_ERR(tegra->emc_clock);
 	}
 
-	tegra->irq = platform_get_irq(pdev, 0);
-	if (tegra->irq < 0) {
-		err = tegra->irq;
+	err = platform_get_irq(pdev, 0);
+	if (err < 0) {
 		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
 		return err;
 	}
+	tegra->irq = err;
 
 	reset_control_assert(tegra->reset);
 
-- 
2.22.0

  reply	other threads:[~2019-06-27 21:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 21:10 [PATCH v3 00/22] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-06-27 21:10 ` Dmitry Osipenko [this message]
2019-06-27 21:10 ` [PATCH v3 02/22] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-06-27 21:10 ` [PATCH v3 03/22] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-06-27 21:10 ` [PATCH v3 04/22] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-06-27 21:10 ` [PATCH v3 05/22] PM / devfreq: tegra30: Set up watermarks properly Dmitry Osipenko
2019-06-27 21:10 ` [PATCH v3 06/22] PM / devfreq: tegra30: Tune up boosting thresholds Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 07/22] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 08/22] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 09/22] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 10/22] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 11/22] PM / devfreq: tegra30: Add debug messages Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 12/22] PM / devfreq: tegra30: Inline all one-line functions Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 13/22] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 14/22] PM / devfreq: tegra30: Ensure that target freq won't overflow Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 15/22] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 16/22] PM / devfreq: tegra30: Use kHz units uniformly in the code Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 17/22] PM / devfreq: tegra30: Use tracepoints for debugging Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 18/22] PM / devfreq: tegra30: Optimize CPUFreq notifier Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 19/22] PM / devfreq: tegra30: Optimize upper consecutive watermark selection Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 20/22] PM / devfreq: tegra30: Optimize upper average " Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 21/22] PM / devfreq: tegra30: Include appropriate header Dmitry Osipenko
2019-06-27 21:11 ` [PATCH v3 22/22] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko
     [not found] ` <CGME20190627211230epcas5p2504c225e67a823a586768a2749248b72@epcms1p3>
2019-06-28  6:48   ` [PATCH v3 02/22] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped MyungJoo Ham
2019-06-28  7:12     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627211115.21138-2-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.