All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] kheaders: remove meaningless -R option of 'ls'
Date: Mon,  1 Jul 2019 09:58:43 +0900	[thread overview]
Message-ID: <20190701005845.12475-6-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20190701005845.12475-1-yamada.masahiro@socionext.com>

The -R option of 'ls' is supposed to be used for directories.

       -R, --recursive
              list subdirectories recursively

Since 'find ... -type f' only matches to regular files, we do not
expect directories passed to the 'ls' command here.

Giving -R is harmless at least, but unneeded.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v4:
  - New patch

Changes in v3: None
Changes in v2: None

 kernel/gen_kheaders.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
index 9a34e1d9bd7f..86a666f5cb17 100755
--- a/kernel/gen_kheaders.sh
+++ b/kernel/gen_kheaders.sh
@@ -33,8 +33,8 @@ arch/$SRCARCH/include/
 # Uncomment it for debugging.
 # if [ ! -f /tmp/iter ]; then iter=1; echo 1 > /tmp/iter;
 # else iter=$(($(cat /tmp/iter) + 1)); echo $iter > /tmp/iter; fi
-# find $src_file_list -type f | xargs ls -lR > /tmp/src-ls-$iter
-# find $obj_file_list -type f | xargs ls -lR > /tmp/obj-ls-$iter
+# find $src_file_list -type f | xargs ls -l > /tmp/src-ls-$iter
+# find $obj_file_list -type f | xargs ls -l > /tmp/obj-ls-$iter
 
 # include/generated/compile.h is ignored because it is touched even when none
 # of the source files changed. This causes pointless regeneration, so let us
@@ -46,7 +46,7 @@ src_files_md5="$(find $src_file_list -type f                       |
 		grep -v "include/config/auto.conf"		   |
 		grep -v "include/config/auto.conf.cmd"		   |
 		grep -v "include/config/tristate.conf"		   |
-		xargs ls -lR | md5sum | cut -d ' ' -f1)"
+		xargs ls -l | md5sum | cut -d ' ' -f1)"
 popd > /dev/null
 obj_files_md5="$(find $obj_file_list -type f                       |
 		grep -v "include/generated/compile.h"		   |
@@ -54,7 +54,7 @@ obj_files_md5="$(find $obj_file_list -type f                       |
 		grep -v "include/config/auto.conf"                 |
 		grep -v "include/config/auto.conf.cmd"		   |
 		grep -v "include/config/tristate.conf"		   |
-		xargs ls -lR | md5sum | cut -d ' ' -f1)"
+		xargs ls -l | md5sum | cut -d ' ' -f1)"
 
 if [ -f $tarfile ]; then tarfile_md5="$(md5sum $tarfile | cut -d ' ' -f1)"; fi
 if [ -f kernel/kheaders.md5 ] &&
-- 
2.17.1


  parent reply	other threads:[~2019-07-01  1:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01  0:58 [PATCH 0/7] Compile-test UAPI and kernel headers Masahiro Yamada
2019-07-01  0:58 ` Masahiro Yamada
2019-07-01  0:58 ` Masahiro Yamada
2019-07-01  0:58 ` Masahiro Yamada
2019-07-01  0:58 ` [PATCH 1/7] init/Kconfig: add CONFIG_CC_CAN_LINK Masahiro Yamada
2019-07-01  0:58 ` [PATCH 2/7] kbuild: compile-test exported headers to ensure they are self-contained Masahiro Yamada
2019-07-01  0:58   ` Masahiro Yamada
2019-07-01  0:58 ` [PATCH 3/7] kbuild: do not create wrappers for header-test-y Masahiro Yamada
2019-07-09  1:10   ` Masahiro Yamada
2019-07-01  0:58 ` [PATCH 4/7] kbuild: support header-test-pattern-y Masahiro Yamada
2019-07-01  0:58 ` Masahiro Yamada [this message]
2019-07-02 16:54   ` [PATCH 5/7] kheaders: remove meaningless -R option of 'ls' Joel Fernandes
2019-07-01  0:58 ` [PATCH 6/7] kheaders: include only headers into kheaders_data.tar.xz Masahiro Yamada
2019-07-01  0:58 ` [PATCH 7/7] kbuild: compile-test kernel headers to ensure they are self-contained Masahiro Yamada
2019-07-01  0:58   ` Masahiro Yamada
2019-07-01  0:58   ` Masahiro Yamada
2019-07-02 16:47   ` Joel Fernandes
2019-07-02 16:47     ` Joel Fernandes
2019-07-02 16:47     ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190701005845.12475-6-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.