From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 10/11] input: keyboard: gpio_keys: convert platform driver to use dev_groups Date: Thu, 4 Jul 2019 10:46:16 +0200 [thread overview] Message-ID: <20190704084617.3602-11-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20190704084617.3602-1-gregkh@linuxfoundation.org> Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a bunch of sysfs files. Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/input/keyboard/gpio_keys.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 6cd199e8a370..1f6547440edb 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -354,10 +354,7 @@ static struct attribute *gpio_keys_attrs[] = { &dev_attr_disabled_switches.attr, NULL, }; - -static const struct attribute_group gpio_keys_attr_group = { - .attrs = gpio_keys_attrs, -}; +ATTRIBUTE_GROUPS(gpio_keys); static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata) { @@ -856,13 +853,6 @@ static int gpio_keys_probe(struct platform_device *pdev) fwnode_handle_put(child); - error = devm_device_add_group(dev, &gpio_keys_attr_group); - if (error) { - dev_err(dev, "Unable to export keys/switches, error: %d\n", - error); - return error; - } - error = input_register_device(input); if (error) { dev_err(dev, "Unable to register input device, error: %d\n", @@ -1025,6 +1015,7 @@ static void gpio_keys_shutdown(struct platform_device *pdev) } static struct platform_driver gpio_keys_device_driver = { + .dev_groups = gpio_keys_groups, .probe = gpio_keys_probe, .shutdown = gpio_keys_shutdown, .driver = { -- 2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 10/11] input: keyboard: gpio_keys: convert platform driver to use dev_groups Date: Thu, 04 Jul 2019 08:46:16 +0000 [thread overview] Message-ID: <20190704084617.3602-11-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20190704084617.3602-1-gregkh@linuxfoundation.org> Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a bunch of sysfs files. Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/input/keyboard/gpio_keys.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 6cd199e8a370..1f6547440edb 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -354,10 +354,7 @@ static struct attribute *gpio_keys_attrs[] = { &dev_attr_disabled_switches.attr, NULL, }; - -static const struct attribute_group gpio_keys_attr_group = { - .attrs = gpio_keys_attrs, -}; +ATTRIBUTE_GROUPS(gpio_keys); static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata) { @@ -856,13 +853,6 @@ static int gpio_keys_probe(struct platform_device *pdev) fwnode_handle_put(child); - error = devm_device_add_group(dev, &gpio_keys_attr_group); - if (error) { - dev_err(dev, "Unable to export keys/switches, error: %d\n", - error); - return error; - } - error = input_register_device(input); if (error) { dev_err(dev, "Unable to register input device, error: %d\n", @@ -1025,6 +1015,7 @@ static void gpio_keys_shutdown(struct platform_device *pdev) } static struct platform_driver gpio_keys_device_driver = { + .dev_groups = gpio_keys_groups, .probe = gpio_keys_probe, .shutdown = gpio_keys_shutdown, .driver = { -- 2.22.0
next prev parent reply other threads:[~2019-07-04 8:46 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-04 8:46 [PATCH 00/11] Platform drivers, provide a way to add sysfs groups easily Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 01/11] Platform: add a dev_groups pointer to struct platform_driver Greg Kroah-Hartman 2019-07-04 9:32 ` Johan Hovold 2019-07-04 10:43 ` Greg Kroah-Hartman 2019-07-04 12:11 ` [PATCH 01/12 v2] " Greg Kroah-Hartman 2019-07-04 21:17 ` Dmitry Torokhov 2019-07-06 8:32 ` Greg Kroah-Hartman 2019-07-06 17:04 ` Dmitry Torokhov 2019-07-06 17:19 ` Greg Kroah-Hartman 2019-07-06 17:39 ` Dmitry Torokhov 2019-07-19 11:52 ` Greg Kroah-Hartman 2019-07-20 4:38 ` Dmitry Torokhov 2019-07-25 13:44 ` Greg Kroah-Hartman 2019-07-25 19:02 ` Richard Gong 2019-07-25 19:04 ` Greg Kroah-Hartman 2019-07-25 19:13 ` Dmitry Torokhov 2019-07-25 19:18 ` Dmitry Torokhov 2019-07-04 8:46 ` [PATCH 02/11] uio: uio_fsl_elbc_gpcm: convert platform driver to use dev_groups Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 03/11] serial: sh-sci: use driver core functions, not sysfs ones Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 04/11] firmware: arm_scpi: convert platform driver to use dev_groups Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 9:10 ` Sudeep Holla 2019-07-04 9:10 ` Sudeep Holla 2019-07-31 12:28 ` Greg Kroah-Hartman 2019-07-31 12:28 ` Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 05/11] olpc: x01: " Greg Kroah-Hartman 2019-07-04 13:28 ` Andy Shevchenko 2019-07-04 8:46 ` [PATCH 06/11] platform: x86: hp-wmi: " Greg Kroah-Hartman 2019-07-04 13:29 ` Andy Shevchenko 2019-07-04 8:46 ` [PATCH 07/11] video: fbdev: wm8505fb: " Greg Kroah-Hartman 2019-07-04 13:29 ` Andy Shevchenko 2019-07-04 14:25 ` Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 08/11] video: fbdev: w100fb: " Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-04 8:46 ` [PATCH 09/11] video: fbdev: sm501fb: " Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-04 8:46 ` Greg Kroah-Hartman 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:01 ` Bartlomiej Zolnierkiewicz 2019-07-04 8:46 ` Greg Kroah-Hartman [this message] 2019-07-04 8:46 ` [PATCH 10/11] input: keyboard: gpio_keys: " Greg Kroah-Hartman 2019-07-04 8:46 ` [PATCH 11/11] input: axp20x-pek: " Greg Kroah-Hartman 2019-07-04 14:26 ` [PATCH 07/11] video: fbdev: wm8505fb: " Greg Kroah-Hartman 2019-07-04 14:26 ` Greg Kroah-Hartman 2019-07-04 14:26 ` Greg Kroah-Hartman 2019-07-05 15:00 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:00 ` Bartlomiej Zolnierkiewicz 2019-07-05 15:00 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190704084617.3602-11-gregkh@linuxfoundation.org \ --to=gregkh@linuxfoundation.org \ --cc=b.zolnierkie@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.