All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 3/3] perf_pmu: Refine requirement testing for engine-busy-stats
Date: Thu,  4 Jul 2019 17:15:50 +0100	[thread overview]
Message-ID: <20190704161550.15109-3-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20190704161550.15109-1-chris@chris-wilson.co.uk>

Now that we report whether the accurate per-engine utilisation
statistics are available (albeit via the scheduler caps) put it to to
use to selectively enable the high accuracy tests where we expect it to
work.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 72b9166af..c3573b7a1 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1468,7 +1468,7 @@ test_enable_race(int gem_fd, const struct intel_execution_engine2 *e)
 	struct drm_i915_gem_execbuffer2 eb = { };
 	int fd;
 
-	igt_require(gem_has_execlists(gem_fd));
+	igt_require(gem_scheduler_has_engine_busy_stats(gem_fd));
 	igt_require(gem_context_has_engine(gem_fd, 0, e->flags));
 
 	obj.handle = gem_create(gem_fd, 4096);
@@ -1538,7 +1538,7 @@ accuracy(int gem_fd, const struct intel_execution_engine2 *e,
 	int fd;
 
 	/* Sampling platforms cannot reach the high accuracy criteria. */
-	igt_require(gem_has_execlists(gem_fd));
+	igt_require(gem_scheduler_has_engine_busy_stats(gem_fd));
 
 	/* Aim for approximately 100 iterations for calibration */
 	cycle_us = min_test_us / target_iters;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 3/3] perf_pmu: Refine requirement testing for engine-busy-stats
Date: Thu,  4 Jul 2019 17:15:50 +0100	[thread overview]
Message-ID: <20190704161550.15109-3-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20190704161550.15109-1-chris@chris-wilson.co.uk>

Now that we report whether the accurate per-engine utilisation
statistics are available (albeit via the scheduler caps) put it to to
use to selectively enable the high accuracy tests where we expect it to
work.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 72b9166af..c3573b7a1 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1468,7 +1468,7 @@ test_enable_race(int gem_fd, const struct intel_execution_engine2 *e)
 	struct drm_i915_gem_execbuffer2 eb = { };
 	int fd;
 
-	igt_require(gem_has_execlists(gem_fd));
+	igt_require(gem_scheduler_has_engine_busy_stats(gem_fd));
 	igt_require(gem_context_has_engine(gem_fd, 0, e->flags));
 
 	obj.handle = gem_create(gem_fd, 4096);
@@ -1538,7 +1538,7 @@ accuracy(int gem_fd, const struct intel_execution_engine2 *e,
 	int fd;
 
 	/* Sampling platforms cannot reach the high accuracy criteria. */
-	igt_require(gem_has_execlists(gem_fd));
+	igt_require(gem_scheduler_has_engine_busy_stats(gem_fd));
 
 	/* Aim for approximately 100 iterations for calibration */
 	cycle_us = min_test_us / target_iters;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-07-04 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 16:15 [PATCH i-g-t 1/3] uapi/i915: Sync to bf73fc0fa9cf Chris Wilson
2019-07-04 16:15 ` [igt-dev] " Chris Wilson
2019-07-04 16:15 ` [PATCH i-g-t 2/3] lib/i915: Report I915_SCHEDULER_CAP_ENGINE_BUSY_STATS Chris Wilson
2019-07-04 16:15   ` [igt-dev] " Chris Wilson
2019-07-04 16:15 ` Chris Wilson [this message]
2019-07-04 16:15   ` [igt-dev] [PATCH i-g-t 3/3] perf_pmu: Refine requirement testing for engine-busy-stats Chris Wilson
2019-07-04 17:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] uapi/i915: Sync to bf73fc0fa9cf Patchwork
2019-07-05 23:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704161550.15109-3-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.