All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 09/19] drm/i915: Add debugs to distingiush a cd2x update from a full cdclk pll update
Date: Mon,  8 Jul 2019 15:53:15 +0300	[thread overview]
Message-ID: <20190708125325.16576-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20190708125325.16576-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

To make the logs a bit less confusing let's toss in some
debug prints to indicate whether the cdclk reprogramming
is going to happen with a single pipe active or whether we
need to turn all pipes off for the duration.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index c7c46b382738..f2910c0c3e3e 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -2696,6 +2696,9 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state)
 			return ret;
 
 		state->cdclk.pipe = pipe;
+
+		DRM_DEBUG_KMS("Can change cdclk with pipe %c active\n",
+			      pipe_name(pipe));
 	} else if (intel_cdclk_needs_modeset(&dev_priv->cdclk.actual,
 					     &state->cdclk.actual)) {
 		ret = intel_modeset_all_pipes(state);
@@ -2703,6 +2706,8 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state)
 			return ret;
 
 		state->cdclk.pipe = INVALID_PIPE;
+
+		DRM_DEBUG_KMS("Modeset required for cdclk change\n");
 	}
 
 	DRM_DEBUG_KMS("New cdclk calculated to be logical %u kHz, actual %u kHz\n",
-- 
2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-07-08 12:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 12:53 [PATCH 00/19] drm/i915: Plane cdclk requirements and fp16 for gen4+ Ville Syrjala
2019-07-08 12:53 ` [PATCH 01/19] drm: Add drm_modeset_lock_assert_held() Ville Syrjala
2019-07-08 12:53 ` [PATCH 02/19] drm/atomic-helper: Make crtc helper funcs optional Ville Syrjala
2019-09-05  6:38   ` Lisovskiy, Stanislav
2019-09-05 11:00     ` Ville Syrjälä
2019-09-18 13:42   ` Lisovskiy, Stanislav
2019-09-19 18:47     ` Ville Syrjälä
2019-07-08 12:53 ` [PATCH 03/19] drm/i915: Remove pointless planes_changed=true assignment Ville Syrjala
2019-09-05  6:40   ` Lisovskiy, Stanislav
2019-07-08 12:53 ` [PATCH 04/19] drm/i915: Replace is_planar_yuv_format() with drm_format_info_is_yuv_semiplanar() Ville Syrjala
2019-07-08 12:53 ` [PATCH 05/19] drm/i915: Allow downscale factor of <3.0 on glk+ for all formats Ville Syrjala
2019-09-11  9:53   ` Maarten Lankhorst
2019-09-11 10:39     ` [Intel-gfx] " Ville Syrjälä
2019-07-08 12:53 ` [PATCH 06/19] drm/i915: Extract intel_modeset_calc_cdclk() Ville Syrjala
2019-07-08 12:53 ` [PATCH 07/19] drm/i915: s/pipe_config/crtc_state/ in intel_crtc_atomic_check() Ville Syrjala
2019-07-08 12:53 ` [PATCH 08/19] drm/i915: Stop using drm_atomic_helper_check_planes() Ville Syrjala
2019-09-05  6:44   ` Lisovskiy, Stanislav
2019-09-19 11:15   ` Maarten Lankhorst
2019-07-08 12:53 ` Ville Syrjala [this message]
2019-07-08 12:53 ` [PATCH 10/19] drm/i915: Make .modeset_calc_cdclk() mandatory Ville Syrjala
2019-09-19 11:01   ` [Intel-gfx] " Maarten Lankhorst
2019-07-08 12:53 ` [PATCH 11/19] drm/i915: Rework global state locking Ville Syrjala
2019-07-08 12:53 ` [PATCH 12/19] drm/i915: Move check_digital_port_conflicts() earier Ville Syrjala
2019-07-08 12:53 ` [PATCH 13/19] drm/i915: Allow planes to declare their minimum acceptable cdclk Ville Syrjala
2019-07-08 12:53 ` [PATCH 14/19] drm/i915: Eliminate skl_check_pipe_max_pixel_rate() Ville Syrjala
2019-07-08 12:53 ` [PATCH 15/19] drm/i915: Simplify skl_max_scale() Ville Syrjala
2019-09-16 20:01   ` Juha-Pekka Heikkilä
2019-07-08 12:53 ` [PATCH 16/19] drm/i915: Add support for half float framebuffers for skl+ Ville Syrjala
2019-07-08 12:53 ` [PATCH 17/19] drm/i915: Add support for half float framebuffers for gen4+ primary planes Ville Syrjala
2019-07-08 12:53 ` [PATCH 18/19] drm/i915: Add support for half float framebuffers for ivb+ sprites Ville Syrjala
2019-07-08 12:53 ` [PATCH 19/19] drm/i915: Add support for half float framebuffers on snb sprites Ville Syrjala
2019-07-08 13:13 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Plane cdclk requirements and fp16 for gen4+ Patchwork
2019-07-08 13:21 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-08 13:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-08 19:41 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708125325.16576-10-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.