All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-i2c@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"Pawe? Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Allison Randal <allison@lohutok.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/6] media: radio: si470x: Convert to new i2c device probe()
Date: Wed, 10 Jul 2019 22:51:45 +0100	[thread overview]
Message-ID: <20190710215149.9208-3-kieran.bingham+renesas@ideasonboard.com> (raw)
In-Reply-To: <20190710215149.9208-1-kieran.bingham+renesas@ideasonboard.com>

The I2C core framework provides a simplified probe framework from commit
b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type").

This driver does not utilise the i2c_device_id table in the probe, so we can
easily convert it to utilise the simplfied i2c driver registration.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/media/radio/si470x/radio-si470x-i2c.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
index 7d53422b3b56..7541698a0be1 100644
--- a/drivers/media/radio/si470x/radio-si470x-i2c.c
+++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
@@ -330,8 +330,7 @@ static irqreturn_t si470x_i2c_interrupt(int irq, void *dev_id)
 /*
  * si470x_i2c_probe - probe for the device
  */
-static int si470x_i2c_probe(struct i2c_client *client,
-			    const struct i2c_device_id *id)
+static int si470x_i2c_probe(struct i2c_client *client)
 {
 	struct si470x_device *radio;
 	int retval = 0;
@@ -544,7 +543,7 @@ static struct i2c_driver si470x_i2c_driver = {
 		.pm		= &si470x_i2c_pm,
 #endif
 	},
-	.probe			= si470x_i2c_probe,
+	.probe_new		= si470x_i2c_probe,
 	.remove			= si470x_i2c_remove,
 	.id_table		= si470x_i2c_id,
 };
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-i2c@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Pawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Allison Randal <allison@lohutok.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/6] media: radio: si470x: Convert to new i2c device probe()
Date: Wed, 10 Jul 2019 22:51:45 +0100	[thread overview]
Message-ID: <20190710215149.9208-3-kieran.bingham+renesas@ideasonboard.com> (raw)
In-Reply-To: <20190710215149.9208-1-kieran.bingham+renesas@ideasonboard.com>

The I2C core framework provides a simplified probe framework from commit
b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type").

This driver does not utilise the i2c_device_id table in the probe, so we can
easily convert it to utilise the simplfied i2c driver registration.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/media/radio/si470x/radio-si470x-i2c.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
index 7d53422b3b56..7541698a0be1 100644
--- a/drivers/media/radio/si470x/radio-si470x-i2c.c
+++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
@@ -330,8 +330,7 @@ static irqreturn_t si470x_i2c_interrupt(int irq, void *dev_id)
 /*
  * si470x_i2c_probe - probe for the device
  */
-static int si470x_i2c_probe(struct i2c_client *client,
-			    const struct i2c_device_id *id)
+static int si470x_i2c_probe(struct i2c_client *client)
 {
 	struct si470x_device *radio;
 	int retval = 0;
@@ -544,7 +543,7 @@ static struct i2c_driver si470x_i2c_driver = {
 		.pm		= &si470x_i2c_pm,
 #endif
 	},
-	.probe			= si470x_i2c_probe,
+	.probe_new		= si470x_i2c_probe,
 	.remove			= si470x_i2c_remove,
 	.id_table		= si470x_i2c_id,
 };
-- 
2.20.1

  parent reply	other threads:[~2019-07-10 21:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 21:51 [PATCH 0/6] media: i2c: Convert to probe_new() Kieran Bingham
2019-07-10 21:51 ` [PATCH 1/6] media: radio: si4713: Convert to new i2c device probe() Kieran Bingham
2019-07-10 21:51   ` Kieran Bingham
2019-07-31 19:51   ` Wolfram Sang
2019-07-10 21:51 ` Kieran Bingham [this message]
2019-07-10 21:51   ` [PATCH 2/6] media: radio: si470x: " Kieran Bingham
2019-07-31 19:51   ` Wolfram Sang
2019-07-10 21:51 ` [PATCH 3/6] media: i2c: smiapp: " Kieran Bingham
2019-07-10 21:51   ` Kieran Bingham
2019-07-31 19:51   ` Wolfram Sang
2019-07-10 21:51 ` [PATCH 4/6] media: i2c: s5c73m3: " Kieran Bingham
2019-07-10 21:51   ` Kieran Bingham
2019-07-12 10:27   ` Andrzej Hajda
2019-07-31 19:51   ` Wolfram Sang
2019-07-10 21:51 ` [PATCH 5/6] media: i2c: et8ek8: " Kieran Bingham
2019-07-10 21:51   ` Kieran Bingham
2019-07-31 19:52   ` Wolfram Sang
2019-07-10 21:51 ` [PATCH 6/6] media: i2c: " Kieran Bingham
2019-07-10 21:51   ` Kieran Bingham
2019-07-11  8:05   ` Marco Felsch
2019-07-11  8:05     ` Marco Felsch
2019-07-11  8:18     ` Kieran Bingham
2019-07-11  8:18       ` Kieran Bingham
2019-07-12 10:46       ` Marco Felsch
2019-07-12 10:46         ` Marco Felsch
2019-07-12 10:29   ` Andrzej Hajda
2019-07-12 10:29     ` Andrzej Hajda
2019-07-31 19:53   ` Wolfram Sang
2019-07-31 19:53     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710215149.9208-3-kieran.bingham+renesas@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=allison@lohutok.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pawel.mikolaj.chmiel@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.