All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Laurent Vivier <lvivier@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Wei Yang <richardw.yang@linux.intel.com>
Subject: [PULL 05/21] cutils: remove one unnecessary pointer operation
Date: Mon, 15 Jul 2019 15:51:09 +0200	[thread overview]
Message-ID: <20190715135125.17770-6-quintela@redhat.com> (raw)
In-Reply-To: <20190715135125.17770-1-quintela@redhat.com>

From: Wei Yang <richardw.yang@linux.intel.com>

Since we will not operate on the next address pointed by out, it is not
necessary to do addition on it.

After removing the operation, the function size reduced 16/18 bytes.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190610030852.16039-2-richardw.yang@linux.intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 util/cutils.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/util/cutils.c b/util/cutils.c
index dfc605f1ef..fd591cadf0 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -756,11 +756,11 @@ int uleb128_encode_small(uint8_t *out, uint32_t n)
 {
     g_assert(n <= 0x3fff);
     if (n < 0x80) {
-        *out++ = n;
+        *out = n;
         return 1;
     } else {
         *out++ = (n & 0x7f) | 0x80;
-        *out++ = n >> 7;
+        *out = n >> 7;
         return 2;
     }
 }
@@ -768,7 +768,7 @@ int uleb128_encode_small(uint8_t *out, uint32_t n)
 int uleb128_decode_small(const uint8_t *in, uint32_t *n)
 {
     if (!(*in & 0x80)) {
-        *n = *in++;
+        *n = *in;
         return 1;
     } else {
         *n = *in++ & 0x7f;
@@ -776,7 +776,7 @@ int uleb128_decode_small(const uint8_t *in, uint32_t *n)
         if (*in & 0x80) {
             return -1;
         }
-        *n |= *in++ << 7;
+        *n |= *in << 7;
         return 2;
     }
 }
-- 
2.21.0


WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Wei Yang <richardw.yang@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 05/21] cutils: remove one unnecessary pointer operation
Date: Mon, 15 Jul 2019 15:51:09 +0200	[thread overview]
Message-ID: <20190715135125.17770-6-quintela@redhat.com> (raw)
In-Reply-To: <20190715135125.17770-1-quintela@redhat.com>

From: Wei Yang <richardw.yang@linux.intel.com>

Since we will not operate on the next address pointed by out, it is not
necessary to do addition on it.

After removing the operation, the function size reduced 16/18 bytes.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190610030852.16039-2-richardw.yang@linux.intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 util/cutils.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/util/cutils.c b/util/cutils.c
index dfc605f1ef..fd591cadf0 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -756,11 +756,11 @@ int uleb128_encode_small(uint8_t *out, uint32_t n)
 {
     g_assert(n <= 0x3fff);
     if (n < 0x80) {
-        *out++ = n;
+        *out = n;
         return 1;
     } else {
         *out++ = (n & 0x7f) | 0x80;
-        *out++ = n >> 7;
+        *out = n >> 7;
         return 2;
     }
 }
@@ -768,7 +768,7 @@ int uleb128_encode_small(uint8_t *out, uint32_t n)
 int uleb128_decode_small(const uint8_t *in, uint32_t *n)
 {
     if (!(*in & 0x80)) {
-        *n = *in++;
+        *n = *in;
         return 1;
     } else {
         *n = *in++ & 0x7f;
@@ -776,7 +776,7 @@ int uleb128_decode_small(const uint8_t *in, uint32_t *n)
         if (*in & 0x80) {
             return -1;
         }
-        *n |= *in++ << 7;
+        *n |= *in << 7;
         return 2;
     }
 }
-- 
2.21.0



  parent reply	other threads:[~2019-07-15 13:52 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 13:51 [PULL 00/21] Migration pull request Juan Quintela
2019-07-15 13:51 ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 01/21] migration: fix multifd_recv event typo Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 02/21] migration-test: rename parameter to parameter_int Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 03/21] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 04/21] migration/xbzrle: update cache and current_data in one place Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` Juan Quintela [this message]
2019-07-15 13:51   ` [Qemu-devel] [PULL 05/21] cutils: remove one unnecessary pointer operation Juan Quintela
2019-07-15 13:51 ` [PULL 06/21] migration/multifd: sync packet_num after all thread are done Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 07/21] migration/ram.c: reset complete_round when we gets a queued page Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 08/21] migration: No need to take rcu during sync_dirty_bitmap Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 09/21] memory: Don't set migration bitmap when without migration Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 10/21] bitmap: Add bitmap_copy_with_{src|dst}_offset() Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 11/21] memory: Pass mr into snapshot_and_clear_dirty Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 12/21] memory: Introduce memory listener hook log_clear() Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 13/21] kvm: Update comments for sync_dirty_bitmap Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 14/21] kvm: Persistent per kvmslot dirty bitmap Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 15/21] kvm: Introduce slots lock for memory listener Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 16/21] kvm: Support KVM_CLEAR_DIRTY_LOG Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 17/21] migration: Split log_clear() into smaller chunks Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 18/21] migration: allow private destination ram with x-ignore-shared Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 19/21] migration/postcopy: fix document of postcopy_send_discard_bm_ram() Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 20/21] migration/postcopy: remove redundant cpu_synchronize_all_post_init Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 13:51 ` [PULL 21/21] migration: always initial RAMBlock.bmap to 1 for new migration Juan Quintela
2019-07-15 13:51   ` [Qemu-devel] " Juan Quintela
2019-07-15 15:11 ` [Qemu-devel] [PULL 00/21] Migration pull request Peter Maydell
2019-07-15 15:11   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715135125.17770-6-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richardw.yang@linux.intel.com \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.